aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Antoniadis <george@noodles.gr>2023-04-03 07:13:06 +0100
committerTill Faelligen <2353100+S7evinK@users.noreply.github.com>2023-04-03 08:24:47 +0200
commit44ed0a327948c0c8812fe2a895af4c3dfde0c33d (patch)
treed93af815e01f6a546bf4ed31413431a4d55a3cf5
parent2854ffeb7d933f76cbdfe0eb6775a8f5699f4170 (diff)
add deployment strategy option to helm chart (#3021)
@S7evinK minor update to the helm chart on top of you existing fixes to allow setting the update strategy as the default `RollingUpdate` one is a bit annoying if using `ReadWriteOnce` volumes for media. Hope this makes sense. ### Pull Request Checklist <!-- Please read https://matrix-org.github.io/dendrite/development/contributing before submitting your pull request --> * [x] ~~I have added Go unit tests or [Complement integration tests](https://github.com/matrix-org/complement) for this PR _or_ I have justified why this PR doesn't need tests~~ Haven't touched any go files. * [x] Pull request includes a [sign off below using a legally identifiable name](https://matrix-org.github.io/dendrite/development/contributing#sign-off) _or_ I have already signed off privately Signed-off-by: `George Antoniadis <george@noodles.gr>` [skip ci]
-rw-r--r--helm/dendrite/templates/deployment.yaml7
-rw-r--r--helm/dendrite/values.yaml10
2 files changed, 17 insertions, 0 deletions
diff --git a/helm/dendrite/templates/deployment.yaml b/helm/dendrite/templates/deployment.yaml
index 2a0f3a9e..55ae053f 100644
--- a/helm/dendrite/templates/deployment.yaml
+++ b/helm/dendrite/templates/deployment.yaml
@@ -19,6 +19,13 @@ spec:
annotations:
confighash: secret-{{ .Values.dendrite_config | toYaml | sha256sum | trunc 32 }}
spec:
+ strategy:
+ type: {{ $.Values.strategy.type }}
+ {{- if eq $.Values.strategy.type "RollingUpdate" }}
+ rollingUpdate:
+ maxSurge: {{ $.Values.strategy.rollingUpdate.maxSurge }}
+ maxUnavailable: {{ $.Values.strategy.rollingUpdate.maxUnavailable }}
+ {{- end }}
volumes:
- name: {{ include "dendrite.fullname" . }}-conf-vol
secret:
diff --git a/helm/dendrite/values.yaml b/helm/dendrite/values.yaml
index c219d27f..d6be2cdb 100644
--- a/helm/dendrite/values.yaml
+++ b/helm/dendrite/values.yaml
@@ -43,6 +43,16 @@ persistence:
# -- PVC Storage Request for the search volume
capacity: "1Gi"
+strategy:
+ # -- Strategy to use for rolling updates (e.g. Recreate, RollingUpdate)
+ # If you are using ReadWriteOnce volumes, you should probably use Recreate
+ type: RollingUpdate
+ rollingUpdate:
+ # -- Maximum number of pods that can be unavailable during the update process
+ maxUnavailable: 25%
+ # -- Maximum number of pods that can be scheduled above the desired number of pods
+ maxSurge: 25%
+
dendrite_config:
version: 2
global: