diff options
| author | fanquake <fanquake@gmail.com> | 2022-12-10 09:54:23 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-12-10 09:58:33 +0000 |
| commit | 3b5fb6e77a93f58b3d03b1eec3595f5c45e633a9 (patch) | |
| tree | 9b5c23e1609cd7c9ad093c248adf494d46dd1349 /test | |
| parent | 9e229a542ff2107be43eff2e4b992841367f0366 (diff) | |
| parent | fa0153e609caf61a59efb0779e754861edc1684d (diff) | |
| download | bitcoin-3b5fb6e77a93f58b3d03b1eec3595f5c45e633a9.tar.xz | |
Merge bitcoin/bitcoin#26213: rpc: Strict type checking for RPC boolean parameters
fa0153e609caf61a59efb0779e754861edc1684d refactor: Replace isTrue with get_bool (MarcoFalke)
fa2cc5d1d66aa00e828d1bb65b9923f76fbdf4e1 bugfix: Strict type checking for RPC boolean parameters (MarcoFalke)
Pull request description:
ACKs for top commit:
ryanofsky:
Code review ACK fa0153e609caf61a59efb0779e754861edc1684d
furszy:
Code ACK fa0153e6
Tree-SHA512: b221f823c69d90c94447fd491071ff3659cfd512872b495ebc3e711f50633351974102c9ef7e50fa4a393c4131d349adea8fd41cc9d66f1f31e1f5e7a5f78757
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/rpc_net.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 0501befe0f..06e76c4f92 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -307,6 +307,9 @@ class NetTest(BitcoinTestFramework): assert_equal(node.addpeeraddress(address="", port=8333), {"success": False}) assert_equal(node.getnodeaddresses(count=0), []) + self.log.debug("Test that non-bool tried fails") + assert_raises_rpc_error(-3, "JSON value of type string is not of expected type bool", self.nodes[0].addpeeraddress, address="1.2.3.4", tried="True", port=1234) + self.log.debug("Test that adding an address with invalid port fails") assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress, address="1.2.3.4", port=-1) assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress,address="1.2.3.4", port=65536) |