From fa2cc5d1d66aa00e828d1bb65b9923f76fbdf4e1 Mon Sep 17 00:00:00 2001 From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> Date: Mon, 5 Dec 2022 15:15:36 +0100 Subject: bugfix: Strict type checking for RPC boolean parameters --- test/functional/rpc_net.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'test') diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 0501befe0f..06e76c4f92 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -307,6 +307,9 @@ class NetTest(BitcoinTestFramework): assert_equal(node.addpeeraddress(address="", port=8333), {"success": False}) assert_equal(node.getnodeaddresses(count=0), []) + self.log.debug("Test that non-bool tried fails") + assert_raises_rpc_error(-3, "JSON value of type string is not of expected type bool", self.nodes[0].addpeeraddress, address="1.2.3.4", tried="True", port=1234) + self.log.debug("Test that adding an address with invalid port fails") assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress, address="1.2.3.4", port=-1) assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress,address="1.2.3.4", port=65536) -- cgit v1.2.3