aboutsummaryrefslogtreecommitdiff
path: root/yt_dlp/postprocessor/embedthumbnail.py
AgeCommit message (Collapse)Author
2024-11-17[cleanup] Deprecate more compat functions (#11439)sepro
Authored by: seproDev
2024-07-02[pp/embedthumbnail] Fix embedding with mutagen (#10337)bashonly
Fixes regression in f2a4ea1794718e4dc0148bc172cb877f1080903b Closes #10335 Authored by: bashonly
2024-06-27[pp/embedthumbnail] Fix postprocessor (#10248)Simon Sawicki
* [compat] Improve `imghdr.what` detection * [pp/embedthumbnail] Improve imghdr fail message * [pp/embedthumbnail] Fix AtomicParsley error handling Authored by: Grub4K
2024-06-12[cleanup] Add more ruff rules (#10149)sepro
Authored by: seproDev Reviewed-by: bashonly <88596187+bashonly@users.noreply.github.com> Reviewed-by: Simon Sawicki <contact@grub4k.xyz>
2024-03-11[docs] Misc Cleanup (#8977)pukkandan
Closes #8355, #8944 Authored by: bashonly, Grub4k, Arthurszzz, seproDev, pukkandan Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com> Co-authored-by: bashonly <bashonly@protonmail.com> Co-authored-by: Arthurszzz <minecraftgamerarthur@gmail.com> Co-authored-by: Simon Sawicki <accounts@grub4k.xyz> Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
2023-07-14[pp/EmbedThumbnail] Support `m4v` (#7583)Neurognostic
Authored by: Neurognostic
2023-03-28[postprocessor/EmbedThumbnail,postprocessor/FFmpegMetadata] Fix error on ↵Lesmiscore
attaching thumbnails and info json for mkv/mka (#6647) Authored by: Lesmiscore Current yt-dlp code never hit this bug, but would hit once filename sanitization gets better
2022-10-07[embedthumbnail] Fix thumbnail name in mp3 (#5163)Noah
Authored by: How-Bout-No
2022-08-11[postprocessor/embedthumbnail] Detect libatomicparsley.sopukkandan
2022-06-16[utils] `Popen`: Refactor to use contextmanagerpukkandan
Fixes https://github.com/yt-dlp/yt-dlp/issues/3531#issuecomment-1156223597
2022-05-17[compat] Implement `compat.imghdr`pukkandan
Python 3.11 deprecates `imghdr` module
2022-05-01[EmbedThumbnail] Do not obey `-k`pukkandan
2022-04-29[cleanup] Misc fixespukkandan
Closes #3565, https://github.com/yt-dlp/yt-dlp/issues/3514#issuecomment-1105944364
2022-04-21[EmbedThumbnail] Disable thumbnail conversion for mkv (#3512)Evan Spensley
Closes #3209 Authored by: evansp
2022-04-21[dependencies] Create module with all dependency importspukkandan
2022-04-12[cleanup] Sort importspukkandan
Using https://github.com/PyCQA/isort isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .
2022-04-12[cleanup] Upgrade syntaxpukkandan
Using https://github.com/asottile/pyupgrade 1. `__future__` imports and `coding: utf-8` were removed 2. Files were rewritten with `pyupgrade --py36-plus --keep-percent-format` 3. f-strings were cherry-picked from `pyupgrade --py36-plus` Extractors are left untouched (except removing header) to avoid unnecessary merge conflicts
2022-04-10[EmbedThumbnail] Do not remove id3v1 tagspukkandan
2022-01-12[ffmpeg] Standardize use of `-map 0`pukkandan
Closes #2182
2021-12-27[EmbedThumbnail] Prefer AtomicParsley over ffmpeg if availablepukkandan
2021-10-20Don't create console for subprocesses on Windows (#1261)pukkandan
Closes #1251
2021-08-27Use `os.replace` where applicable (#793)Paul Wrubel
When using ```py os.remove(encodeFilename(filename)) os.rename(encodeFilename(temp_filename), encodeFilename(filename)) ``` the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead Authored by: paulwrubel
2021-07-11[embedthumbnail] Fix `_get_thumbnail_resolution`pukkandan
2021-06-25[thumbnailsconvertor] Treat `jpeg` as `jpg`pukkandan
2021-06-16[EmbedThumbnail] Add compat-option `embed-thumbnail-atomicparsley`pukkandan
to force use of atomicparsley for embedding thumbnails in mp4 Related: #411
2021-06-13Allow `images` formatspukkandan
Necessary for #343. * They are identified by `vcodec=acodec='none'` * These formats show as the worst in `-F` * Any postprocessor that expects audio/video will be skipped * `b*` and all related selectors will skip such formats * This commit also does not add any selector for downloading such formats. They have to be explicitly requested by the `format_id`. Implementation of a selector is left for when #389 is resolved
2021-05-29[embedthumbnail] Correctly escape filenamepukkandan
Closes #352 The approach in [1] is faulty as can be seen in the test cases 1. https://github.com/ytdl-org/youtube-dl/commit/bff857a8af696e701482208617bf0b7564951326
2021-05-29[embedthumbnail] Embed if any thumbnail was downloaded, not just the bestpukkandan
2021-05-23[ard] Allow URLs without `-` before idOliver Freyermuth
https://github.com/ytdl-org/youtube-dl/pull/29091 Authored by: olifre
2021-05-23[embedthumbnail] Embed in `mp4`/`m4a` using mutagenpukkandan
Code from: https://github.com/ytdl-org/youtube-dl/pull/23525 Co-authored by: tripulse , pukkandan
2021-05-21[ThumbnailsConvertor] Support conversion to `png` and make it the default (#333)louie-github
PNG, being a lossless format, should be a better default here compared to JPG since we won't be compressing to a lossy format and losing some of the original image data PNG is also supported for embedding in all the formats similar to JPEG Authored by: louie-github
2021-05-20[cleanup] See descpukkandan
* Remove struct from `embedthumbnail` * Use bullet lists in readme where numbered list don't make sense * Fix error introduced in 9c2b75b5616f058c3970e54c664e9543f86b9f0c when `ie_result` is `None`
2021-05-20[embedthumbnail] Add `flac` support and refactor `mutagen` codepukkandan
https://github.com/ytdl-org/youtube-dl/pull/28894, https://github.com/ytdl-org/youtube-dl/pull/24310 Authored by: tripulse
2021-05-04[embedthumbnail] Fix bug where jpeg thumbnails were converted againpukkandan
Closes #297
2021-04-12Add option `--convert-thumbnails`pukkandan
Closes: https://github.com/yt-dlp/yt-dlp/issues/99 https://github.com/yt-dlp/yt-dlp/issues/102
2021-04-12Allow running some `postprocessors` before actual downloadpukkandan
2021-03-20More consistent warning messages (#173)pukkandan
Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>
2021-03-18[movefiles] Fix bugs and make more robustpukkandan
2021-03-14[embedthumbnail] Set mtime correctlypukkandan
Related: https://github.com/yt-dlp/yt-dlp/issues/67
2021-03-14Refactor (See desc)pukkandan
* Create `FFmpegPostProcessor.real_run_ffmpeg` that can accept multiple input/output files along with switches for each * Rewrite `cli_configuration_args` and related functions * Create `YoutubeDL._ensure_dir_exists` - this was previously defined in multiple places
2021-02-25[embedthumbnail] Fix bug with deleting original thumbnail (Closes #113)pukkandan
:ci skip dl
2021-02-25Completely change project name to yt-dlp (#85)Pccode66
* All modules and binary names are changed * All documentation references changed * yt-dlp no longer loads youtube-dlc config files * All URLs changed to point to organization account Co-authored-by: Pccode66 Co-authored-by: pukkandan