diff options
author | coletdjnz <coletdjnz@protonmail.com> | 2024-02-18 11:32:34 +1300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-18 11:32:34 +1300 |
commit | 0085e2bab8465ee7d46d16fcade3ed5e96cc8a48 (patch) | |
tree | 387efcea430e49942f021f5786b1eb12b88edfe1 /yt_dlp/networking/_requests.py | |
parent | 73fcfa39f59113a8728249de2c4cee3025f17dc2 (diff) |
[rh] Remove additional logging handlers on close (#9032)
Fixes https://github.com/yt-dlp/yt-dlp/issues/8922
Authored by: coletdjnz
Diffstat (limited to 'yt_dlp/networking/_requests.py')
-rw-r--r-- | yt_dlp/networking/_requests.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/yt_dlp/networking/_requests.py b/yt_dlp/networking/_requests.py index 00e4bdb49..7b19029bf 100644 --- a/yt_dlp/networking/_requests.py +++ b/yt_dlp/networking/_requests.py @@ -258,10 +258,10 @@ class RequestsRH(RequestHandler, InstanceStoreMixin): # Forward urllib3 debug messages to our logger logger = logging.getLogger('urllib3') - handler = Urllib3LoggingHandler(logger=self._logger) - handler.setFormatter(logging.Formatter('requests: %(message)s')) - handler.addFilter(Urllib3LoggingFilter()) - logger.addHandler(handler) + self.__logging_handler = Urllib3LoggingHandler(logger=self._logger) + self.__logging_handler.setFormatter(logging.Formatter('requests: %(message)s')) + self.__logging_handler.addFilter(Urllib3LoggingFilter()) + logger.addHandler(self.__logging_handler) # TODO: Use a logger filter to suppress pool reuse warning instead logger.setLevel(logging.ERROR) @@ -276,6 +276,9 @@ class RequestsRH(RequestHandler, InstanceStoreMixin): def close(self): self._clear_instances() + # Remove the logging handler that contains a reference to our logger + # See: https://github.com/yt-dlp/yt-dlp/issues/8922 + logging.getLogger('urllib3').removeHandler(self.__logging_handler) def _check_extensions(self, extensions): super()._check_extensions(extensions) |