aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbashonly <88596187+bashonly@users.noreply.github.com>2024-03-14 16:10:20 -0500
committerGitHub <noreply@github.com>2024-03-14 21:10:20 +0000
commit17b96974a334688f76b57d350e07cae8cda46877 (patch)
tree9347b7f7dc152e4a650615ae021e580578c9747b
parent8463fb510a58050ec118b3ae17bf00d08ea7b881 (diff)
[build] Update changelog for tarball and sdist (#9425)
Closes #9417 Authored by: bashonly
-rw-r--r--.github/workflows/build.yml3
-rw-r--r--.github/workflows/release.yml8
-rw-r--r--Makefile15
-rw-r--r--devscripts/make_changelog.py51
-rwxr-xr-xdevscripts/update_changelog.py26
5 files changed, 72 insertions, 31 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 4bed5af6a..dcbb8c501 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -107,6 +107,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
+ with:
+ fetch-depth: 0 # Needed for changelog
- uses: actions/setup-python@v5
with:
python-version: "3.10"
@@ -133,6 +135,7 @@ jobs:
- name: Prepare
run: |
python devscripts/update-version.py -c "${{ inputs.channel }}" -r "${{ needs.process.outputs.origin }}" "${{ inputs.version }}"
+ python devscripts/update_changelog.py -vv
python devscripts/make_lazy_extractors.py
- name: Build Unix platform-independent binary
run: |
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index fd99cecd1..32268b32f 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -189,13 +189,8 @@ jobs:
if: |
!inputs.prerelease && env.target_repo == github.repository
run: |
+ python devscripts/update_changelog.py -vv
make doc
- sed '/### /Q' Changelog.md >> ./CHANGELOG
- echo '### ${{ env.version }}' >> ./CHANGELOG
- python ./devscripts/make_changelog.py -vv -c >> ./CHANGELOG
- echo >> ./CHANGELOG
- grep -Poz '(?s)### \d+\.\d+\.\d+.+' 'Changelog.md' | head -n -1 >> ./CHANGELOG
- cat ./CHANGELOG > Changelog.md
- name: Push to release
id: push_release
@@ -266,6 +261,7 @@ jobs:
pypi_project: ${{ needs.prepare.outputs.pypi_project }}
run: |
python devscripts/update-version.py -c "${{ env.channel }}" -r "${{ env.target_repo }}" -s "${{ env.suffix }}" "${{ env.version }}"
+ python devscripts/update_changelog.py -vv
python devscripts/make_lazy_extractors.py
sed -i -E '0,/(name = ")[^"]+(")/s//\1${{ env.pypi_project }}\2/' pyproject.toml
diff --git a/Makefile b/Makefile
index 9344003f8..38c6b4f2d 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@ all: lazy-extractors yt-dlp doc pypi-files
clean: clean-test clean-dist
clean-all: clean clean-cache
completions: completion-bash completion-fish completion-zsh
-doc: README.md CONTRIBUTING.md issuetemplates supportedsites
+doc: README.md CONTRIBUTING.md CONTRIBUTORS issuetemplates supportedsites
ot: offlinetest
tar: yt-dlp.tar.gz
@@ -156,5 +156,14 @@ yt-dlp.tar.gz: all
Makefile yt-dlp.1 README.txt completions .gitignore \
setup.cfg yt-dlp yt_dlp pyproject.toml devscripts test
-AUTHORS:
- git shortlog -s -n HEAD | cut -f2 | sort > AUTHORS
+AUTHORS: Changelog.md
+ @if [ -d '.git' ] && command -v git > /dev/null ; then \
+ echo 'Generating $@ from git commit history' ; \
+ git shortlog -s -n HEAD | cut -f2 | sort > $@ ; \
+ fi
+
+CONTRIBUTORS: Changelog.md
+ @if [ -d '.git' ] && command -v git > /dev/null ; then \
+ echo 'Updating $@ from git commit history' ; \
+ $(PYTHON) devscripts/make_changelog.py -v -c > /dev/null ; \
+ fi
diff --git a/devscripts/make_changelog.py b/devscripts/make_changelog.py
index faab5fa86..8e199e7d0 100644
--- a/devscripts/make_changelog.py
+++ b/devscripts/make_changelog.py
@@ -445,7 +445,32 @@ def get_new_contributors(contributors_path, commits):
return sorted(new_contributors, key=str.casefold)
-if __name__ == '__main__':
+def create_changelog(args):
+ logging.basicConfig(
+ datefmt='%Y-%m-%d %H-%M-%S', format='{asctime} | {levelname:<8} | {message}',
+ level=logging.WARNING - 10 * args.verbosity, style='{', stream=sys.stderr)
+
+ commits = CommitRange(None, args.commitish, args.default_author)
+
+ if not args.no_override:
+ if args.override_path.exists():
+ overrides = json.loads(read_file(args.override_path))
+ commits.apply_overrides(overrides)
+ else:
+ logger.warning(f'File {args.override_path.as_posix()} does not exist')
+
+ logger.info(f'Loaded {len(commits)} commits')
+
+ new_contributors = get_new_contributors(args.contributors_path, commits)
+ if new_contributors:
+ if args.contributors:
+ write_file(args.contributors_path, '\n'.join(new_contributors) + '\n', mode='a')
+ logger.info(f'New contributors: {", ".join(new_contributors)}')
+
+ return Changelog(commits.groups(), args.repo, args.collapsible)
+
+
+def create_parser():
import argparse
parser = argparse.ArgumentParser(
@@ -477,27 +502,9 @@ if __name__ == '__main__':
parser.add_argument(
'--collapsible', action='store_true',
help='make changelog collapsible (default: %(default)s)')
- args = parser.parse_args()
-
- logging.basicConfig(
- datefmt='%Y-%m-%d %H-%M-%S', format='{asctime} | {levelname:<8} | {message}',
- level=logging.WARNING - 10 * args.verbosity, style='{', stream=sys.stderr)
-
- commits = CommitRange(None, args.commitish, args.default_author)
-
- if not args.no_override:
- if args.override_path.exists():
- overrides = json.loads(read_file(args.override_path))
- commits.apply_overrides(overrides)
- else:
- logger.warning(f'File {args.override_path.as_posix()} does not exist')
- logger.info(f'Loaded {len(commits)} commits')
+ return parser
- new_contributors = get_new_contributors(args.contributors_path, commits)
- if new_contributors:
- if args.contributors:
- write_file(args.contributors_path, '\n'.join(new_contributors) + '\n', mode='a')
- logger.info(f'New contributors: {", ".join(new_contributors)}')
- print(Changelog(commits.groups(), args.repo, args.collapsible))
+if __name__ == '__main__':
+ print(create_changelog(create_parser().parse_args()))
diff --git a/devscripts/update_changelog.py b/devscripts/update_changelog.py
new file mode 100755
index 000000000..36b9a8e86
--- /dev/null
+++ b/devscripts/update_changelog.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python3
+
+# Allow direct execution
+import os
+import sys
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+from pathlib import Path
+
+from devscripts.make_changelog import create_changelog, create_parser
+from devscripts.utils import read_file, read_version, write_file
+
+# Always run after devscripts/update-version.py, and run before `make doc|pypi-files|tar|all`
+
+if __name__ == '__main__':
+ parser = create_parser()
+ parser.description = 'Update an existing changelog file with an entry for a new release'
+ parser.add_argument(
+ '--changelog-path', type=Path, default=Path(__file__).parent.parent / 'Changelog.md',
+ help='path to the Changelog file')
+ args = parser.parse_args()
+ new_entry = create_changelog(args)
+
+ header, sep, changelog = read_file(args.changelog_path).partition('\n### ')
+ write_file(args.changelog_path, f'{header}{sep}{read_version()}\n{new_entry}\n{sep}{changelog}')