diff options
| author | Yen Chi Hsuan <yan12125@gmail.com> | 2016-08-25 22:38:06 +0800 |
|---|---|---|
| committer | Yen Chi Hsuan <yan12125@gmail.com> | 2016-08-25 22:38:06 +0800 |
| commit | 20bad91d765284e06f8a8c600a122857d23efeea (patch) | |
| tree | d982b70e1d549491404519562993ef877bd28732 | |
| parent | b54a2da4333556baa3b34fc595060223181320d1 (diff) | |
[downloader/external] Clarify that ffmpeg doesn't support SOCKS
Ref: #10304
| -rw-r--r-- | youtube_dl/downloader/external.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/youtube_dl/downloader/external.py b/youtube_dl/downloader/external.py index cf4556221..17f12e970 100644 --- a/youtube_dl/downloader/external.py +++ b/youtube_dl/downloader/external.py @@ -220,6 +220,11 @@ class FFmpegFD(ExternalFD): if proxy: if not re.match(r'^[\da-zA-Z]+://', proxy): proxy = 'http://%s' % proxy + + if proxy.startswith('socks'): + self.report_warning( + '%s does not support SOCKS proxies. Downloading may fail.' % self.get_basename()) + # Since December 2015 ffmpeg supports -http_proxy option (see # http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b4eb1f29ebddd60c41a2eb39f5af701e38e0d3fd) # We could switch to the following code if we are able to detect version properly |