From 20bad91d765284e06f8a8c600a122857d23efeea Mon Sep 17 00:00:00 2001
From: Yen Chi Hsuan <yan12125@gmail.com>
Date: Thu, 25 Aug 2016 22:38:06 +0800
Subject: [downloader/external] Clarify that ffmpeg doesn't support SOCKS
Ref: #10304
---
youtube_dl/downloader/external.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/youtube_dl/downloader/external.py b/youtube_dl/downloader/external.py
index cf4556221..17f12e970 100644
--- a/youtube_dl/downloader/external.py
+++ b/youtube_dl/downloader/external.py
@@ -220,6 +220,11 @@ class FFmpegFD(ExternalFD):
if proxy:
if not re.match(r'^[\da-zA-Z]+://', proxy):
proxy = 'http://%s' % proxy
+
+ if proxy.startswith('socks'):
+ self.report_warning(
+ '%s does not support SOCKS proxies. Downloading may fail.' % self.get_basename())
+
# Since December 2015 ffmpeg supports -http_proxy option (see
# http://git.videolan.org/?p=ffmpeg.git;a=commit;h=b4eb1f29ebddd60c41a2eb39f5af701e38e0d3fd)
# We could switch to the following code if we are able to detect version properly
--
cgit v1.2.3