| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Certain seek patterns on a file inside a non-compressed rar file can
cause CmdExtract::UnstoreFile() to think that the destination buffer has
been filled (as DestUnpSize counter, originally set to the file size,
reaches zero).
However, counting written bytes using DestUnpSize doesn't make sense for
the UnpackToMemory codepath used for non-compressed rar files, as there
can be seeks which can eventually cause more data to be read than what
the actual file size was. The actual output buffer is internally handled
by ComprDataIO.
The check in UnstoreFile() will result in not all data being written to
the destination buffer, causing CRarFile::Read() to return old stale
data.
Fix that by dropping the unnecessary DestUnpSize handling in
UnpackToMemory codepath of CmdExtract::UnstoreFile().
|
|
Also:
[fix] threads: fix race condition when stopping thread - cherry pick merge
Also, from jimfcarroll:
[fixed] AirPlayServer now complies with the new CThread constructor requirements (that is, you must supply a thread name).
replace custom thread local storage with the XbmcThreads::ThreadLocal template.
[cosmetic] removed incorrect hungarian notation.
[cleanup] Removed XSyncUtils. Moved the GlobalMemoryStatus call to XMemUtil. Cleaned up code that used the #define INFINITE from XSyncUtils.h
[cleanup] Some miscellaneous cleanup. Fixed initialization warning in LCD. Removed some unused functions and members.
[cleanup] PAPlayer warning due to constructor initialization list order.
|
|
|
|
|
|
In several places in the rar code the new threading mechanisms were not used in a "functionally equivalent" manner. In five places the original code checked for a timeout using a "!= WAIT_OBJECT_0" which was interpreted as checking for a signaled state as if the "!" wasn't there. This commit fixes that problem.
|
|
replaced them with the latest CEvent calls.
|
|
Squashed commit due to build breakage during code-reshuffle history.
Conflicts:
xbmc/Util.cpp
xbmc/cdrip/CDDARipper.cpp
xbmc/filesystem/Directory.cpp
xbmc/filesystem/File.cpp
|
