changed: always grab both local and repository add-ons in the info dialog

this fixes the annoying bug where we show the local changelog for add-ons
with available updates. fixes #11503

1 files changed, 6 insertions, 10 deletions

diff --git a/xbmc/addons/GUIDialogAddonInfo.cpp b/xbmc/addons/GUIDialogAddonInfo.cpp
index 97b0e7f1df..d5b23d19d8 100644
--- a/xbmc/addons/GUIDialogAddonInfo.cpp
+++ b/xbmc/addons/GUIDialogAddonInfo.cpp
@@ -234,21 +234,17 @@ bool CGUIDialogAddonInfo::SetItem(const CFileItemPtr& item)
   *m_item = *item;
 
   // grab the local addon, if it's available
-  m_addon.reset();
-  if (CAddonMgr::Get().GetAddon(item->GetProperty("Addon.ID"), m_addon)) // sets m_addon if installed regardless of enabled state
+  m_localAddon.reset();
+  if (CAddonMgr::Get().GetAddon(item->GetProperty("Addon.ID"), m_localAddon)) // sets m_addon if installed regardless of enabled state
     m_item->SetProperty("Addon.Enabled", "true");
   else
     m_item->SetProperty("Addon.Enabled", "false");
   m_item->SetProperty("Addon.Installed", m_addon ? "true" : "false");
-  m_localAddon = m_addon;
 
-  if (!m_addon)
-  { // coming from a repository
-    CAddonDatabase database;
-    database.Open();
-    if (!database.GetAddon(item->GetProperty("Addon.ID"),m_addon))
-      return false; // can't find the addon
-  }
+  CAddonDatabase database;
+  database.Open();
+  database.GetAddon(item->GetProperty("Addon.ID"),m_addon);
+
   if (TranslateType(item->GetProperty("Addon.intType")) == ADDON_REPOSITORY)
   {
     CAddonDatabase database;