aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsmp79 <sergey79@gmail.com>2022-07-05 02:54:51 +0300
committersmp79 <sergey79@gmail.com>2022-07-05 02:54:51 +0300
commitdf1d534ae925db6a6db83d9e3a13b4bf1ee9a2ec (patch)
tree268681c7d0156b6c775424a769571517386de56a
parenta7f66f24f77baaa64f2081002e4cd70ff5ec09e0 (diff)
don't require high quality scalers to be enabled through advancedsettings.xml
-rw-r--r--xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/RendererVDPAU.cpp7
-rw-r--r--xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.cpp9
-rw-r--r--xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGLES.cpp11
-rw-r--r--xbmc/settings/AdvancedSettings.cpp2
-rw-r--r--xbmc/settings/AdvancedSettings.h1
5 files changed, 2 insertions, 28 deletions
diff --git a/xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/RendererVDPAU.cpp b/xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/RendererVDPAU.cpp
index 930d88bd32..3063f60a1e 100644
--- a/xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/RendererVDPAU.cpp
+++ b/xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/RendererVDPAU.cpp
@@ -178,13 +178,6 @@ bool CRendererVDPAU::Supports(ESCALINGMETHOD method)
int minScale = CServiceBroker::GetSettingsComponent()->GetSettings()->GetInt("videoplayer.hqscalers");
if (scaleX < minScale && scaleY < minScale)
return false;
-
- // spline36 and lanczos3 are only allowed through advancedsettings.xml
- if(method != VS_SCALINGMETHOD_SPLINE36
- && method != VS_SCALINGMETHOD_LANCZOS3)
- return true;
- else
- return CServiceBroker::GetSettingsComponent()->GetAdvancedSettings()->m_videoEnableHighQualityHwScalers;
}
return false;
diff --git a/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.cpp b/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.cpp
index 89917eb419..5e5bd47c95 100644
--- a/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.cpp
+++ b/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGL.cpp
@@ -2600,14 +2600,7 @@ bool CLinuxRendererGL::Supports(ESCALINGMETHOD method)
if (m_renderSystem->IsExtSupported("GL_EXT_framebuffer_object"))
hasFramebuffer = true;
if (hasFramebuffer && (m_renderMethod & RENDER_GLSL))
- {
- // spline36 and lanczos3 are only allowed through advancedsettings.xml
- if(method != VS_SCALINGMETHOD_SPLINE36
- && method != VS_SCALINGMETHOD_LANCZOS3)
- return true;
- else
- return CServiceBroker::GetSettingsComponent()->GetAdvancedSettings()->m_videoEnableHighQualityHwScalers;
- }
+ return true;
}
return false;
diff --git a/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGLES.cpp b/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGLES.cpp
index d17bff50f5..6cfd5d1aed 100644
--- a/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGLES.cpp
+++ b/xbmc/cores/VideoPlayer/VideoRenderers/LinuxRendererGLES.cpp
@@ -1739,16 +1739,7 @@ bool CLinuxRendererGLES::Supports(ESCALINGMETHOD method)
if (m_renderMethod & RENDER_GLSL)
{
- // spline36 and lanczos3 are only allowed through advancedsettings.xml
- if(method != VS_SCALINGMETHOD_SPLINE36 &&
- method != VS_SCALINGMETHOD_LANCZOS3)
- {
- return true;
- }
- else
- {
- return CServiceBroker::GetSettingsComponent()->GetAdvancedSettings()->m_videoEnableHighQualityHwScalers;
- }
+ return true;
}
}
diff --git a/xbmc/settings/AdvancedSettings.cpp b/xbmc/settings/AdvancedSettings.cpp
index d46f34ad8e..3e1cc7e607 100644
--- a/xbmc/settings/AdvancedSettings.cpp
+++ b/xbmc/settings/AdvancedSettings.cpp
@@ -161,7 +161,6 @@ void CAdvancedSettings::Initialize()
m_videoPlayCountMinimumPercent = 90.0f;
m_videoVDPAUScaling = -1;
m_videoNonLinStretchRatio = 0.5f;
- m_videoEnableHighQualityHwScalers = false;
m_videoAutoScaleMaxFps = 30.0f;
m_videoCaptureUseOcclusionQuery = -1; //-1 is auto detect
m_videoVDPAUtelecine = false;
@@ -649,7 +648,6 @@ void CAdvancedSettings::ParseSettingsFile(const std::string &file)
XMLUtils::GetString(pElement,"ppffmpegpostprocessing",m_videoPPFFmpegPostProc);
XMLUtils::GetInt(pElement,"vdpauscaling",m_videoVDPAUScaling);
XMLUtils::GetFloat(pElement, "nonlinearstretchratio", m_videoNonLinStretchRatio, 0.01f, 1.0f);
- XMLUtils::GetBoolean(pElement,"enablehighqualityhwscalers", m_videoEnableHighQualityHwScalers);
XMLUtils::GetFloat(pElement,"autoscalemaxfps",m_videoAutoScaleMaxFps, 0.0f, 1000.0f);
XMLUtils::GetInt(pElement, "useocclusionquery", m_videoCaptureUseOcclusionQuery, -1, 1);
XMLUtils::GetBoolean(pElement,"vdpauInvTelecine",m_videoVDPAUtelecine);
diff --git a/xbmc/settings/AdvancedSettings.h b/xbmc/settings/AdvancedSettings.h
index 8528824fb8..7857c69004 100644
--- a/xbmc/settings/AdvancedSettings.h
+++ b/xbmc/settings/AdvancedSettings.h
@@ -162,7 +162,6 @@ class CAdvancedSettings : public ISettingCallback, public ISettingsHandler
int m_videoVDPAUScaling;
float m_videoNonLinStretchRatio;
- bool m_videoEnableHighQualityHwScalers;
float m_videoAutoScaleMaxFps;
std::vector<RefreshOverride> m_videoAdjustRefreshOverrides;
std::vector<RefreshVideoLatency> m_videoRefreshLatency;