diff options
| author | Garrett Brown <themagnificentmrb@gmail.com> | 2023-01-13 21:45:59 -0800 |
|---|---|---|
| committer | Garrett Brown <themagnificentmrb@gmail.com> | 2023-01-14 16:26:45 -0800 |
| commit | a06f7d47e149d6a10ca88e0e3c9b45611deecad7 (patch) | |
| tree | 88dd98c9b06d8a00cc3c7d2f42737bb6c1883e57 | |
| parent | 6048b035a3d7dd21f1e4870a783ad27f8b450e1f (diff) | |
RetroPlayer: Fix gamewindow control ignoring non-itemlayout properties
For non-itemlayout properties, UpdateInfo() can be called with a
nullptr item. In this case, we don't want to reset properties,
because they're not dynamic in the first place.
| -rw-r--r-- | xbmc/cores/RetroPlayer/guicontrols/GUIGameControl.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xbmc/cores/RetroPlayer/guicontrols/GUIGameControl.cpp b/xbmc/cores/RetroPlayer/guicontrols/GUIGameControl.cpp index c7ccd07b2c..85e127d7ef 100644 --- a/xbmc/cores/RetroPlayer/guicontrols/GUIGameControl.cpp +++ b/xbmc/cores/RetroPlayer/guicontrols/GUIGameControl.cpp @@ -126,10 +126,10 @@ void CGUIGameControl::SetHeight(float height) void CGUIGameControl::UpdateInfo(const CGUIListItem* item /* = nullptr */) { - Reset(); - if (item) { + Reset(); + std::string strVideoFilter = m_videoFilterInfo.GetItemLabel(item); if (!strVideoFilter.empty()) { |