aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKai Sommerfeld <kai.sommerfeld@gmx.com>2022-09-24 14:48:59 +0200
committerKai Sommerfeld <kai.sommerfeld@gmx.com>2022-09-27 13:17:58 +0200
commit9faeac6ba00ccc93a261fb96003771a876fa71be (patch)
treef4a2f91d52232b65a5852e3b23f11172ff26b648
parent77b534829b3349473fc5c84f1056ebdf570fc2fd (diff)
[PVR] Add CPVRGUIActionsEPG to PVR components.
-rw-r--r--xbmc/pvr/PVRComponentRegistration.cpp3
-rw-r--r--xbmc/pvr/PVRContextMenus.cpp15
-rw-r--r--xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp4
-rw-r--r--xbmc/pvr/dialogs/GUIDialogPVRItemsViewBase.cpp4
-rw-r--r--xbmc/pvr/dialogs/GUIDialogPVRRecordingInfo.cpp3
-rw-r--r--xbmc/pvr/guilib/PVRGUIActions.h4
-rw-r--r--xbmc/pvr/guilib/PVRGUIActionsEPG.h10
-rw-r--r--xbmc/pvr/guilib/PVRGUIActionsUtils.cpp5
-rw-r--r--xbmc/pvr/windows/GUIWindowPVRChannels.cpp4
-rw-r--r--xbmc/pvr/windows/GUIWindowPVRGuide.cpp7
-rw-r--r--xbmc/pvr/windows/GUIWindowPVRSearch.cpp3
11 files changed, 40 insertions, 22 deletions
diff --git a/xbmc/pvr/PVRComponentRegistration.cpp b/xbmc/pvr/PVRComponentRegistration.cpp
index 8661bb6684..83c36227f5 100644
--- a/xbmc/pvr/PVRComponentRegistration.cpp
+++ b/xbmc/pvr/PVRComponentRegistration.cpp
@@ -11,6 +11,7 @@
#include "pvr/guilib/PVRGUIActionsChannels.h"
#include "pvr/guilib/PVRGUIActionsClients.h"
#include "pvr/guilib/PVRGUIActionsDatabase.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include <memory>
@@ -21,10 +22,12 @@ CPVRComponentRegistration::CPVRComponentRegistration()
RegisterComponent(std::make_shared<CPVRGUIActionsChannels>());
RegisterComponent(std::make_shared<CPVRGUIActionsClients>());
RegisterComponent(std::make_shared<CPVRGUIActionsDatabase>());
+ RegisterComponent(std::make_shared<CPVRGUIActionsEPG>());
}
CPVRComponentRegistration::~CPVRComponentRegistration()
{
+ DeregisterComponent(typeid(CPVRGUIActionsEPG));
DeregisterComponent(typeid(CPVRGUIActionsDatabase));
DeregisterComponent(typeid(CPVRGUIActionsClients));
DeregisterComponent(typeid(CPVRGUIActionsChannels));
diff --git a/xbmc/pvr/PVRContextMenus.cpp b/xbmc/pvr/PVRContextMenus.cpp
index f5e38f057b..c47c72e5b7 100644
--- a/xbmc/pvr/PVRContextMenus.cpp
+++ b/xbmc/pvr/PVRContextMenus.cpp
@@ -19,6 +19,7 @@
#include "pvr/channels/PVRChannelGroupsContainer.h"
#include "pvr/epg/EpgInfoTag.h"
#include "pvr/guilib/PVRGUIActions.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "pvr/recordings/PVRRecording.h"
#include "pvr/recordings/PVRRecordings.h"
#include "pvr/recordings/PVRRecordingsPath.h"
@@ -173,7 +174,7 @@ namespace PVR
if (item->GetPVRRecordingInfoTag())
return CServiceBroker::GetPVRManager().GUIActions()->ShowRecordingInfo(item);
- return CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -190,7 +191,7 @@ namespace PVR
bool ShowChannelGuide::Execute(const CFileItemPtr& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->ShowChannelEPG(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowChannelEPG(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -218,7 +219,7 @@ namespace PVR
bool FindSimilar::Execute(const CFileItemPtr& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->FindSimilar(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().FindSimilar(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -653,7 +654,7 @@ namespace PVR
bool ExecuteSearch::Execute(const std::shared_ptr<CFileItem>& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->ExecuteSavedSearch(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ExecuteSavedSearch(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -666,7 +667,7 @@ namespace PVR
bool EditSearch::Execute(const std::shared_ptr<CFileItem>& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->EditSavedSearch(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().EditSavedSearch(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -679,7 +680,7 @@ namespace PVR
bool RenameSearch::Execute(const std::shared_ptr<CFileItem>& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->RenameSavedSearch(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().RenameSavedSearch(item);
}
///////////////////////////////////////////////////////////////////////////////
@@ -692,7 +693,7 @@ namespace PVR
bool DeleteSearch::Execute(const std::shared_ptr<CFileItem>& item) const
{
- return CServiceBroker::GetPVRManager().GUIActions()->DeleteSavedSearch(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().DeleteSavedSearch(item);
}
} // namespace CONEXTMENUITEM
diff --git a/xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp b/xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp
index b2e1d9d3b7..e1733ff571 100644
--- a/xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp
+++ b/xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp
@@ -15,6 +15,7 @@
#include "pvr/addons/PVRClient.h"
#include "pvr/epg/EpgInfoTag.h"
#include "pvr/guilib/PVRGUIActions.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "pvr/recordings/PVRRecordings.h"
#include "pvr/timers/PVRTimerInfoTag.h"
#include "pvr/timers/PVRTimers.h"
@@ -149,7 +150,8 @@ bool CGUIDialogPVRGuideInfo::OnClickButtonFind(const CGUIMessage& message)
if (message.GetSenderId() == CONTROL_BTN_FIND)
{
Close();
- return CServiceBroker::GetPVRManager().GUIActions()->FindSimilar(std::make_shared<CFileItem>(m_progItem));
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().FindSimilar(
+ std::make_shared<CFileItem>(m_progItem));
}
return bReturn;
diff --git a/xbmc/pvr/dialogs/GUIDialogPVRItemsViewBase.cpp b/xbmc/pvr/dialogs/GUIDialogPVRItemsViewBase.cpp
index 636c15b4e3..be818e5839 100644
--- a/xbmc/pvr/dialogs/GUIDialogPVRItemsViewBase.cpp
+++ b/xbmc/pvr/dialogs/GUIDialogPVRItemsViewBase.cpp
@@ -15,7 +15,7 @@
#include "input/actions/Action.h"
#include "input/actions/ActionIDs.h"
#include "pvr/PVRManager.h"
-#include "pvr/guilib/PVRGUIActions.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "view/ViewState.h"
#include <utility>
@@ -95,7 +95,7 @@ void CGUIDialogPVRItemsViewBase::ShowInfo(int itemIdx)
if (!item)
return;
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(item);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(item);
}
bool CGUIDialogPVRItemsViewBase::ContextMenu(int itemIdx)
diff --git a/xbmc/pvr/dialogs/GUIDialogPVRRecordingInfo.cpp b/xbmc/pvr/dialogs/GUIDialogPVRRecordingInfo.cpp
index 1cf4655c0b..8cc93fdeb1 100644
--- a/xbmc/pvr/dialogs/GUIDialogPVRRecordingInfo.cpp
+++ b/xbmc/pvr/dialogs/GUIDialogPVRRecordingInfo.cpp
@@ -13,6 +13,7 @@
#include "guilib/GUIMessage.h"
#include "pvr/PVRManager.h"
#include "pvr/guilib/PVRGUIActions.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
using namespace PVR;
@@ -78,7 +79,7 @@ bool CGUIDialogPVRRecordingInfo::OnClickButtonFind(const CGUIMessage& message)
Close();
if (m_recordItem)
- CServiceBroker::GetPVRManager().GUIActions()->FindSimilar(m_recordItem);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().FindSimilar(m_recordItem);
bReturn = true;
}
diff --git a/xbmc/pvr/guilib/PVRGUIActions.h b/xbmc/pvr/guilib/PVRGUIActions.h
index 4ca03503de..0635a68da7 100644
--- a/xbmc/pvr/guilib/PVRGUIActions.h
+++ b/xbmc/pvr/guilib/PVRGUIActions.h
@@ -8,7 +8,6 @@
#pragma once
-#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "pvr/guilib/PVRGUIActionsParentalControl.h"
#include "pvr/guilib/PVRGUIActionsPlayback.h"
#include "pvr/guilib/PVRGUIActionsPowerManagement.h"
@@ -18,8 +17,7 @@
namespace PVR
{
-class CPVRGUIActions : public CPVRGUIActionsEPG,
- public CPVRGUIActionsParentalControl,
+class CPVRGUIActions : public CPVRGUIActionsParentalControl,
public CPVRGUIActionsPlayback,
public CPVRGUIActionsPowerManagement,
public CPVRGUIActionsRecordings,
diff --git a/xbmc/pvr/guilib/PVRGUIActionsEPG.h b/xbmc/pvr/guilib/PVRGUIActionsEPG.h
index ecc5359129..cbc76ccd17 100644
--- a/xbmc/pvr/guilib/PVRGUIActionsEPG.h
+++ b/xbmc/pvr/guilib/PVRGUIActionsEPG.h
@@ -8,13 +8,15 @@
#pragma once
+#include "pvr/IPVRComponent.h"
+
#include <memory>
class CFileItem;
namespace PVR
{
-class CPVRGUIActionsEPG
+class CPVRGUIActionsEPG : public IPVRComponent
{
public:
CPVRGUIActionsEPG() = default;
@@ -75,4 +77,10 @@ private:
CPVRGUIActionsEPG const& operator=(CPVRGUIActionsEPG const&) = delete;
};
+namespace GUI
+{
+// pretty scope and name
+using EPG = CPVRGUIActionsEPG;
+} // namespace GUI
+
} // namespace PVR
diff --git a/xbmc/pvr/guilib/PVRGUIActionsUtils.cpp b/xbmc/pvr/guilib/PVRGUIActionsUtils.cpp
index 3e7b4060c4..0377f889c4 100644
--- a/xbmc/pvr/guilib/PVRGUIActionsUtils.cpp
+++ b/xbmc/pvr/guilib/PVRGUIActionsUtils.cpp
@@ -19,6 +19,7 @@
#include "pvr/epg/EpgInfoTag.h"
#include "pvr/guilib/PVRGUIActions.h" //! @todo decouple
#include "pvr/guilib/PVRGUIActionsChannels.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "settings/Settings.h"
#include <memory>
@@ -74,11 +75,11 @@ bool CPVRGUIActionsUtils::OnInfo(const std::shared_ptr<CFileItem>& item)
}
else if (item->HasPVRChannelInfoTag() || item->HasPVRTimerInfoTag())
{
- return CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(item);
}
else if (item->HasEPGSearchFilter())
{
- return CServiceBroker::GetPVRManager().GUIActions()->EditSavedSearch(item);
+ return CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().EditSavedSearch(item);
}
return false;
}
diff --git a/xbmc/pvr/windows/GUIWindowPVRChannels.cpp b/xbmc/pvr/windows/GUIWindowPVRChannels.cpp
index 123f9383c8..f9514cc4a2 100644
--- a/xbmc/pvr/windows/GUIWindowPVRChannels.cpp
+++ b/xbmc/pvr/windows/GUIWindowPVRChannels.cpp
@@ -34,6 +34,7 @@
#include "pvr/epg/EpgContainer.h"
#include "pvr/guilib/PVRGUIActions.h"
#include "pvr/guilib/PVRGUIActionsChannels.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "utils/StringUtils.h"
#include "utils/Variant.h"
@@ -170,7 +171,8 @@ bool CGUIWindowPVRChannelsBase::OnMessage(CGUIMessage& message)
CServiceBroker::GetPVRManager().GUIActions()->SwitchToChannel(m_vecItems->Get(iItem), true);
break;
case ACTION_SHOW_INFO:
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(m_vecItems->Get(iItem));
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(
+ m_vecItems->Get(iItem));
break;
case ACTION_DELETE_ITEM:
CServiceBroker::GetPVRManager().Get<PVR::GUI::Channels>().HideChannel(
diff --git a/xbmc/pvr/windows/GUIWindowPVRGuide.cpp b/xbmc/pvr/windows/GUIWindowPVRGuide.cpp
index 66d29924b2..17f3caa479 100644
--- a/xbmc/pvr/windows/GUIWindowPVRGuide.cpp
+++ b/xbmc/pvr/windows/GUIWindowPVRGuide.cpp
@@ -36,6 +36,7 @@
#include "pvr/guilib/GUIEPGGridContainer.h"
#include "pvr/guilib/PVRGUIActions.h"
#include "pvr/guilib/PVRGUIActionsChannels.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "pvr/recordings/PVRRecordings.h"
#include "pvr/timers/PVRTimers.h"
#include "settings/Settings.h"
@@ -444,7 +445,7 @@ bool CGUIWindowPVRGuideBase::OnMessage(CGUIMessage& message)
bReturn = true;
break;
case EPG_SELECT_ACTION_INFO:
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(pItem);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(pItem);
bReturn = true;
break;
case EPG_SELECT_ACTION_RECORD:
@@ -502,7 +503,7 @@ bool CGUIWindowPVRGuideBase::OnMessage(CGUIMessage& message)
else if (tag->IsPlayable())
CServiceBroker::GetPVRManager().GUIActions()->PlayEpgTag(pItem);
else
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(pItem);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(pItem);
}
bReturn = true;
}
@@ -511,7 +512,7 @@ bool CGUIWindowPVRGuideBase::OnMessage(CGUIMessage& message)
}
break;
case ACTION_SHOW_INFO:
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(pItem);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(pItem);
bReturn = true;
break;
case ACTION_PLAYER_PLAY:
diff --git a/xbmc/pvr/windows/GUIWindowPVRSearch.cpp b/xbmc/pvr/windows/GUIWindowPVRSearch.cpp
index 51ca8eb48d..0e9f490d5e 100644
--- a/xbmc/pvr/windows/GUIWindowPVRSearch.cpp
+++ b/xbmc/pvr/windows/GUIWindowPVRSearch.cpp
@@ -28,6 +28,7 @@
#include "pvr/epg/EpgSearchFilter.h"
#include "pvr/epg/EpgSearchPath.h"
#include "pvr/guilib/PVRGUIActions.h"
+#include "pvr/guilib/PVRGUIActionsEPG.h"
#include "pvr/recordings/PVRRecording.h"
#include "threads/IRunnable.h"
#include "utils/URIUtils.h"
@@ -262,7 +263,7 @@ bool CGUIWindowPVRSearchBase::OnMessage(CGUIMessage& message)
}
else
{
- CServiceBroker::GetPVRManager().GUIActions()->ShowEPGInfo(pItem);
+ CServiceBroker::GetPVRManager().Get<PVR::GUI::EPG>().ShowEPGInfo(pItem);
}
return true;
}