diff options
author | Rechi <Rechi@users.noreply.github.com> | 2018-04-04 13:40:12 +0200 |
---|---|---|
committer | Rainer Hochecker <fernetmenta@online.de> | 2018-04-05 07:12:13 +0200 |
commit | 6e896c6a085239dda9a364b7b3030c8c4dd507f4 (patch) | |
tree | d9b719a9e24c63bce52dfb053ab23a2805ef3376 | |
parent | c71e293c72b827e0fc26e27ab3ef06d36341f5ae (diff) |
drop more dsp leftovers
33 files changed, 25 insertions, 660 deletions
diff --git a/.gitignore b/.gitignore index 977a809180..bd7eb50bc4 100644 --- a/.gitignore +++ b/.gitignore @@ -110,7 +110,6 @@ cmake_install.cmake /addons/skin.pm3-hd/media/Textures.xbt /addons/audioencoder.* /addons/pvr.* -/addons/adsp.* /addons/peripheral.* /addons/game.* /addons/kodi.binary.global.audioengine/addon.xml @@ -119,7 +118,6 @@ cmake_install.cmake /addons/kodi.binary.global.gui/addon.xml /addons/kodi.binary.global.main/addon.xml /addons/kodi.binary.global.network/addon.xml -/addons/kodi.binary.instance.adsp/addon.xml /addons/kodi.binary.instance.audiodecoder/addon.xml /addons/kodi.binary.instance.audioencoder/addon.xml /addons/kodi.binary.instance.game/addon.xml @@ -344,7 +342,6 @@ cmake_install.cmake /portable_data /pvr-addons -/adsp-addons # Doxygen generated files /docs/html diff --git a/.travis.yml b/.travis.yml index 213f6be6f9..6734e940d5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,7 +21,6 @@ compiler: env: - BUILD=Kodi TOOLS=CMake -# - ADDONS=adsp # - ADDONS=audiodecoder # - ADDONS=audioencoder # - ADDONS=pvr @@ -31,7 +30,6 @@ env: matrix: fast_finish: true allow_failures: -# - env: ADDONS=adsp # - env: ADDONS=audiodecoder # - env: ADDONS=audioencoder # - env: ADDONS=pvr @@ -96,7 +94,7 @@ before_script: - if [[ "$TRAVIS_OS_NAME" == "linux" && "$BUILD" == "Kodi" && "$CXX" == "clang++" ]]; then cmake -DCMAKE_CXX_FLAGS="-Qunused-arguments" ..; fi - - if [[ "$BUILD" != "Kodi" ]] && [[ "$ADDONS" == "adsp" || "$ADDONS" == "audiodecoder" || "$ADDONS" == "audioencoder" || + - if [[ "$BUILD" != "Kodi" ]] && [[ "$ADDONS" == "audiodecoder" || "$ADDONS" == "audioencoder" || "$ADDONS" == "pvr" || "$ADDONS" == "screensaver" || "$ADDONS" == "visualization" ]]; then cd $TRAVIS_BUILD_DIR/cmake/addons && mkdir -p build && @@ -112,7 +110,7 @@ script: make -j4 && make check; fi - - if [[ "$BUILD" != "Kodi" ]] && [[ "$ADDONS" == "adsp" || "$ADDONS" == "audiodecoder" || "$ADDONS" == "audioencoder" || + - if [[ "$BUILD" != "Kodi" ]] && [[ "$ADDONS" == "audiodecoder" || "$ADDONS" == "audioencoder" || "$ADDONS" == "pvr" || "$ADDONS" == "screensaver" || "$ADDONS" == "visualization" ]]; then cd $TRAVIS_BUILD_DIR/ && mkdir -p build && diff --git a/addons/kodi.binary.instance.adsp/addon.xml.in b/addons/kodi.binary.instance.adsp/addon.xml.in deleted file mode 100644 index 8a443ff2cb..0000000000 --- a/addons/kodi.binary.instance.adsp/addon.xml.in +++ /dev/null @@ -1,7 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<addon id="kodi.binary.instance.adsp" version="@ADDON_INSTANCE_VERSION_ADSP@" provider-name="Team Kodi"> - <backwards-compatibility abi="@ADDON_INSTANCE_VERSION_ADSP_MIN@"/> - <requires> - <import addon="xbmc.core" version="0.1.0"/> - </requires> -</addon> diff --git a/addons/resource.language.en_gb/resources/strings.po b/addons/resource.language.en_gb/resources/strings.po index af991c3a4a..46d5e064c6 100644 --- a/addons/resource.language.en_gb/resources/strings.po +++ b/addons/resource.language.en_gb/resources/strings.po @@ -667,7 +667,6 @@ msgctxt "#156" msgid "Free" msgstr "" -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp #: addons/skin.estuary/xml/Includes.xml msgctxt "#157" msgid "Video" @@ -1156,7 +1155,6 @@ msgstr "" #: xbmc/dialogs/GUIDialogMediaSource.cpp #: xbmc/media/MediaTypes.cpp -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp msgctxt "#249" msgid "Music" msgstr "" @@ -2825,7 +2823,6 @@ msgctxt "#612" msgid "Bits/sample" msgstr "" -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp #: addons/skin.estuary/xml/MusicVisualisation.xml msgctxt "#613" msgid "Sample rate" @@ -5168,17 +5165,7 @@ msgctxt "#10153" msgid "Subtitle search" msgstr "" -#: xbmc/guilib/WindowIDs.h -msgctxt "#10154" -msgid "Audio DSP manager" -msgstr "" - -#: xbmc/guilib/WindowIDs.h -msgctxt "#10155" -msgid "OSD audio DSP settings" -msgstr "" - -#empty string with id 10156 +#empty strings from id 10154 to 10156 #: xbmc/guilib/WindowIDs.h msgctxt "#10157" @@ -5776,7 +5763,6 @@ msgstr "" #empty strings from id 12374 to 12375 -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp #: xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp #: xbmc/video/dialogs/GUIDialogVideoSettings.cpp msgctxt "#12376" @@ -7596,11 +7582,7 @@ msgctxt "#14060" msgid "Unknown type cache - Internet" msgstr "" -#. Name of a class/preset for audio DSP -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#14061" -msgid "Auto" -msgstr "" +#empty string with id 14061 msgctxt "#14062" msgid "Enter username for" @@ -7685,11 +7667,7 @@ msgctxt "#14081" msgid "File lists" msgstr "" -#. Label of button in Settings -> Audio output to clear the audio DSP database. -#: system/settings/settings.xml -msgctxt "#14082" -msgid "Reset the Audio DSP database..." -msgstr "" +#empty string with id 14082 #: system/settings/settings.xml msgctxt "#14083" @@ -8151,10 +8129,7 @@ msgctxt "#14250" msgid "Audio Decoder" msgstr "" -#: system/settings/settings.xml -msgctxt "#14251" -msgid "Audio DSP" -msgstr "" +#empty string with id 14251 #: system/settings/settings.xml msgctxt "#14252" @@ -8240,33 +8215,7 @@ msgctxt "#14304" msgid "RDS Radio" msgstr "" -#empty strings from id 14305 to 15003 - -#. Name of a class/preset for audio DSP -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15004" -msgid "Basic" -msgstr "" - -#. Name of a class/preset for audio DSP -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15005" -msgid "Application" -msgstr "" - -#. Name of a class/preset for audio DSP -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15006" -msgid "Phone" -msgstr "" - -#. Name of a class/preset for audio DSP -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15007" -msgid "Message" -msgstr "" - -#empty strings from id 15008 to 15010 +#empty strings from id 14305 to 15010 #: xbmc/music/MusicDatabase.cpp #: xbmc/video/VideoDatabase.cpp @@ -8296,7 +8245,6 @@ msgid "Remove" msgstr "" #: system/settings/settings.xml -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp msgctxt "#15016" msgid "Games" msgstr "" @@ -8307,127 +8255,7 @@ msgctxt "#15019" msgid "Add" msgstr "" -#: addons/skin.estuary/xml/Custom_1106_VideoOSDSettings.xml -#: addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml -msgctxt "#15020" -msgid "Audio DSP manager" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15021" -msgid "Content type" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15022" -msgid "Listening mode" -msgstr "" - -#: xbmc/cores/AudioEngine/DSPAddons/ActiveAEDSPMode.cpp -msgctxt "#15023" -msgid "Master mode" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15024" -msgid "Pre-process setup..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15025" -msgid "Listening mode setup..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15026" -msgid "Speaker / Output setup..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15027" -msgid "Audio information..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15028" -msgid "Audio DSP settings - Main" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15029" -msgid "Audio DSP settings - Listening mode" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15030" -msgid "Audio DSP settings - Speaker / Output" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15031" -msgid "Audio DSP settings - Audio information" -msgstr "" - -#empty string with id 15032 - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15033" -msgid "Resampler setup..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15034" -msgid "Miscellaneous..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15035" -msgid "Audio DSP settings - Resampler" -msgstr "" - -#empty string with id 15036 - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15037" -msgid "Audio DSP settings - Pre-process" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15038" -msgid "Audio DSP settings - Miscellaneous" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15039" -msgid "Pre-processing setup..." -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15040" -msgid "The settings dialogue can only be opened from the OSD menu during playback" -msgstr "" - -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15041" -msgid "Unknown mode name" -msgstr "" - -#: addons/skin.estuary/xml/DialogAudioDSPSettings.xml -msgctxt "#15042" -msgid "Content:" -msgstr "" - -#empty strings from id 15043 to 15046 - -#. Label for a context menu entry and dialog button to open audio DSP settings dialog -#: xbmc/pvr/PVRContextMenus.cpp -#: xbmc/music/windows/GUIWindowMusicBase.cpp -#: addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml -msgctxt "#15047" -msgid "Audio DSP settings" -msgstr "" - -#empty strings from id 15048 to 15049 +#empty strings from id 15020 to 15049 #. Name of a list with amount of entries behind on GUI msgctxt "#15050" @@ -8444,166 +8272,18 @@ msgctxt "#15052" msgid "Password" msgstr "" -#empty strings from id 15053 to 15056 - -#. Chain select button name -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15057" -msgid "Input resampling" -msgstr "" - -#. Chain select button name -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15058" -msgid "Pre-processing" -msgstr "" - -#. Chain select button name -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15059" -msgid "Master processing" -msgstr "" - -#. Chain select button name -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15060" -msgid "Post-processing" -msgstr "" - -#. Chain select button name -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15061" -msgid "Output resampling" -msgstr "" - -#. Header on detailed add-on dsp mode description -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15062" -msgid "Detailed description" -msgstr "" - -#. Fallback string if nothing from addon is present -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15063" -msgid "No description available" -msgstr "" - -#. DSP manager boolean enable/disable value text -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15064" -msgid "Apply changes directly" -msgstr "" - -#. Warning if no dsp modes are present -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15065" -msgid "No audio DSP modes available" -msgstr "" +#empty strings from id 15053 to 15065 #. Button to disable all enabled modes on current selected type msgctxt "#15066" msgid "Clear active modes" msgstr "" -#. Close the DSP manager window msgctxt "#15067" msgid "Close" msgstr "" -#empty strings from id 15068 to 15077 - -#. DSP manager dialog context menu entry -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15078" -msgid "Mode settings" -msgstr "" - -#. DSP manager yes/no dialog text -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15079" -msgid "You have changed some audio DSP settings.\nWould you like to keep the new settings?" -msgstr "" - -#. DSP manager dialog context menu entry -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp -msgctxt "#15080" -msgid "Change resampler" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15081" -msgid "Process chain (with CPU usage)" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15082" -msgid "Resampling to {0:d} Hz" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15083" -msgid "Final resampling to {0:d} Hz" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15084" -msgid "Master process" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15085" -msgid "Pre-process" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15086" -msgid "Post-process" -msgstr "" - -#. Audio DSP process chain indication - this is in the context of input signal -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -#: system/settings/settings.xml -msgctxt "#15087" -msgid "Input" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15088" -msgid "Output" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15089" -msgid "Input signal" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15090" -msgid "Output signal" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15091" -msgid "Positions" -msgstr "" - -#. Audio DSP process chain indication -#: xbmc/settings/dialogs/GUIDialogAudioDSPSettings.cpp -msgctxt "#15092" -msgid "CPU usage for DSP" -msgstr "" - -#empty strings from id 15093 to 15099 +#empty strings from id 15068 to 15099 msgctxt "#15100" msgid "Library" @@ -8671,32 +8351,7 @@ msgctxt "#15112" msgid "Default theme" msgstr "" -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15113" -msgid "Here you can configure pre-processing modes. This processing stage only change the input data stream." -msgstr "" - -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15114" -msgid "Here you can configure an input resampling process. Notice: Only one active mode is allowed!" -msgstr "" - -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15115" -msgid "Here you can configure master processing modes. Notice: On playback only one active mode can be selected!" -msgstr "" - -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15116" -msgid "Here you can configure a output resampling process. Notice: Only one active mode is allowed!" -msgstr "" - -#: addons/skin.estuary/xml/DialogAudioDSPManager.xml -msgctxt "#15117" -msgid "Here you can configure post-processing modes. This processing stage can be used for equalizing and volume correction..." -msgstr "" - -#empty strings from id 15118 to 15199 +#empty strings from id 15113 to 15199 msgctxt "#15200" msgid "Last.fm" @@ -9916,10 +9571,8 @@ msgstr "" #. generic warning label used at several places #: xbmc/addons/AddonSystemSettings.cpp -#: xbmc/cores/AudioEngine/DSPAddons/ActiveAEDSP.cpp #: xbmc/pvr/channels/PVRChannelGroupInternal.cpp #: xbmc/pvr/PVRManager.cpp -#: xbmc/settings/dialogs/GUIDialogAudioDSPManager.cpp msgctxt "#19098" msgid "Warning!" msgstr "" @@ -15253,11 +14906,7 @@ msgctxt "#24087" msgid "All repositories" msgstr "" -#. Description on error dialog why not possible -#: xbmc/addons/GUIDialogAddonInfo.h -msgctxt "#24088" -msgid "The DSP add-on is currently in use and can't be modified." -msgstr "" +#empty string with id 24088 msgctxt "#24089" msgid "Add-on restarts" @@ -15498,27 +15147,7 @@ msgctxt "#24134" msgid "Download subtitle..." msgstr "" -#. Folder name in addon settings window -#: xbmc/addons/addon.cpp -msgctxt "#24135" -msgid "Audio DSP" -msgstr "" - -#. To open dsp submenu -#: xbmc/video/dialogs/GUIDialogAudioSubtitleSettings.cpp -msgctxt "#24136" -msgid "Audio DSP..." -msgstr "" - -#: xbmc/cores/AudioEngine/DSPAddons/ActiveAEDSP.cpp -msgctxt "#24137" -msgid "Not allowed" -msgstr "" - -#: xbmc/cores/AudioEngine/DSPAddons/ActiveAEDSP.cpp -msgctxt "#24138" -msgid "DSP add-on is currently in use and can't be removed." -msgstr "" +#empty strings from id 24135 to 24138 #. Label for the action provided by addon management events to jump to a specific Add-on #: xbmc/events/AddonManagementEvent.cpp @@ -19802,41 +19431,7 @@ msgctxt "#36435" msgid "Use VideoPlayer for decoding of video files with MMAL acceleration." msgstr "" -#. Button on settings to opend DSP manager dialog -#: system/settings/settings.xml -msgctxt "#36436" -msgid "Audio DSP manager..." -msgstr "" - -#. Description of setting with label 36436 "Audio DSP manager..." -#: system/settings/settings.xml -msgctxt "#36437" -msgid "Allows to configure available modes for different stages in audio processing and to arrange the steps within the processing chain of each selected mode." -msgstr "" - -#. Description of setting with label 36441 "Enable Audio DSP processing" -#: system/settings/settings.xml -msgctxt "#36438" -msgid "Enables digital signal processing (DSP) of audio channels specified by the speaker configuration." -msgstr "" - -#. Description of setting with label 14082 "Reset the Audio DSP database..." -#: system/settings/settings.xml -msgctxt "#36439" -msgid "All data (add-on settings and audio DSP manager settings) in the audio DSP database will be erased." -msgstr "" - -#. Used in confirm on dialog to erase database -#: xbmc/cores/AudioEngine/DSPAddons/ActiveAEDSP.cpp -msgctxt "#36440" -msgid "Erasing all DSP add-on and audio DSP manager settings in the audio DSP database." -msgstr "" - -#. Settings boolean value name -#: system/settings/settings.xml -msgctxt "#36441" -msgid "Enable audio DSP processing" -msgstr "" +#empty strings from id 36436 to 36441 #. Description of setting "System -> Audio output -> Volume control steps" with label #1302 #: system/settings/settings.xml diff --git a/addons/skin.estuary/xml/Custom_1101_SettingsList.xml b/addons/skin.estuary/xml/Custom_1101_SettingsList.xml index eb2fef4b62..e28c467bb2 100644 --- a/addons/skin.estuary/xml/Custom_1101_SettingsList.xml +++ b/addons/skin.estuary/xml/Custom_1101_SettingsList.xml @@ -52,13 +52,6 @@ <onclick>ActivateWindow(osdcmssettings)</onclick> <visible>System.HasCMS</visible> </control> - <control type="button" id="11103"> - <width>700</width> - <include>DialogSettingButton</include> - <label>$LOCALIZE[15020]</label> - <onclick>ActivateWindow(AudioDSPManager)</onclick> - <visible>ADSP.HasModes</visible> - </control> <control type="button" id="11104"> <width>700</width> <include>DialogSettingButton</include> diff --git a/addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml b/addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml index f12b882104..443afdefa1 100644 --- a/addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml +++ b/addons/skin.estuary/xml/Custom_1105_MusicOSDSettings.xml @@ -31,13 +31,6 @@ <onclick>Skin.ToggleSetting(hide_background_fanart)</onclick> <selected>!Skin.HasSetting(hide_background_fanart)</selected> </control> - <control type="button" id="5003"> - <width>600</width> - <include>DialogSettingButton</include> - <label>$LOCALIZE[15020]</label> - <onclick>ActivateWindow(AudioDSPManager)</onclick> - <visible>system.getbool(audiooutput.dspaddonsenabled)</visible> - </control> <control type="button" id="5004"> <width>600</width> <include>DialogSettingButton</include> diff --git a/addons/skin.estuary/xml/Includes.xml b/addons/skin.estuary/xml/Includes.xml index bb67929e7b..a8fb1562d8 100644 --- a/addons/skin.estuary/xml/Includes.xml +++ b/addons/skin.estuary/xml/Includes.xml @@ -174,114 +174,6 @@ </control> </definition> </include> - <include name="AudioDSPModeList"> - <control type="label"> - <left>10</left> - <top>2</top> - <width>470</width> - <height>30</height> - <font>font25_title</font> - <label>$PARAM[sublabel]</label> - <align>center</align> - <aligny>center</aligny> - <textcolor>button_focus</textcolor> - <shadowcolor>black</shadowcolor> - </control> - <control type="image"> - <left>-5</left> - <top>15</top> - <width>510</width> - <height>570</height> - <texture border="40">buttons/dialogbutton-nofo.png</texture> - </control> - <control type="scrollbar" id="$PARAM[scrollbar_id]"> - <left>542</left> - <top>30</top> - <width>25</width> - <height>350</height> - <onleft>$PARAM[list_id]</onleft> - <onright>$PARAM[onright]</onright> - <orientation>vertical</orientation> - </control> - <control type="list" id="$PARAM[list_id]"> - <left>15</left> - <top>35</top> - <width>470</width> - <height>345</height> - <onup>9000</onup> - <ondown>9001</ondown> - <onleft>$PARAM[onleft]</onleft> - <onright>$PARAM[scrollbar_id]</onright> - <pagecontrol>$PARAM[scrollbar_id]</pagecontrol> - <scrolltime>200</scrolltime> - <itemlayout height="80" width="470"> - <control type="image"> - <left>8</left> - <top>8</top> - <width>64</width> - <height>64</height> - <texture>$INFO[ListItem.Icon]</texture> - <aspectratio aligny="center" align="left">keep</aspectratio> - </control> - <control type="label"> - <left>82</left> - <top>3</top> - <right>20</right> - <height>40</height> - <font>font12</font> - <aligny>center</aligny> - <label>$INFO[ListItem.Label]</label> - </control> - <control type="label"> - <left>82</left> - <top>37</top> - <right>20</right> - <height>30</height> - <font>font12</font> - <aligny>center</aligny> - <textcolor>grey</textcolor> - <label>$INFO[ListItem.Label2]</label> - </control> - </itemlayout> - <focusedlayout height="80" width="470"> - <control type="image"> - <left>0</left> - <top>0</top> - <right>0</right> - <bottom>0</bottom> - <texture colordiffuse="button_focus">lists/focus.png</texture> - <visible>Control.HasFocus($PARAM[list_id])</visible> - </control> - <control type="image"> - <left>8</left> - <top>8</top> - <width>64</width> - <height>64</height> - <texture>$INFO[ListItem.Icon]</texture> - <aspectratio aligny="center" align="left">keep</aspectratio> - </control> - <control type="label"> - <left>82</left> - <top>3</top> - <right>20</right> - <height>40</height> - <font>font12</font> - <aligny>center</aligny> - <label>$INFO[ListItem.Label]</label> - </control> - <control type="label"> - <left>82</left> - <top>37</top> - <right>20</right> - <height>30</height> - <font>font12</font> - <aligny>center</aligny> - <textcolor>grey</textcolor> - <label>$INFO[ListItem.Label2]</label> - </control> - </focusedlayout> - </control> - </include> <include name="PicsInfoLine"> <control type="grouplist"> <visible>!String.IsEmpty($PARAM[value])</visible> diff --git a/addons/skin.estuary/xml/Variables.xml b/addons/skin.estuary/xml/Variables.xml index 7960bed892..fd4bb7f4ba 100644 --- a/addons/skin.estuary/xml/Variables.xml +++ b/addons/skin.estuary/xml/Variables.xml @@ -231,11 +231,6 @@ <value condition="Container(9000).HasFocus(1)">$LOCALIZE[31129]</value> <value condition="Container(9000).HasFocus(2)">$LOCALIZE[31130]</value> </variable> - <variable name="DSPManagerHelpTextVar"> - <value condition="Control.HasFocus(20)">$INFO[Container(20).ListItem.Property(Description)]</value> - <value condition="Control.HasFocus(21)">$INFO[Container(21).ListItem.Property(Description)]</value> - <value>$INFO[Container(9000).ListItem.Label2]</value> - </variable> <variable name="VolumeIconVar"> <value condition="Player.Muted">dialogs/volume/mute.png</value> <value condition="Integer.IsGreater(Player.Volume,66)">dialogs/volume/volume.png</value> diff --git a/appveyor.yml b/appveyor.yml index 87a0e55b43..f61aad004c 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,7 +6,6 @@ environment: CONFIG: Release matrix: - BUILD: Kodi - # - ADDONS: adsp # - ADDONS: audiodecoder # - ADDONS: audioencoder # - ADDONS: pvr diff --git a/cmake/installdata/common/addons.txt b/cmake/installdata/common/addons.txt index 9efba38b47..b8f763c7f3 100644 --- a/cmake/installdata/common/addons.txt +++ b/cmake/installdata/common/addons.txt @@ -1,7 +1,6 @@ addons/audioencoder.kodi.builtin.aac/* addons/audioencoder.kodi.builtin.wma/* addons/game.controller.default/* -addons/kodi.adsp/* addons/kodi.audiodecoder/* addons/kodi.game/* addons/kodi.imagedecoder/* diff --git a/docs/README.FreeBSD b/docs/README.FreeBSD index 58d72ecb9e..1314730a55 100644 --- a/docs/README.FreeBSD +++ b/docs/README.FreeBSD @@ -123,9 +123,6 @@ You can compile all addons or only specific addons by specifying e.g. ADDONS="au .1 Specific addons $ gmake -C tools/depends/target/binary-addons PREFIX=/<system prefix added on step 4.1> ADDONS="audioencoder.flac pvr.vdr.vnsi audiodecoder.snesapu" -ADSP addons: - adsp.basic, adsp.biquad.filters, adsp.freesurround - Audio decoders: audiodecoder.modplug, audiodecoder.nosefart, audiodecoder.sidplay, audiodecoder.snesapu, audiodecoder.stsound, audiodecoder.timidity, audiodecoder.vgmstream diff --git a/docs/README.ios.md b/docs/README.ios.md index 2d593b5c7a..28a6c9f616 100644 --- a/docs/README.ios.md +++ b/docs/README.ios.md @@ -101,7 +101,7 @@ above. The example below would use the iOS SDK 9.0: ### 3.3 Compile Kodi binary addons -Kodi maintains a set of binary addons (PVR clients, Visualizations, Audio DSP +Kodi maintains a set of binary addons (PVR clients, Visualizations plugins and more). They can be built as shown below: cd $HOME/Kodi diff --git a/docs/README.linux b/docs/README.linux index 0c3c411222..5826dfbaa4 100644 --- a/docs/README.linux +++ b/docs/README.linux @@ -168,9 +168,6 @@ You can compile all addons or only specific addons by specifying e.g. ADDONS="au .1 Specific addons $ make -C tools/depends/target/binary-addons PREFIX=/<system prefix added on step 4.1> ADDONS="audioencoder.flac pvr.vdr.vnsi audiodecoder.snesapu" -ADSP addons: - adsp.basic, adsp.biquad.filters, adsp.freesurround - Audio decoders: audiodecoder.modplug, audiodecoder.nosefart, audiodecoder.sidplay, audiodecoder.snesapu, audiodecoder.stsound, audiodecoder.timidity, audiodecoder.vgmstream diff --git a/docs/README.opensuse b/docs/README.opensuse index da7a554709..ba69543943 100644 --- a/docs/README.opensuse +++ b/docs/README.opensuse @@ -187,9 +187,6 @@ You can compile all addons or only specific addons by specifying e.g. ADDONS="au .1 Specific addons $ make -C tools/depends/target/binary-addons PREFIX=/<system prefix added on step 4.1> ADDONS="audioencoder.flac pvr.vdr.vnsi audiodecoder.snesapu" -ADSP addons: - adsp.basic, adsp.biquad.filters, adsp.freesurround - Audio decoders: audiodecoder.modplug, audiodecoder.nosefart, audiodecoder.sidplay, audiodecoder.snesapu, audiodecoder.stsound, audiodecoder.timidity, audiodecoder.vgmstream diff --git a/docs/README.osx.md b/docs/README.osx.md index 954faa0d47..872b80f3ce 100644 --- a/docs/README.osx.md +++ b/docs/README.osx.md @@ -96,7 +96,7 @@ above. The example below would use the macOS SDK 10.9: ### 3.3 Compile Kodi binary addons -Kodi maintains a set of binary addons (PVR clients, Visualizations, Audio DSP +Kodi maintains a set of binary addons (PVR clients, Visualizations plugins and more). They can be built as shown below: cd $HOME/Kodi diff --git a/project/Win32BuildSetup/genNsisIncludes.bat b/project/Win32BuildSetup/genNsisIncludes.bat index 8d06e0b48a..498d2a6864 100644 --- a/project/Win32BuildSetup/genNsisIncludes.bat +++ b/project/Win32BuildSetup/genNsisIncludes.bat @@ -76,22 +76,6 @@ IF EXIST BUILD_WIN32\addons\audioencoder.* ( ) SET Counter=1 -IF EXIST BUILD_WIN32\addons\adsp.* ( - ECHO SectionGroup "Audio DSP Add-ons" SecAudioDSPAddons >> audiodsp-addons.nsi - FOR /F "tokens=*" %%P IN ('dir /B /AD BUILD_WIN32\addons\adsp.*') DO ( - FOR /f "delims=<" %%N in ('powershell.exe -noprofile -ExecutionPolicy Unrestricted -command "& {[xml]$a = get-content BUILD_WIN32\addons\%%P\addon.xml;$a.addon.name}"') do ( - ECHO Section "%%N" SecAudioDSPAddons!Counter! >> audiodsp-addons.nsi - ECHO SectionIn 1 2 >> audiodsp-addons.nsi - ECHO SetOutPath "$INSTDIR\addons\%%P" >> audiodsp-addons.nsi - ECHO File /r "${app_root}\addons\%%P\*.*" >> audiodsp-addons.nsi - ECHO SectionEnd >> audiodsp-addons.nsi - SET /A Counter = !Counter! + 1 - ) - ) - ECHO SectionGroupEnd >> audiodsp-addons.nsi -) - -SET Counter=1 IF EXIST BUILD_WIN32\addons\screensaver.* ( ECHO SectionGroup "Screensaver Add-ons" SecScreensaverAddons >> screensaver-addons.nsi FOR /F "tokens=*" %%P IN ('dir /B /AD BUILD_WIN32\addons\screensaver.*') DO ( diff --git a/project/Win32BuildSetup/genNsisInstaller.nsi b/project/Win32BuildSetup/genNsisInstaller.nsi index f0a96d4bca..ef200bb817 100644 --- a/project/Win32BuildSetup/genNsisInstaller.nsi +++ b/project/Win32BuildSetup/genNsisInstaller.nsi @@ -234,7 +234,6 @@ SectionEnd ;*-addons.nsi are generated by genNsisIncludes.bat !include /nonfatal "audiodecoder-addons.nsi" !include /nonfatal "audioencoder-addons.nsi" -!include /nonfatal "audiodsp-addons.nsi" !include /nonfatal "game-addons.nsi" !include /nonfatal "imagedecoder-addons.nsi" !include /nonfatal "inputstream-addons.nsi" diff --git a/system/addon-manifest.xml b/system/addon-manifest.xml index b196532d32..b9f88e4e65 100644 --- a/system/addon-manifest.xml +++ b/system/addon-manifest.xml @@ -12,7 +12,6 @@ <addon>kodi.binary.global.network</addon> <addon>kodi.binary.global.gui</addon> <addon>kodi.binary.global.filesystem</addon> - <addon>kodi.binary.instance.adsp</addon> <addon>kodi.binary.instance.audiodecoder</addon> <addon>kodi.binary.instance.audioencoder</addon> <addon>kodi.binary.instance.game</addon> diff --git a/system/settings/settings.xml b/system/settings/settings.xml index 989c904ebc..72ba565eba 100755 --- a/system/settings/settings.xml +++ b/system/settings/settings.xml @@ -2400,11 +2400,6 @@ </dependencies> <control type="toggle" /> </setting> - <setting id="audiooutput.dspaddonsenabled" type="boolean"> - <visible>false</visible> - <default>false</default> - <control type="toggle"/> - </setting> <setting id="audiooutput.processquality" type="integer" label="13505" help="36169"> <requirement>HAS_AE_QUALITY_LEVELS</requirement> <level>2</level> diff --git a/xbmc/ServiceBroker.h b/xbmc/ServiceBroker.h index 4a5bb57a52..20483df5f7 100644 --- a/xbmc/ServiceBroker.h +++ b/xbmc/ServiceBroker.h @@ -29,10 +29,6 @@ class CServiceAddonManager; class CRepositoryUpdater; } -namespace ActiveAE { -class CActiveAEDSP; -} - namespace ANNOUNCEMENT { class CAnnouncementManager; diff --git a/xbmc/addons/kodi-addon-dev-kit/doxygen/Modules/modules_cpp.dox b/xbmc/addons/kodi-addon-dev-kit/doxygen/Modules/modules_cpp.dox index fcb21c0f7b..d1c71abf49 100644 --- a/xbmc/addons/kodi-addon-dev-kit/doxygen/Modules/modules_cpp.dox +++ b/xbmc/addons/kodi-addon-dev-kit/doxygen/Modules/modules_cpp.dox @@ -31,10 +31,6 @@ \ingroup cpp_kodi_addon */ /*! - \defgroup cpp_kodi_addon_audiodsp Audio DSP - \ingroup cpp_kodi_addon_instances - */ - /*! \defgroup cpp_kodi_addon_audiodecoder Audio Decoder \ingroup cpp_kodi_addon_instances */ diff --git a/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp b/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp index b65f68dda0..e1059cc6ec 100644 --- a/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp +++ b/xbmc/cores/AudioEngine/Engines/ActiveAE/ActiveAE.cpp @@ -702,8 +702,8 @@ void CActiveAE::StateMachine(int signal, Protocol *port, Message *msg) sound = *(CActiveAESound**)msg->data; if (sound) { - if ((m_settings.guisoundmode == AE_SOUND_OFF || - (m_settings.guisoundmode == AE_SOUND_IDLE && !m_streams.empty()))) + if (m_settings.guisoundmode == AE_SOUND_OFF || + (m_settings.guisoundmode == AE_SOUND_IDLE && !m_streams.empty())) return; SoundState st = {sound, 0}; @@ -1276,12 +1276,9 @@ void CActiveAE::Configure(AEAudioFormat *desiredFmt) } m_internalFormat = outputFormat; - bool isRaw; std::list<CActiveAEStream*>::iterator it; for(it=m_streams.begin(); it!=m_streams.end(); ++it) { - isRaw = ((*it)->m_format.m_dataFormat == AE_FMT_RAW); - if (!(*it)->m_inputBuffers) { // align input buffers with period of sink or encoder @@ -2769,25 +2766,6 @@ bool CActiveAE::IsSettingVisible(const std::string &settingId) (CServiceBroker::GetSettings().GetInt(CSettings::SETTING_AUDIOOUTPUT_CHANNELS) <= AE_CH_LAYOUT_2_0 || m_sink.GetDeviceType(CServiceBroker::GetSettings().GetString(CSettings::SETTING_AUDIOOUTPUT_AUDIODEVICE)) == AE_DEVTYPE_IEC958)) return true; } - else if (settingId == CSettings::SETTING_AUDIOOUTPUT_DSPADDONSENABLED) - { - if (m_sink.GetDeviceType(CServiceBroker::GetSettings().GetString(CSettings::SETTING_AUDIOOUTPUT_AUDIODEVICE)) != AE_DEVTYPE_IEC958) - { - return true; - } - } - else if (settingId == CSettings::SETTING_AUDIOOUTPUT_DSPSETTINGS) - { - if (CServiceBroker::GetSettings().GetBool(CSettings::SETTING_AUDIOOUTPUT_DSPADDONSENABLED) && - m_sink.GetDeviceType(CServiceBroker::GetSettings().GetString(CSettings::SETTING_AUDIOOUTPUT_AUDIODEVICE)) != AE_DEVTYPE_IEC958) - return true; - } - else if (settingId == CSettings::SETTING_AUDIOOUTPUT_DSPRESETDB) - { - if (CServiceBroker::GetSettings().GetBool(CSettings::SETTING_AUDIOOUTPUT_DSPADDONSENABLED) && - m_sink.GetDeviceType(CServiceBroker::GetSettings().GetString(CSettings::SETTING_AUDIOOUTPUT_AUDIODEVICE)) != AE_DEVTYPE_IEC958) - return true; - } return false; } diff --git a/xbmc/filesystem/AddonsDirectory.cpp b/xbmc/filesystem/AddonsDirectory.cpp index c16ca841e7..4ca63c7be8 100644 --- a/xbmc/filesystem/AddonsDirectory.cpp +++ b/xbmc/filesystem/AddonsDirectory.cpp @@ -696,7 +696,7 @@ bool CAddonsDirectory::GetDirectory(const CURL& url, CFileItemList &items) DependencyAddons(path, items); return true; } - // PVR & adsp hardcodes this view so keep for compatibility + // PVR hardcodes this view so keep for compatibility else if (endpoint == "disabled") { VECADDONS addons; diff --git a/xbmc/guilib/WindowIDs.h b/xbmc/guilib/WindowIDs.h index 277e48f651..14e25dd0b6 100644 --- a/xbmc/guilib/WindowIDs.h +++ b/xbmc/guilib/WindowIDs.h @@ -101,8 +101,6 @@ #define WINDOW_DIALOG_EXT_PROGRESS 10151 #define WINDOW_DIALOG_MEDIA_FILTER 10152 #define WINDOW_DIALOG_SUBTITLES 10153 -#define WINDOW_DIALOG_AUDIO_DSP_MANAGER 10154 -#define WINDOW_DIALOG_AUDIO_DSP_OSD_SETTINGS 10155 #define WINDOW_DIALOG_KEYBOARD_TOUCH 10156 #define WINDOW_DIALOG_CMS_OSD_SETTINGS 10157 #define WINDOW_DIALOG_INFOPROVIDER_SETTINGS 10158 diff --git a/xbmc/input/WindowTranslator.cpp b/xbmc/input/WindowTranslator.cpp index d4317544c4..623627f3fe 100644 --- a/xbmc/input/WindowTranslator.cpp +++ b/xbmc/input/WindowTranslator.cpp @@ -102,7 +102,6 @@ const CWindowTranslator::WindowMapByName CWindowTranslator::WindowMappingByName { "osdvideosettings" , WINDOW_DIALOG_VIDEO_OSD_SETTINGS }, { "osdaudiosettings" , WINDOW_DIALOG_AUDIO_OSD_SETTINGS }, { "osdsubtitlesettings" , WINDOW_DIALOG_SUBTITLE_OSD_SETTINGS }, - { "audiodspmanager" , WINDOW_DIALOG_AUDIO_DSP_MANAGER }, { "videobookmarks" , WINDOW_DIALOG_VIDEO_BOOKMARKS }, { "filebrowser" , WINDOW_DIALOG_FILE_BROWSER }, { "networksetup" , WINDOW_DIALOG_NETWORK_SETUP }, diff --git a/xbmc/music/dialogs/GUIDialogMusicOSD.cpp b/xbmc/music/dialogs/GUIDialogMusicOSD.cpp index 0ec3eecf60..4e61685247 100644 --- a/xbmc/music/dialogs/GUIDialogMusicOSD.cpp +++ b/xbmc/music/dialogs/GUIDialogMusicOSD.cpp @@ -90,7 +90,6 @@ void CGUIDialogMusicOSD::FrameMove() if (CServiceBroker::GetInputManager().IsMouseActive() || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_VIS_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_VIS_PRESET_LIST) || - CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_AUDIO_DSP_OSD_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_PVR_RADIO_RDS_INFO)) // extend show time by original value SetAutoClose(m_showDuration); diff --git a/xbmc/settings/AdvancedSettings.cpp b/xbmc/settings/AdvancedSettings.cpp index b4c5b18ca3..43d25c8616 100644 --- a/xbmc/settings/AdvancedSettings.cpp +++ b/xbmc/settings/AdvancedSettings.cpp @@ -454,7 +454,7 @@ void CAdvancedSettings::ParseSettingsFile(const std::string &file) //Make a copy of the AS.xml and hide advancedsettings passwords CXBMCTinyXML advancedXMLCopy(advancedXML); TiXmlNode *pRootElementCopy = advancedXMLCopy.RootElement(); - for (const auto& dbname : { "videodatabase", "musicdatabase", "tvdatabase", "adspdatabase", "epgdatabase" }) + for (const auto& dbname : { "videodatabase", "musicdatabase", "tvdatabase", "epgdatabase" }) { TiXmlNode *db = pRootElementCopy->FirstChild(dbname); if (db) diff --git a/xbmc/settings/AdvancedSettings.h b/xbmc/settings/AdvancedSettings.h index 5c77c9feff..b6a350f1c7 100644 --- a/xbmc/settings/AdvancedSettings.h +++ b/xbmc/settings/AdvancedSettings.h @@ -336,7 +336,6 @@ class CAdvancedSettings : public ISettingCallback, public ISettingsHandler DatabaseSettings m_databaseVideo; // advanced video database setup DatabaseSettings m_databaseTV; // advanced tv database setup DatabaseSettings m_databaseEpg; /*!< advanced EPG database setup */ - DatabaseSettings m_databaseADSP; /*!< advanced audio dsp database setup */ DatabaseSettings m_databaseSavestates; /*!< advanced savestate database setup */ bool m_guiVisualizeDirtyRegions; diff --git a/xbmc/settings/Settings.cpp b/xbmc/settings/Settings.cpp index 9dd6355945..caf33f90d1 100644 --- a/xbmc/settings/Settings.cpp +++ b/xbmc/settings/Settings.cpp @@ -364,9 +364,6 @@ const std::string CSettings::SETTING_AUDIOOUTPUT_PROCESSQUALITY = "audiooutput.p const std::string CSettings::SETTING_AUDIOOUTPUT_ATEMPOTHRESHOLD = "audiooutput.atempothreshold"; const std::string CSettings::SETTING_AUDIOOUTPUT_STREAMSILENCE = "audiooutput.streamsilence"; const std::string CSettings::SETTING_AUDIOOUTPUT_STREAMNOISE = "audiooutput.streamnoise"; -const std::string CSettings::SETTING_AUDIOOUTPUT_DSPADDONSENABLED = "audiooutput.dspaddonsenabled"; -const std::string CSettings::SETTING_AUDIOOUTPUT_DSPSETTINGS = "audiooutput.dspsettings"; -const std::string CSettings::SETTING_AUDIOOUTPUT_DSPRESETDB = "audiooutput.dspresetdb"; const std::string CSettings::SETTING_AUDIOOUTPUT_GUISOUNDMODE = "audiooutput.guisoundmode"; const std::string CSettings::SETTING_AUDIOOUTPUT_PASSTHROUGH = "audiooutput.passthrough"; const std::string CSettings::SETTING_AUDIOOUTPUT_PASSTHROUGHDEVICE = "audiooutput.passthroughdevice"; diff --git a/xbmc/settings/Settings.h b/xbmc/settings/Settings.h index a81e4a3d65..3cb8d0794d 100644 --- a/xbmc/settings/Settings.h +++ b/xbmc/settings/Settings.h @@ -318,9 +318,6 @@ public: static const std::string SETTING_AUDIOOUTPUT_ATEMPOTHRESHOLD; static const std::string SETTING_AUDIOOUTPUT_STREAMSILENCE; static const std::string SETTING_AUDIOOUTPUT_STREAMNOISE; - static const std::string SETTING_AUDIOOUTPUT_DSPADDONSENABLED; - static const std::string SETTING_AUDIOOUTPUT_DSPSETTINGS; - static const std::string SETTING_AUDIOOUTPUT_DSPRESETDB; static const std::string SETTING_AUDIOOUTPUT_GUISOUNDMODE; static const std::string SETTING_AUDIOOUTPUT_PASSTHROUGH; static const std::string SETTING_AUDIOOUTPUT_PASSTHROUGHDEVICE; diff --git a/xbmc/video/dialogs/GUIDialogAudioSettings.cpp b/xbmc/video/dialogs/GUIDialogAudioSettings.cpp index b484aaf3ab..9cb9ac4750 100644 --- a/xbmc/video/dialogs/GUIDialogAudioSettings.cpp +++ b/xbmc/video/dialogs/GUIDialogAudioSettings.cpp @@ -56,13 +56,11 @@ #define SETTING_AUDIO_DELAY "audio.delay" #define SETTING_AUDIO_STREAM "audio.stream" #define SETTING_AUDIO_PASSTHROUGH "audio.digitalanalog" -#define SETTING_AUDIO_DSP "audio.dsp" #define SETTING_AUDIO_MAKE_DEFAULT "audio.makedefault" CGUIDialogAudioSettings::CGUIDialogAudioSettings() : CGUIDialogSettingsManualBase(WINDOW_DIALOG_AUDIO_OSD_SETTINGS, "DialogSettings.xml"), - m_passthrough(false), - m_dspEnabled(false) + m_passthrough(false) { } CGUIDialogAudioSettings::~CGUIDialogAudioSettings() = default; @@ -154,11 +152,7 @@ void CGUIDialogAudioSettings::OnSettingAction(std::shared_ptr<const CSetting> se CGUIDialogSettingsManualBase::OnSettingAction(setting); const std::string &settingId = setting->GetId(); - if (settingId == SETTING_AUDIO_DSP) - { - CServiceBroker::GetGUI()->GetWindowManager().ActivateWindow(WINDOW_DIALOG_AUDIO_DSP_OSD_SETTINGS); - } - else if (settingId == SETTING_AUDIO_MAKE_DEFAULT) + if (settingId == SETTING_AUDIO_MAKE_DEFAULT) Save(); } @@ -247,8 +241,6 @@ void CGUIDialogAudioSettings::InitializeSettings() SettingDependencies depsAudioOutputPassthroughDisabled; depsAudioOutputPassthroughDisabled.push_back(dependencyAudioOutputPassthroughDisabled); - m_dspEnabled = CServiceBroker::GetSettings().GetBool(CSettings::SETTING_AUDIOOUTPUT_DSPADDONSENABLED); - // audio settings // audio volume setting m_volume = g_application.GetVolume(false); @@ -256,18 +248,15 @@ void CGUIDialogAudioSettings::InitializeSettings() settingAudioVolume->SetDependencies(depsAudioOutputPassthroughDisabled); std::static_pointer_cast<CSettingControlSlider>(settingAudioVolume->GetControl())->SetFormatter(SettingFormatterPercentAsDecibel); - if (m_dspEnabled) - AddButton(groupAudio, SETTING_AUDIO_DSP, 24136, SettingLevel::Basic); - // audio volume amplification setting - if (SupportsAudioFeature(IPC_AUD_AMP) && !m_dspEnabled) + if (SupportsAudioFeature(IPC_AUD_AMP)) { std::shared_ptr<CSettingNumber> settingAudioVolumeAmplification = AddSlider(groupAudio, SETTING_AUDIO_VOLUME_AMPLIFICATION, 660, SettingLevel::Basic, videoSettings.m_VolumeAmplification, 14054, VOLUME_DRC_MINIMUM * 0.01f, (VOLUME_DRC_MAXIMUM - VOLUME_DRC_MINIMUM) / 6000.0f, VOLUME_DRC_MAXIMUM * 0.01f); settingAudioVolumeAmplification->SetDependencies(depsAudioOutputPassthroughDisabled); } // audio delay setting - if (SupportsAudioFeature(IPC_AUD_OFFSET) && !m_dspEnabled) + if (SupportsAudioFeature(IPC_AUD_OFFSET)) { std::shared_ptr<CSettingNumber> settingAudioDelay = AddSlider(groupAudio, SETTING_AUDIO_DELAY, 297, SettingLevel::Basic, videoSettings.m_AudioDelay, 0, -g_advancedSettings.m_videoAudioDelayRange, 0.025f, g_advancedSettings.m_videoAudioDelayRange, 297, usePopup); std::static_pointer_cast<CSettingControlSlider>(settingAudioDelay->GetControl())->SetFormatter(SettingFormatterDelay); diff --git a/xbmc/video/dialogs/GUIDialogAudioSettings.h b/xbmc/video/dialogs/GUIDialogAudioSettings.h index 9b7c2ba316..e2f7067797 100644 --- a/xbmc/video/dialogs/GUIDialogAudioSettings.h +++ b/xbmc/video/dialogs/GUIDialogAudioSettings.h @@ -69,7 +69,6 @@ protected: float m_volume; int m_audioStream; bool m_passthrough; - bool m_dspEnabled; typedef std::vector<int> Features; Features m_audioCaps; diff --git a/xbmc/video/dialogs/GUIDialogVideoOSD.cpp b/xbmc/video/dialogs/GUIDialogVideoOSD.cpp index f0a5c03380..f6845f55ee 100644 --- a/xbmc/video/dialogs/GUIDialogVideoOSD.cpp +++ b/xbmc/video/dialogs/GUIDialogVideoOSD.cpp @@ -46,7 +46,6 @@ void CGUIDialogVideoOSD::FrameMove() if (CServiceBroker::GetInputManager().IsMouseActive() || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_AUDIO_OSD_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_SUBTITLE_OSD_SETTINGS) - || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_AUDIO_DSP_OSD_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_VIDEO_OSD_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_CMS_OSD_SETTINGS) || CServiceBroker::GetGUI()->GetWindowManager().IsWindowActive(WINDOW_DIALOG_VIDEO_BOOKMARKS) @@ -97,10 +96,7 @@ bool CGUIDialogVideoOSD::OnMessage(CGUIMessage& message) case GUI_MSG_WINDOW_DEINIT: // fired when OSD is hidden { // Remove our subdialogs if visible - CGUIDialog *pDialog = CServiceBroker::GetGUI()->GetWindowManager().GetDialog(WINDOW_DIALOG_AUDIO_DSP_OSD_SETTINGS); - if (pDialog && pDialog->IsDialogRunning()) - pDialog->Close(true); - pDialog = CServiceBroker::GetGUI()->GetWindowManager().GetDialog(WINDOW_DIALOG_AUDIO_OSD_SETTINGS); + CGUIDialog *pDialog = CServiceBroker::GetGUI()->GetWindowManager().GetDialog(WINDOW_DIALOG_AUDIO_OSD_SETTINGS); if (pDialog && pDialog->IsDialogRunning()) pDialog->Close(true); pDialog = CServiceBroker::GetGUI()->GetWindowManager().GetDialog(WINDOW_DIALOG_SUBTITLE_OSD_SETTINGS); |