fixed: CID 1248203 Logically dead code

The indicated dead code may have performed some action; that action will never occur.
In CRarManager::​CacheRarredFile(std::​basic_string<char, std::​char_traits<char>, std::​allocator<char>> &, std::​basic_string<char, std::​char_traits<char>, std::​allocator<char>> const&, std::​basic_string<char, std::​char_traits<char>, std::​allocator<char>> const&, unsigned char, std::​basic_string<char, std::​char_traits<char>, std::​allocator<char>> const&, long): Code can never be reached because of a logical contradiction (CWE-561)

1 files changed, 1 insertions, 1 deletions

diff --git a/xbmc/filesystem/RarManager.cpp b/xbmc/filesystem/RarManager.cpp
index ac9e077d4c..02a69556f5 100644
--- a/xbmc/filesystem/RarManager.cpp
+++ b/xbmc/filesystem/RarManager.cpp
@@ -226,7 +226,7 @@ bool CRarManager::CacheRarredFile(std::string& strPathInCache, const std::string
 
     if (iOffset == -1 && j != m_ExFiles.end())  // grab from list
     {
-      for( ArchiveList_struct* pIterator = j->second.first; pIterator  ; pIterator ? pIterator = pIterator->next : NULL)
+      for( ArchiveList_struct* pIterator = j->second.first; pIterator; pIterator = pIterator->next)
       {
         std::string strName;