aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaveTBlake <oak99sky@yahoo.co.uk>2020-05-18 12:21:23 +0100
committerDaveTBlake <oak99sky@yahoo.co.uk>2020-05-18 12:21:23 +0100
commit3b95fddf281a519da425ab121a40677830162306 (patch)
tree2021ad2c3151da92a240a3ada4bda66e4507ca17
parent3534b74e87ecdbf1216cdf38e78f56da035ea5b7 (diff)
Prevent album artists being left blank when merging scraped album results and preferring scraper results is enabled
-rw-r--r--xbmc/music/Album.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/xbmc/music/Album.cpp b/xbmc/music/Album.cpp
index 50808e4b76..2836c89542 100644
--- a/xbmc/music/Album.cpp
+++ b/xbmc/music/Album.cpp
@@ -246,17 +246,17 @@ void CAlbum::MergeScrapedAlbum(const CAlbum& source, bool override /* = true */)
}
/*
- Scraping can return different album artists from the originals derived from tags, even when doing
- a lookup on name.
+ Scraping can return different album artists from the originals derived from tags, even when
+ doing a lookup on artist name.
When overwritting the data derived from tags, AND the original and scraped album have the same
Musicbrainz album ID, then merging an album replaces both the album artsts and the song artists
- with those scraped.
+ with those scraped (providing they are not empty).
When not doing that kind of merge, for any matching artist names the Musicbrainz artist id
returned by the scraper can be used to populate any previously missing Musicbrainz artist id values.
*/
- if (bArtistSongMerge)
+ if (bArtistSongMerge && !source.artistCredits.empty())
{
artistCredits = source.artistCredits; // Replace artists and store mbid returned by scraper
strArtistDesc.clear(); // @todo: set artist display string e.g. "artist1 & artist2" when scraped