wallet-core: improve insufficient balance reporting

3 files changed, 206 insertions, 24 deletions

diff --git a/packages/taler-harness/src/harness/harness.ts b/packages/taler-harness/src/harness/harness.ts
index 291cd4c6d..3d9e7fb8a 100644
--- a/packages/taler-harness/src/harness/harness.ts
+++ b/packages/taler-harness/src/harness/harness.ts
@@ -605,6 +605,11 @@ export interface HarnessExchangeBankAccount {
 
   debitRestrictions?: AccountRestriction[];
   creditRestrictions?: AccountRestriction[];
+
+  /**
+   * If set, the harness will not automatically configure the wire fee for this account.
+   */
+  skipWireFeeCreation?: boolean;
 }
 
 /**
@@ -1320,7 +1325,6 @@ export class ExchangeService implements ExchangeServiceInterface {
       if (!p) {
         throw Error(`invalid payto uri in exchange config: ${paytoUri}`);
       }
-      accountTargetTypes.add(p?.targetType);
       const optArgs: string[] = [];
       if (acct.conversionUrl != null) {
         optArgs.push("conversion-url", acct.conversionUrl);
@@ -1339,33 +1343,43 @@ export class ExchangeService implements ExchangeServiceInterface {
           "upload",
         ],
       );
-    }
 
-    const year = new Date().getFullYear();
-    for (const accTargetType of accountTargetTypes.values()) {
-      for (let i = year; i < year + 5; i++) {
-        await runCommand(
-          this.globalState,
-          "exchange-offline",
-          "taler-exchange-offline",
-          [
-            "-c",
-            this.configFilename,
-            "wire-fee",
-            // Year
-            `${i}`,
-            // Wire method
-            accTargetType,
-            // Wire fee
-            `${this.exchangeConfig.currency}:0.01`,
-            // Closing fee
-            `${this.exchangeConfig.currency}:0.01`,
-            "upload",
-          ],
-        );
+      const accTargetType = p.targetType;
+
+      const covered = accountTargetTypes.has(p.targetType);
+      if (!covered && !acct.skipWireFeeCreation) {
+        const year = new Date().getFullYear();
+
+        for (let i = year; i < year + 5; i++) {
+          await runCommand(
+            this.globalState,
+            "exchange-offline",
+            "taler-exchange-offline",
+            [
+              "-c",
+              this.configFilename,
+              "wire-fee",
+              // Year
+              `${i}`,
+              // Wire method
+              accTargetType,
+              // Wire fee
+              `${this.exchangeConfig.currency}:0.01`,
+              // Closing fee
+              `${this.exchangeConfig.currency}:0.01`,
+              "upload",
+            ],
+          );
+          accountTargetTypes.add(accTargetType);
+        }
       }
     }
 
+    const wireTypeConfigured: Set<string> = new Set();
+
+    for (const acct of this.exchangeBankAccounts) {
+    }
+
     await runCommand(
       this.globalState,
       "exchange-offline",
diff --git a/packages/taler-harness/src/integrationtests/test-wallet-insufficient-balance.ts b/packages/taler-harness/src/integrationtests/test-wallet-insufficient-balance.ts
new file mode 100644
index 000000000..ac1244446
--- /dev/null
+++ b/packages/taler-harness/src/integrationtests/test-wallet-insufficient-balance.ts
@@ -0,0 +1,166 @@
+/*
+ This file is part of GNU Taler
+ (C) 2020 Taler Systems S.A.
+
+ GNU Taler is free software; you can redistribute it and/or modify it under the
+ terms of the GNU General Public License as published by the Free Software
+ Foundation; either version 3, or (at your option) any later version.
+
+ GNU Taler is distributed in the hope that it will be useful, but WITHOUT ANY
+ WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+ A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License along with
+ GNU Taler; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
+ */
+
+/**
+ * Imports.
+ */
+import {
+  AmountString,
+  Duration,
+  PaymentInsufficientBalanceDetails,
+  TalerErrorCode,
+  WalletNotification,
+} from "@gnu-taler/taler-util";
+import { WalletApiOperation } from "@gnu-taler/taler-wallet-core";
+import { CoinConfig, defaultCoinConfig } from "../harness/denomStructures.js";
+import {
+  ExchangeService,
+  FakebankService,
+  GlobalTestState,
+  MerchantService,
+  WalletClient,
+  WalletService,
+  generateRandomPayto,
+  setupDb,
+} from "../harness/harness.js";
+import { withdrawViaBankV2 } from "../harness/helpers.js";
+
+export async function runWalletInsufficientBalanceTest(t: GlobalTestState) {
+  // Set up test environment
+
+  const db = await setupDb(t);
+
+  const bank = await FakebankService.create(t, {
+    allowRegistrations: true,
+    currency: "TESTKUDOS",
+    database: db.connStr,
+    httpPort: 8082,
+  });
+
+  const exchange = ExchangeService.create(t, {
+    name: "testexchange-1",
+    currency: "TESTKUDOS",
+    httpPort: 8081,
+    database: db.connStr,
+  });
+
+  const merchant = await MerchantService.create(t, {
+    name: "testmerchant-1",
+    currency: "TESTKUDOS",
+    httpPort: 8083,
+    database: db.connStr,
+  });
+
+  const exchangeBankAccount = await bank.createExchangeAccount(
+    "myexchange",
+    "x",
+  );
+  exchangeBankAccount.skipWireFeeCreation = true;
+  exchange.addBankAccount("1", exchangeBankAccount);
+
+  bank.setSuggestedExchange(exchange, exchangeBankAccount.accountPaytoUri);
+
+  await bank.start();
+
+  await bank.pingUntilAvailable();
+
+  const coinConfig: CoinConfig[] = defaultCoinConfig.map((x) => x("TESTKUDOS"));
+  exchange.addCoinConfigList(coinConfig);
+
+  await exchange.start();
+  await exchange.pingUntilAvailable();
+
+  merchant.addExchange(exchange);
+
+  await merchant.start();
+  await merchant.pingUntilAvailable();
+
+  await merchant.addInstanceWithWireAccount({
+    id: "default",
+    name: "Default Instance",
+    paytoUris: [generateRandomPayto("merchant-default")],
+    defaultWireTransferDelay: Duration.toTalerProtocolDuration(
+      Duration.fromSpec({ minutes: 1 }),
+    ),
+  });
+
+  await merchant.addInstanceWithWireAccount({
+    id: "minst1",
+    name: "minst1",
+    paytoUris: [generateRandomPayto("minst1")],
+    defaultWireTransferDelay: Duration.toTalerProtocolDuration(
+      Duration.fromSpec({ minutes: 1 }),
+    ),
+  });
+
+  const walletService = new WalletService(t, {
+    name: "wallet",
+    useInMemoryDb: true,
+  });
+  await walletService.start();
+  await walletService.pingUntilAvailable();
+
+  const allNotifications: WalletNotification[] = [];
+
+  const walletClient = new WalletClient({
+    name: "wallet",
+    unixPath: walletService.socketPath,
+    onNotification(n) {
+      console.log("got notification", n);
+      allNotifications.push(n);
+    },
+  });
+  await walletClient.connect();
+  await walletClient.client.call(WalletApiOperation.InitWallet, {
+    config: {
+      testing: {
+        skipDefaults: true,
+      },
+    },
+  });
+
+  const wres = await withdrawViaBankV2(t, {
+    amount: "TESTKUDOS:10",
+    bank,
+    exchange,
+    walletClient,
+  });
+  await wres.withdrawalFinishedCond;
+
+  const exc = await t.assertThrowsTalerErrorAsync(async () => {
+    await walletClient.call(WalletApiOperation.PrepareDeposit, {
+      amount: "TESTKUDOS:5" as AmountString,
+      depositPaytoUri: "payto://x-taler-bank/localhost/foobar",
+    });
+  });
+  t.assertDeepEqual(
+    exc.errorDetail.code,
+    TalerErrorCode.WALLET_DEPOSIT_GROUP_INSUFFICIENT_BALANCE,
+  );
+  const insufficientBalanceDetails: PaymentInsufficientBalanceDetails =
+    exc.errorDetail.insufficientBalanceDetails;
+
+  t.assertAmountEquals(
+    insufficientBalanceDetails.balanceAvailable,
+    "TESTKUDOS:9.72",
+  );
+  t.assertAmountEquals(
+    insufficientBalanceDetails.balanceExchangeDepositable,
+    "TESTKUDOS:0",
+  );
+}
+
+runWalletInsufficientBalanceTest.suites = ["wallet"];
diff --git a/packages/taler-harness/src/integrationtests/testrunner.ts b/packages/taler-harness/src/integrationtests/testrunner.ts
index 803e68e6b..0bfb245ab 100644
--- a/packages/taler-harness/src/integrationtests/testrunner.ts
+++ b/packages/taler-harness/src/integrationtests/testrunner.ts
@@ -96,6 +96,7 @@ import { runWalletDblessTest } from "./test-wallet-dbless.js";
 import { runWalletDd48Test } from "./test-wallet-dd48.js";
 import { runWalletDevExperimentsTest } from "./test-wallet-dev-experiments.js";
 import { runWalletGenDbTest } from "./test-wallet-gendb.js";
+import { runWalletInsufficientBalanceTest } from "./test-wallet-insufficient-balance.js";
 import { runWalletNotificationsTest } from "./test-wallet-notifications.js";
 import { runWalletObservabilityTest } from "./test-wallet-observability.js";
 import { runWalletRefreshTest } from "./test-wallet-refresh.js";
@@ -204,6 +205,7 @@ const allTests: TestMainFunction[] = [
   runWalletObservabilityTest,
   runWalletDevExperimentsTest,
   runWalletBalanceZeroTest,
+  runWalletInsufficientBalanceTest,
 ];
 
 export interface TestRunSpec {