-doxygen fixes

4 files changed, 5 insertions, 120 deletions

diff --git a/src/auditor/report-lib.c b/src/auditor/report-lib.c
index 0dea786da..97270ffbe 100644
--- a/src/auditor/report-lib.c
+++ b/src/auditor/report-lib.c
@@ -89,13 +89,6 @@ static struct GNUNET_SIGNAL_Context *sig_int;
 static struct GNUNET_SIGNAL_Context *sig_term;
 
 
-/**
- * Test if the audit should be aborted because the user
- * pressed CTRL-C.
- *
- * @return false to continue the audit, true to terminate
- *         cleanly as soon as possible
- */
 bool
 TALER_ARL_do_abort (void)
 {
@@ -103,12 +96,6 @@ TALER_ARL_do_abort (void)
 }
 
 
-/**
- * Add @a object to the report @a array.  Fail hard if this fails.
- *
- * @param array report array to append @a object to
- * @param object object to append, should be check that it is not NULL
- */
 void
 TALER_ARL_report (json_t *array,
                   json_t *object)
@@ -183,14 +170,6 @@ add_denomination (
 }
 
 
-/**
- * Obtain information about a @a denom_pub.
- *
- * @param dh hash of the denomination public key to look up
- * @param[out] issue set to detailed information about @a denom_pub, NULL if not found, must
- *                 NOT be freed by caller
- * @return transaction status code
- */
 enum GNUNET_DB_QueryStatus
 TALER_ARL_get_denomination_info_by_hash (
   const struct TALER_DenominationHash *dh,
@@ -262,15 +241,6 @@ TALER_ARL_get_denomination_info_by_hash (
 }
 
 
-/**
- * Obtain information about a @a denom_pub.
- *
- * @param denom_pub key to look up
- * @param[out] issue set to detailed information about @a denom_pub, NULL if not found, must
- *                 NOT be freed by caller
- * @param[out] dh set to the hash of @a denom_pub, may be NULL
- * @return transaction status code
- */
 enum GNUNET_DB_QueryStatus
 TALER_ARL_get_denomination_info (
   const struct TALER_DenominationPublicKey *denom_pub,
@@ -298,7 +268,7 @@ TALER_ARL_get_denomination_info (
  *         #GNUNET_NO if we had an error on commit (retry may help)
  *         #GNUNET_SYSERR on hard errors
  */
-static int
+static enum GNUNET_GenericReturnValue
 transact (TALER_ARL_Analysis analysis,
           void *analysis_cls)
 {
@@ -369,14 +339,7 @@ transact (TALER_ARL_Analysis analysis,
 }
 
 
-/**
- * Initialize DB sessions and run the analysis.
- *
- * @param ana analysis to run
- * @param ana_cls closure for @a ana
- * @return #GNUNET_OK on success
- */
-int
+enum GNUNET_GenericReturnValue
 TALER_ARL_setup_sessions_and_run (TALER_ARL_Analysis ana,
                                   void *ana_cls)
 {
@@ -424,19 +387,6 @@ test_master_present (void *cls,
 }
 
 
-/**
- * Perform addition of amounts.  If the addition fails, logs
- * a detailed error and calls exit() to terminate the process (!).
- *
- * Do not call this function directly, use #TALER_ARL_amount_add().
- *
- * @param[out] sum where to store @a a1 + @a a2, set to "invalid" on overflow
- * @param a1 first amount to add
- * @param a2 second amount to add
- * @param filename where is the addition called
- * @param functionname name of the function where the addition is called
- * @param line line number of the addition
- */
 void
 TALER_ARL_amount_add_ (struct TALER_Amount *sum,
                        const struct TALER_Amount *a1,
@@ -485,19 +435,6 @@ TALER_ARL_amount_add_ (struct TALER_Amount *sum,
 }
 
 
-/**
- * Perform subtraction of amounts. If the subtraction fails, logs
- * a detailed error and calls exit() to terminate the process (!).
- *
- * Do not call this function directly, use #TALER_ARL_amount_subtract().
- *
- * @param[out] diff where to store (@a a1 - @a a2)
- * @param a1 amount to subtract from
- * @param a2 amount to subtract
- * @param filename where is the addition called
- * @param functionname name of the function where the addition is called
- * @param line line number of the addition
- */
 void
 TALER_ARL_amount_subtract_ (struct TALER_Amount *diff,
                             const struct TALER_Amount *a1,
@@ -546,24 +483,6 @@ TALER_ARL_amount_subtract_ (struct TALER_Amount *diff,
 }
 
 
-/**
- * Perform subtraction of amounts. Negative results should be signalled by the
- * return value (leaving @a diff set to 'invalid'). If the subtraction fails
- * for other reasons (currency mismatch, normalization failure), logs a
- * detailed error and calls exit() to terminate the process (!).
- *
- * Do not call this function directly, use #TALER_ARL_amount_subtract_neg().
- *
- * @param[out] diff where to store (@a a1 - @a a2)
- * @param a1 amount to subtract from
- * @param a2 amount to subtract
- * @param filename where is the addition called
- * @param functionname name of the function where the addition is called
- * @param line line number of the addition
- * @return #TALER_ARL_SR_INVALID_NEGATIVE if the result was negative (and @a diff is now invalid),
- *         #TALER_ARL_SR_ZERO if the result was zero,
- *         #TALER_ARL_SR_POSITIVE if the result is positive
- */
 enum TALER_ARL_SubtractionResult
 TALER_ARL_amount_subtract_neg_ (struct TALER_Amount *diff,
                                 const struct TALER_Amount *a1,
@@ -622,13 +541,7 @@ handle_sigint (void)
 }
 
 
-/**
- * Setup global variables based on configuration.
- *
- * @param c configuration to use
- * @return #GNUNET_OK on success
- */
-int
+enum GNUNET_GenericReturnValue
 TALER_ARL_init (const struct GNUNET_CONFIGURATION_Handle *c)
 {
   TALER_ARL_cfg = c;
@@ -822,11 +735,6 @@ TALER_ARL_init (const struct GNUNET_CONFIGURATION_Handle *c)
 }
 
 
-/**
- * Generate the report and close connectios to the database.
- *
- * @param report the report to output, may be NULL for no report
- */
 void
 TALER_ARL_done (json_t *report)
 {
diff --git a/src/auditor/report-lib.h b/src/auditor/report-lib.h
index 3f4489763..8ef7e048a 100644
--- a/src/auditor/report-lib.h
+++ b/src/auditor/report-lib.h
@@ -276,7 +276,7 @@ TALER_ARL_amount_subtract_neg_ (struct TALER_Amount *diff,
  * @param ana_cls closure for @a ana
  * @return #GNUNET_OK on success
  */
-int
+enum GNUNET_GenericReturnValue
 TALER_ARL_setup_sessions_and_run (TALER_ARL_Analysis ana,
                                   void *ana_cls);
 
@@ -298,7 +298,7 @@ TALER_ARL_do_abort (void);
  * @param c configuration to use
  * @return #GNUNET_OK on success
  */
-int
+enum GNUNET_GenericReturnValue
 TALER_ARL_init (const struct GNUNET_CONFIGURATION_Handle *c);
 
 
diff --git a/src/auditor/taler-auditor-httpd_deposit-confirmation.c b/src/auditor/taler-auditor-httpd_deposit-confirmation.c
index 694753c8d..7f4d4286c 100644
--- a/src/auditor/taler-auditor-httpd_deposit-confirmation.c
+++ b/src/auditor/taler-auditor-httpd_deposit-confirmation.c
@@ -221,20 +221,6 @@ verify_and_execute_deposit_confirmation (
 }
 
 
-/**
- * Handle a "/deposit-confirmation" request.  Parses the JSON, and, if
- * successful, passes the JSON data to #verify_and_execute_deposit_confirmation()
- * to further check the details of the operation specified.  If
- * everything checks out, this will ultimately lead to the "/deposit-confirmation"
- * being stored in the database.
- *
- * @param rh context of the handler
- * @param connection the MHD connection to handle
- * @param[in,out] connection_cls the connection's closure (can be updated)
- * @param upload_data upload data
- * @param[in,out] upload_data_size number of bytes (left) in @a upload_data
- * @return MHD result code
-  */
 MHD_RESULT
 TAH_DEPOSIT_CONFIRMATION_handler (struct TAH_RequestHandler *rh,
                                   struct MHD_Connection *connection,
@@ -323,9 +309,6 @@ TAH_DEPOSIT_CONFIRMATION_handler (struct TAH_RequestHandler *rh,
 }
 
 
-/**
- * Initialize subsystem.
- */
 void
 TEAH_DEPOSIT_CONFIRMATION_init (void)
 {
@@ -335,9 +318,6 @@ TEAH_DEPOSIT_CONFIRMATION_init (void)
 }
 
 
-/**
- * Shut down subsystem.
- */
 void
 TEAH_DEPOSIT_CONFIRMATION_done (void)
 {
diff --git a/src/auditor/taler-helper-auditor-coins.c b/src/auditor/taler-helper-auditor-coins.c
index 3473a8284..d425b9ead 100644
--- a/src/auditor/taler-helper-auditor-coins.c
+++ b/src/auditor/taler-helper-auditor-coins.c
@@ -1086,9 +1086,6 @@ struct RevealContext
  * @param cls closure with a `struct RevealContext *` in it
  * @param num_freshcoins size of the @a rrcs array
  * @param rrcs array of @a num_freshcoins information about coins to be created
- * @param num_tprivs number of entries in @a tprivs, should be #TALER_CNC_KAPPA - 1
- * @param tprivs array of @e num_tprivs transfer private keys
- * @param tp transfer public key information
  */
 static void
 reveal_data_cb (void *cls,