aboutsummaryrefslogtreecommitdiff
path: root/t/test.t
diff options
context:
space:
mode:
Diffstat (limited to 't/test.t')
-rwxr-xr-xt/test.t232
1 files changed, 116 insertions, 116 deletions
diff --git a/t/test.t b/t/test.t
index f8b918b..d69ef34 100755
--- a/t/test.t
+++ b/t/test.t
@@ -10,7 +10,7 @@ use Text::Diff;
use lib ".";
use SBO::Lib;
-chomp (my $pwd = `pwd`);
+chomp(my $pwd = `pwd`);
my $sbo_home = "$pwd/sbo";
$conf_file = "$pwd/sbotools.conf";
@@ -20,207 +20,207 @@ $SBO::Lib::distfiles = "$sbo_home/distfiles";
$SBO::Lib::slackbuilds_txt = "$sbo_home/SLACKBUILDS.TXT";
# config settings tests
-is ($config{DISTCLEAN}, 'FALSE', 'config{DISTCLEAN} is good');
-is ($config{JOBS}, 2, 'config{JOBS} is good');
-is ($config{NOCLEAN}, 'FALSE', 'config{NOCLEAN} is good');
-is ($config{PKG_DIR}, 'FALSE', 'config{PKG_DIR} is good');
-is ($config{SBO_HOME}, "$pwd/sbo", 'config{SBO_HOME} is good');
+is($config{DISTCLEAN}, 'FALSE', 'config{DISTCLEAN} is good');
+is($config{JOBS}, 2, 'config{JOBS} is good');
+is($config{NOCLEAN}, 'FALSE', 'config{NOCLEAN} is good');
+is($config{PKG_DIR}, 'FALSE', 'config{PKG_DIR} is good');
+is($config{SBO_HOME}, "$pwd/sbo", 'config{SBO_HOME} is good');
# open_read, open_fh tests
my $fh = open_read ('./test.t');
-is (ref $fh, 'GLOB', 'open_read works');
+is(ref $fh, 'GLOB', 'open_read works');
close $fh;
# test to ensure tempdir is defined by default
-ok (defined $tempdir, '$tempdir is defined');
+ok(defined $tempdir, '$tempdir is defined');
# show_version test
-is (show_version, 1, 'show_version is good');
+is(show_version, 1, 'show_version is good');
# get_slack_version test
-is (get_slack_version, '14.0', 'get_slack_version is good');
+is(get_slack_version, '14.0', 'get_slack_version is good');
# chk_slackbuilds_txt tests
-is (chk_slackbuilds_txt, 1, 'chk_slackbuilds_txt is good');
-move ("$sbo_home/SLACKBUILDS.TXT", "$sbo_home/SLACKBUILDS.TXT.moved");
-is (chk_slackbuilds_txt, undef,
+is(chk_slackbuilds_txt, 1, 'chk_slackbuilds_txt is good');
+move("$sbo_home/SLACKBUILDS.TXT", "$sbo_home/SLACKBUILDS.TXT.moved");
+is(chk_slackbuilds_txt, undef,
'chk_slackbuilds_txt returns false with no SLACKBUILDS.TXT');
-move ("$sbo_home/SLACKBUILDS.TXT.moved", "$sbo_home/SLACKBUILDS.TXT");
+move("$sbo_home/SLACKBUILDS.TXT.moved", "$sbo_home/SLACKBUILDS.TXT");
#ok (rsync_sbo_tree == 1, 'rsync_sbo_tree is good');
#ok (update_tree == 1, 'update_tree is good');
# slackbuilds_or_fetch test
-is (slackbuilds_or_fetch, 1, 'slackbuilds_or_fetch is good');
+is(slackbuilds_or_fetch, 1, 'slackbuilds_or_fetch is good');
# get_installed_sbos test
print "pseudo-random sampling of get_installed_sbos output...\n";
$SBO::Lib::pkg_db = "$pwd/packages";
my $installed = get_installed_sbos;
for my $key (keys @$installed) {
- is ($$installed[$key]{version}, '1.13') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '1.13') if $$installed[$key]{name} eq
'OpenAL';
- is ($$installed[$key]{version}, '9.5.1_enu') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '9.5.1_enu') if $$installed[$key]{name} eq
'adobe-reader';
- is ($$installed[$key]{version}, '4.1.3') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '4.1.3') if $$installed[$key]{name} eq
'libdvdnav';
- is ($$installed[$key]{version}, '0.8.8.4') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '0.8.8.4') if $$installed[$key]{name} eq
'libmodplug';
- is ($$installed[$key]{version}, '575') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '575') if $$installed[$key]{name} eq
'unetbootin';
- is ($$installed[$key]{version}, '2.6.0') if $$installed[$key]{name} eq
+ is($$installed[$key]{version}, '2.6.0') if $$installed[$key]{name} eq
'zdoom';
}
print "completed pseudo-random testing of get_installed_sbos \n";
# get_sbo_location tests
-is (get_sbo_location ('nginx'), "$sbo_home/network/nginx",
+is(get_sbo_location ('nginx'), "$sbo_home/network/nginx",
'get_sbo_location is good');
-is (get_sbo_location ('omgwtfbbq'), undef,
+is(get_sbo_location ('omgwtfbbq'), undef,
'get_sbo_location returns false with not-an-sbo input');
my @finds = qw(nginx gmpc);
-my %locs = get_sbo_location (@finds);
-is ($locs{nginx}, "$sbo_home/network/nginx",
+my %locs = get_sbo_location(@finds);
+is($locs{nginx}, "$sbo_home/network/nginx",
'get_sbo_location passed array #1 good');
-is ($locs{gmpc}, "$sbo_home/audio/gmpc", 'get_sbo_location passed array #2 good');
-%locs = get_sbo_location (\@finds);
-is ($locs{nginx}, "$sbo_home/network/nginx",
+is($locs{gmpc}, "$sbo_home/audio/gmpc", 'get_sbo_location passed array #2 good');
+%locs = get_sbo_location(\@finds);
+is($locs{nginx}, "$sbo_home/network/nginx",
'get_sbo_location passed array ref #1 good');
-is ($locs{gmpc}, "$sbo_home/audio/gmpc",
+is($locs{gmpc}, "$sbo_home/audio/gmpc",
'get_sbo_location passed array ref #2 good');
# get_available_updates tests
my $updates = get_available_updates;
say "have updates";
for my $key (keys @$updates) {
- is ($$updates[$key]{installed}, '1.15',
+ is($$updates[$key]{installed}, '1.15',
'$$updates[$key]{installed} good for mutagen') if $$updates[$key]{name}
eq 'mutagen';
- is ($$updates[$key]{update}, '1.20',
+ is($$updates[$key]{update}, '1.20',
'$$updates[$key]{update} good for mutagen') if $$updates[$key]{name} eq
'mutagen';
}
# get_arch test
-is (get_arch, 'x86_64', 'get_arch is good');
+is(get_arch, 'x86_64', 'get_arch is good');
# get_download_info tests
-my %dl_info = get_download_info (LOCATION => "$sbo_home/system/wine", X64 => 0);
+my %dl_info = get_download_info(LOCATION => "$sbo_home/system/wine", X64 => 0);
my $link = 'http://downloads.sf.net/wine/source/1.4/wine-1.4.1.tar.bz2';
-is ($dl_info{$link}, '0c28702ed478df7a1c097f3a9c4cabd6',
+is($dl_info{$link}, '0c28702ed478df7a1c097f3a9c4cabd6',
'get_download_info test 01 good.');
$link = 'http://www.unrealize.co.uk/source/dibeng-max-2010-11-12.zip';
-is ($dl_info{$link}, '97159d77631da13952fe87e846cf1f3b',
+is($dl_info{$link}, '97159d77631da13952fe87e846cf1f3b',
'get_download_info test 02 good.');
# get_sbo_downloads tests
-%dl_info = get_sbo_downloads (LOCATION => "$sbo_home/system/wine");
+%dl_info = get_sbo_downloads(LOCATION => "$sbo_home/system/wine");
$link = 'http://downloads.sf.net/wine/source/1.4/wine-1.4.1.tar.bz2';
-is ($dl_info{$link}, '0c28702ed478df7a1c097f3a9c4cabd6',
+is($dl_info{$link}, '0c28702ed478df7a1c097f3a9c4cabd6',
'get_sbo_downloads test 01 good.');
$link = 'http://www.unrealize.co.uk/source/dibeng-max-2010-11-12.zip';
-is ($dl_info{$link}, '97159d77631da13952fe87e846cf1f3b',
+is($dl_info{$link}, '97159d77631da13952fe87e846cf1f3b',
'get_sbo_downloads test 02 good.');
-my %downloads = get_sbo_downloads (LOCATION => "$sbo_home/system/ifuse");
+my %downloads = get_sbo_downloads(LOCATION => "$sbo_home/system/ifuse");
$link = 'http://www.libimobiledevice.org/downloads/ifuse-1.1.1.tar.bz2';
-is ($downloads{$link}, '8d528a79de024b91f12f8ac67965c37c',
+is($downloads{$link}, '8d528a79de024b91f12f8ac67965c37c',
'get_sbo_downloads test 03 good.');
# get_filename_from_link test
-is (get_filename_from_link
- 'http://www.libimobiledevice.org/downloads/ifuse-1.1.1.tar.bz2',
+is(get_filename_from_link(
+ 'http://www.libimobiledevice.org/downloads/ifuse-1.1.1.tar.bz2'),
"$sbo_home/distfiles/ifuse-1.1.1.tar.bz2", 'get_file_from_link good');
-is (get_filename_from_link 'adf;lkajsdfaksjdfalsdjfalsdkfjdsfj', undef,
+is(get_filename_from_link('adf;lkajsdfaksjdfalsdjfalsdkfjdsfj'), undef,
'get_filename_from_link good with invalid input');
# compute_md5sum test
-is (compute_md5sum "$sbo_home/distfiles/test.file",
+is(compute_md5sum("$sbo_home/distfiles/test.file"),
'593d3125d3170f0b5326a40a253aa6fd', 'compute_md5sum good');
# verify_distfile test
-is (verify_distfile ("http://dawnrazor.net/test.file",
+is(verify_distfile("http://dawnrazor.net/test.file",
'593d3125d3170f0b5326a40a253aa6fd'), 1, 'verify_distfile good');
# get_sbo_version test
-is (get_sbo_version "$sbo_home/system/wine", '1.4.1', 'get_sbo_version good');
+is(get_sbo_version("$sbo_home/system/wine"), '1.4.1', 'get_sbo_version good');
# get_symlink_from_filename test
-is (get_symlink_from_filename ("$sbo_home/distfiles/test.file",
+is(get_symlink_from_filename("$sbo_home/distfiles/test.file",
"$sbo_home/system/laptop-mode-tools"),
"$sbo_home/system/laptop-mode-tools/test.file",
'get_symlink_from_filename good');
# check_x32 tests
-ok (check_x32 "$sbo_home/system/wine", 'check_x32 true for 32-bit only wine');
-ok (!(check_x32 "$sbo_home/system/ifuse"),
+ok(check_x32("$sbo_home/system/wine"), 'check_x32 true for 32-bit only wine');
+ok(!(check_x32("$sbo_home/system/ifuse")),
'check_x32 false for not-32-bit-only ifuse');
# check_multilib tests
-ok (check_multilib, 'check_multilib good');
+ok(check_multilib, 'check_multilib good');
# create_symlinks tests
-%downloads = get_sbo_downloads (LOCATION => "$sbo_home/system/wine", 32 => 1);
+%downloads = get_sbo_downloads(LOCATION => "$sbo_home/system/wine", 32 => 1);
my @symlinks = create_symlinks "$sbo_home/system/wine", %downloads;
-is ($symlinks[0], "$sbo_home/system/wine/wine-1.4.1.tar.bz2",
+is($symlinks[0], "$sbo_home/system/wine/wine-1.4.1.tar.bz2",
'$symlinks[0] good for create_symlinks');
-is ($symlinks[1], "$sbo_home/system/wine/dibeng-max-2010-11-12.zip",
+is($symlinks[1], "$sbo_home/system/wine/dibeng-max-2010-11-12.zip",
'$symlinks[1] good for create_symlinks');
# grok_temp_file, get_src_dir/get_pkg_name tests
-my $tempdir = tempdir (CLEANUP => 1);
-my $tempfh = tempfile (DIR => $tempdir);
+my $tempdir = tempdir(CLEANUP => 1);
+my $tempfh = tempfile(DIR => $tempdir);
my $lmt = 'laptop-mode-tools_1.60';
print {$tempfh} "$lmt/COPYING\n";
print {$tempfh} "$lmt/Documentation/\n";
print {$tempfh} "$lmt/README\n";
print {$tempfh} "Slackware package skype-2.2.0.35-i486-1_SBo.tgz created.\n";
-is (get_src_dir $tempfh, 'laptop-mode-tools_1.60', 'get_src_dir good');
-is (get_pkg_name $tempfh, 'skype-2.2.0.35-i486-1_SBo.tgz', 'get_pkg_name good');
+is(get_src_dir $tempfh, 'laptop-mode-tools_1.60', 'get_src_dir good');
+is(get_pkg_name $tempfh, 'skype-2.2.0.35-i486-1_SBo.tgz', 'get_pkg_name good');
close $tempfh;
# check_distfiles test
-%downloads = get_sbo_downloads (LOCATION => "$sbo_home/perl/perl-Sort-Versions");
-is ((check_distfiles %downloads), 1, 'check_distfiles good');
+%downloads = get_sbo_downloads(LOCATION => "$sbo_home/perl/perl-Sort-Versions");
+is((check_distfiles %downloads), 1, 'check_distfiles good');
# check_home tests
$config{SBO_HOME} = "$pwd/test_sbo";
-ok (check_home, 'check_home returns true with new non-existent directory');
-ok (-d "$pwd/test_sbo", 'check_home creates $config{SBO_HOME}');
-ok (check_home, 'check_home returns true with new existent empty directory');
+ok(check_home, 'check_home returns true with new non-existent directory');
+ok(-d "$pwd/test_sbo", 'check_home creates $config{SBO_HOME}');
+ok(check_home, 'check_home returns true with new existent empty directory');
rmdir "$pwd/test_sbo";
$config{SBO_HOME} = $sbo_home;
# get_sbo_from_loc tests
-is (get_sbo_from_loc '/home/d4wnr4z0r/sbo.git/system/ifuse', 'ifuse',
+is(get_sbo_from_loc('/home/d4wnr4z0r/sbo.git/system/ifuse'), 'ifuse',
'get_sbo_from_loc returns correctly with valid input');
-ok (! get_sbo_from_loc 'omg_wtf_bbq',
+ok(! get_sbo_from_loc('omg_wtf_bbq'),
'get_sbo_from_loc returns false with invalid input');
# get_distfile tests
my $distfile = "$sbo_home/distfiles/Sort-Versions-1.5.tar.gz";
unlink $distfile if -f $distfile;
-is (get_distfile
+is(get_distfile
('http://search.cpan.org/CPAN/authors/id/E/ED/EDAVIS/Sort-Versions-1.5.tar.gz',
'5434f948fdea6406851c77bebbd0ed19'), 1, 'get_distfile is good');
unlink $distfile;
# rewrite_slackbuilds/revert_slackbuild tests
-my $rewrite_dir = tempdir (CLEANUP => 1);
-copy ("$sbo_home/system/ifuse/ifuse.SlackBuild", $rewrite_dir);
+my $rewrite_dir = tempdir(CLEANUP => 1);
+copy("$sbo_home/system/ifuse/ifuse.SlackBuild", $rewrite_dir);
my $slackbuild = "$rewrite_dir/ifuse.SlackBuild";
-$tempfh = tempfile (DIR => $rewrite_dir);
+$tempfh = tempfile(DIR => $rewrite_dir);
my $tempfn = get_tmp_extfn $tempfh;
my %changes = ();
-is (rewrite_slackbuild (SLACKBUILD => $slackbuild, TEMPFN => $tempfn,
+is(rewrite_slackbuild (SLACKBUILD => $slackbuild, TEMPFN => $tempfn,
CHANGES => \%changes), 1, 'rewrite_slackbuild with no %changes good');
-ok (-f "$slackbuild.orig", 'rewrite_slackbuild backing up original is good.');
-is (revert_slackbuild $slackbuild, 1, 'revert_slackbuild is good');
+ok(-f "$slackbuild.orig", 'rewrite_slackbuild backing up original is good.');
+is(revert_slackbuild $slackbuild, 1, 'revert_slackbuild is good');
$changes{libdirsuffix} = '';
$changes{make} = '-j 5';
$changes{arch_out} = 'i486';
-is (rewrite_slackbuild (SLACKBUILD => $slackbuild, TEMPFN => $tempfn,
+is(rewrite_slackbuild (SLACKBUILD => $slackbuild, TEMPFN => $tempfn,
CHANGES => \%changes), 1, 'rewrite_slackbuild with all %changes good');
-ok (-f "$slackbuild.orig", 'rewrite_slackbuild backing up original is good.');
+ok(-f "$slackbuild.orig", 'rewrite_slackbuild backing up original is good.');
my $expected_out = "55c55
< LIBDIRSUFFIX=\"64\"
---
@@ -230,43 +230,43 @@ my $expected_out = "55c55
---
> /sbin/makepkg -l y -c n \$OUTPUT/\$PRGNAM-\$VERSION-i486-\$BUILD\$TAG.\${PKGTYPE:-tgz}
";
-is (diff ("$slackbuild.orig", $slackbuild, {STYLE => 'OldStyle'}),
+is(diff("$slackbuild.orig", $slackbuild, {STYLE => 'OldStyle'}),
$expected_out, 'all changed lines rewritten correctly');
-is (revert_slackbuild $slackbuild, 1, 'revert_slackbuild is good again');
+is(revert_slackbuild $slackbuild, 1, 'revert_slackbuild is good again');
# get_from_info tests
my $test_loc = "$sbo_home/system/ifuse";
my %params = (LOCATION => $test_loc);
-my $info = get_from_info (%params, GET => 'VERSION');
-is ($$info[0], '1.1.1', 'get_from_info GET => VERSION is good');
-$info = get_from_info (%params, GET => 'HOMEPAGE');
-is ($$info[0], 'http://www.libimobiledevice.org',
+my $info = get_from_info(%params, GET => 'VERSION');
+is($$info[0], '1.1.1', 'get_from_info GET => VERSION is good');
+$info = get_from_info(%params, GET => 'HOMEPAGE');
+is($$info[0], 'http://www.libimobiledevice.org',
'get_from_info GET => HOMEPAGE is good');
-$info = get_from_info (%params, GET => 'DOWNLOAD_x86_64');
-is ($$info[0], "", 'get_from_info GET => DOWNLOAD_x86_64 is good');
+$info = get_from_info(%params, GET => 'DOWNLOAD_x86_64');
+is($$info[0], "", 'get_from_info GET => DOWNLOAD_x86_64 is good');
# get_update_list tests
my $listing = get_update_list;
s/\s//g for @$listing;
for my $item (@$listing) {
- is ($item, 'ffmpeg-0.8.7<needsupdating(SBohas0.11.1)',
+ is($item, 'ffmpeg-0.8.7<needsupdating(SBohas0.11.1)',
'get_update_list output good for ffmpeg') if $item =~ /^ffmpeg/;
- is ($item, 'mutagen-1.15<needsupdating(SBohas1.20)',
+ is($item, 'mutagen-1.15<needsupdating(SBohas1.20)',
'get_update_list output good for mutagen') if $item =~ /^atkmm/;
}
# remove_stuff test - can only really test for invalid input
-is (remove_stuff '/omg/wtf/bbq', 1, 'remove_stuff good for invalid input');
+is(remove_stuff('/omg/wtf/bbq'), 1, 'remove_stuff good for invalid input');
# config_write test
chmod 0444, $conf_file;
-is (config_write ('OMG', 'WTF'), undef,
+is(config_write ('OMG', 'WTF'), undef,
'config_write returned undef correctly');
chmod
chmod 0644, $conf_file;
# perform_search tests
-my $findings = perform_search 'desktop';
+my $findings = perform_search('desktop');
for my $found (@$findings) {
for my $key (keys %$found) {
my $section = 'desktop';;
@@ -281,7 +281,7 @@ for my $found (@$findings) {
} elsif ($key eq 'gsettings-desktop-schemas') {
$section = 'system';
}
- is ($$found{$key}, "$sbo_home/$section/$key",
+ is($$found{$key}, "$sbo_home/$section/$key",
'perform_search good for $search eq desktop');
}
}
@@ -289,7 +289,7 @@ for my $found (@$findings) {
# get_inst_names test
$installed = get_installed_sbos;
my $inst_names = get_inst_names $installed;
-ok ('zdoom' ~~ @$inst_names, 'get_inst_names is good');
+ok('zdoom' ~~ @$inst_names, 'get_inst_names is good');
# get_reqs tests
# $SBO::Lib::no_reqs = 0;
@@ -298,38 +298,38 @@ ok ('zdoom' ~~ @$inst_names, 'get_inst_names is good');
# 'get_requires good for circular requirements');
my $reqs = get_requires 'gmpc';#, "$sbo_home/audio/gmpc";
my $say = 'get_requires good for normal req list';
-is ($$reqs[0], 'gob2', $say);
-is ($$reqs[1], 'libmpd', $say);
-is ($$reqs[2], 'vala', $say);
+is($$reqs[0], 'gob2', $say);
+is($$reqs[1], 'libmpd', $say);
+is($$reqs[2], 'vala', $say);
$reqs = get_requires 'doomseeker';
-is ($$reqs[0], '%README%', 'get_requires good for REQUIRES="%README%"');
-is (get_requires 'krb5', undef, 'get_requires good for REQUIRES=""');
+is($$reqs[0], '%README%', 'get_requires good for REQUIRES="%README%"');
+is(get_requires 'krb5', undef, 'get_requires good for REQUIRES=""');
# get_user_group tests
$fh = open_read "$sbo_home/network/nagios/README";
my $readme = do {local $/; <$fh>};
close $fh;
my $cmds = get_user_group $readme;
-is ($$cmds[0], 'groupadd -g 213 nagios', 'get_user_group good for # groupadd');
-is ($$cmds[1], 'useradd -u 213 -d /dev/null -s /bin/false -g nagios nagios',
+is($$cmds[0], 'groupadd -g 213 nagios', 'get_user_group good for # groupadd');
+is($$cmds[1], 'useradd -u 213 -d /dev/null -s /bin/false -g nagios nagios',
'get_user_group for # useradd');
$fh = open_read "$sbo_home/network/havp/README";
$readme = do {local $/; <$fh>};
close $fh;
$cmds = get_user_group $readme;
-is ($$cmds[0], 'groupadd -g 210 clamav', 'get_user_group good for groupadd');
-is ($$cmds[1], 'useradd -u 256 -d /dev/null -s /bin/false -g clamav havp',
+is($$cmds[0], 'groupadd -g 210 clamav', 'get_user_group good for groupadd');
+is($$cmds[1], 'useradd -u 256 -d /dev/null -s /bin/false -g clamav havp',
'get_user_group good for useradd');
# get_opts test
$fh = open_read "$sbo_home/games/vbam/README";
$readme = do {local $/; <$fh>};
close $fh;
-ok (get_opts $readme, 'get_opts good where README defines opts');
+ok(get_opts $readme, 'get_opts good where README defines opts');
$fh = open_read "$sbo_home/audio/gmpc/README";
$readme = do {local $/; <$fh>};
close $fh;
-ok (! (get_opts $readme), 'get_opts good where README does not define opts');
+ok(! (get_opts $readme), 'get_opts good where README does not define opts');
# clean_reqs tests
@@ -351,16 +351,16 @@ my $warnings = {()};;
my @t_argv = ( 'zdoom', 'bsnes', 'spring', 'OpenAL' );
my $queue;
for my $sbo (@t_argv) {
- my $queue_sbo = get_build_queue ([$sbo], $warnings);
+ my $queue_sbo = get_build_queue([$sbo], $warnings);
$queue = merge_queues($queue, $queue_sbo);
}
my $count = @$queue;
-is ($count, 10, 'get_build_queue returns correct amount for multiple sbos');
-is ($$queue[0], 'p7zip', 'get_build_queue first entry correct for multiple sbos');
-is ($$queue[2], 'eawpats', 'get_build_queue third entry correct for multiple sbos');
-is ($$queue[4], 'zdoom', 'get_build_queue fifth entry correct for multiple sbos');
-is ($$queue[6], 'bsnes', 'get_build_queue seventh entry correct for multiple sbos');
-is ($$queue[8], 'DevIL', 'get_build_queue ninth entry correct for multiple sbos');
+is($count, 10, 'get_build_queue returns correct amount for multiple sbos');
+is($$queue[0], 'p7zip', 'get_build_queue first entry correct for multiple sbos');
+is($$queue[2], 'eawpats', 'get_build_queue third entry correct for multiple sbos');
+is($$queue[4], 'zdoom', 'get_build_queue fifth entry correct for multiple sbos');
+is($$queue[6], 'bsnes', 'get_build_queue seventh entry correct for multiple sbos');
+is($$queue[8], 'DevIL', 'get_build_queue ninth entry correct for multiple sbos');
# test single sbo
# sbo: zdoom
@@ -368,26 +368,26 @@ is ($$queue[8], 'DevIL', 'get_build_queue ninth entry correct for multiple sbos'
$queue = get_build_queue ['zdoom'], $warnings;
@$queue = reverse @$queue;
$count = @$queue;
-is ($count, 5, 'get_build_queue returns correct amount for single sbo');
-is ($$queue[0], 'p7zip', 'get_build_queue first entry correct for single sbo');
-is ($$queue[2], 'eawpats', 'get_build_queue third entry correct for single sbo');
-is ($$queue[4], 'zdoom', 'get_build_queue fifth entry correct for single sbo');
+is($count, 5, 'get_build_queue returns correct amount for single sbo');
+is($$queue[0], 'p7zip', 'get_build_queue first entry correct for single sbo');
+is($$queue[2], 'eawpats', 'get_build_queue third entry correct for single sbo');
+is($$queue[4], 'zdoom', 'get_build_queue fifth entry correct for single sbo');
# test get_required_by
get_reverse_reqs $inst_names;
-my $required = get_required_by 'p7zip';
-is ($$required[0], 'unetbootin', 'get_required_by good for populated req_by list');
-is ($$required[1], 'zdoom', 'get_required_by good for populated req_by list');
-is ( get_required_by 'zdoom', undef, 'get_required_by good for empty req_by list');
+my $required = get_required_by('p7zip');
+is($$required[0], 'unetbootin', 'get_required_by good for populated req_by list');
+is($$required[1], 'zdoom', 'get_required_by good for populated req_by list');
+is( get_required_by('zdoom'), undef, 'get_required_by good for empty req_by list');
# test confirm_remove
@SBO::Lib::confirmed=('p7zip', 'eawpats', 'bsnes');
confirm_remove('zdoom');
$count = @SBO::Lib::confirmed;
-is ($count, 4, 'confirm_remove good for new sbo');
+is($count, 4, 'confirm_remove good for new sbo');
confirm_remove('zdoom');
$count = @SBO::Lib::confirmed;
-is ($count, 4, 'confirm_remove good for duplicate sbo');
+is($count, 4, 'confirm_remove good for duplicate sbo');
# end of tests.
done_testing();