reduction of code for get_installed_sbos () sub.

1 files changed, 7 insertions, 9 deletions

diff --git a/SBO-Lib/lib/SBO/Lib.pm b/SBO-Lib/lib/SBO/Lib.pm
index 042a4ce..444f104 100644
--- a/SBO-Lib/lib/SBO/Lib.pm
+++ b/SBO-Lib/lib/SBO/Lib.pm
@@ -205,16 +205,14 @@ sub slackbuilds_or_fetch {
 # currently installed. starting to think it might be better to only pull an
 # array of names, and have another sub to pull the versions.
 sub get_installed_sbos {
+	my @paths = </var/log/packages/*_SBo>;
+	$_ =~ s#.*/([^/]+)$#$1#g for @paths;
 	my @installed;
-	opendir my $diread, '/var/log/packages';
-	while (my $ls = readdir $diread) {
-		next if $ls =~ /\A\./;
-		if (index ($ls, "SBo") != -1) {
-			my @split = split (/-/, reverse ($ls), 4);
-			my $name = reverse ($split[3]);
-			my $version = reverse ($split[2]);
-			push (@installed, {name => $name, version => $version} );
-		}
+	for my $path (@paths) {
+		my @split = split (/-/, reverse ($path), 4);
+		my $name = reverse ($split[3]);
+		my $version = reverse ($split[2]);
+		push (@installed, {name => $name, version => $version} );
 	}
 	return @installed;
 }