1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
|
#!/usr/bin/env python3
#
# Script to compare machine type compatible properties (include/hw/boards.h).
# compat_props are applied to the driver during initialization to change
# default values, for instance, to maintain compatibility.
# This script constructs table with machines and values of their compat_props
# to compare and to find places for improvements or places with bugs. If
# during the comparison, some machine type doesn't have a property (it is in
# the comparison table because another machine type has it), then the
# appropriate method will be used to obtain the default value of this driver
# property via qmp command (e.g. query-cpu-model-expansion for x86_64-cpu).
# These methods are defined below in qemu_property_methods.
#
# Copyright (c) Yandex Technologies LLC, 2023
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, see <http://www.gnu.org/licenses/>.
import sys
from os import path
from argparse import ArgumentParser, RawTextHelpFormatter, Namespace
import pandas as pd
from contextlib import ExitStack
from typing import Optional, List, Dict, Generator, Tuple, Union, Any, Set
try:
qemu_dir = path.abspath(path.dirname(path.dirname(__file__)))
sys.path.append(path.join(qemu_dir, 'python'))
from qemu.machine import QEMUMachine
except ModuleNotFoundError as exc:
print(f"Module '{exc.name}' not found.")
print("Try export PYTHONPATH=top-qemu-dir/python or run from top-qemu-dir")
sys.exit(1)
default_qemu_args = '-enable-kvm -machine none'
default_qemu_binary = 'build/qemu-system-x86_64'
# Methods for gettig the right values of drivers properties
#
# Use these methods as a 'whitelist' and add entries only if necessary. It's
# important to be stable and predictable in analysis and tests.
# Be careful:
# * Class must be inherited from 'QEMUObject' and used in new_driver()
# * Class has to implement get_prop method in order to get values
# * Specialization always wins (with the given classes for 'device' and
# 'x86_64-cpu', method of 'x86_64-cpu' will be used for '486-x86_64-cpu')
class Driver():
def __init__(self, vm: QEMUMachine, name: str, abstract: bool) -> None:
self.vm = vm
self.name = name
self.abstract = abstract
self.parent: Optional[Driver] = None
self.property_getter: Optional[Driver] = None
def get_prop(self, driver: str, prop: str) -> str:
if self.property_getter:
return self.property_getter.get_prop(driver, prop)
else:
return 'Unavailable method'
def is_child_of(self, parent: 'Driver') -> bool:
"""Checks whether self is (recursive) child of @parent"""
cur_parent = self.parent
while cur_parent:
if cur_parent is parent:
return True
cur_parent = cur_parent.parent
return False
def set_implementations(self, implementations: List['Driver']) -> None:
self.implementations = implementations
class QEMUObject(Driver):
def __init__(self, vm: QEMUMachine, name: str) -> None:
super().__init__(vm, name, True)
def set_implementations(self, implementations: List[Driver]) -> None:
self.implementations = implementations
# each implementation of the abstract driver has to use property getter
# of this abstract driver unless it has specialization. (e.g. having
# 'device' and 'x86_64-cpu', property getter of 'x86_64-cpu' will be
# used for '486-x86_64-cpu')
for impl in implementations:
if not impl.property_getter or\
self.is_child_of(impl.property_getter):
impl.property_getter = self
class QEMUDevice(QEMUObject):
def __init__(self, vm: QEMUMachine) -> None:
super().__init__(vm, 'device')
self.cached: Dict[str, List[Dict[str, Any]]] = {}
def get_prop(self, driver: str, prop_name: str) -> str:
if driver not in self.cached:
self.cached[driver] = self.vm.cmd('device-list-properties',
typename=driver)
for prop in self.cached[driver]:
if prop['name'] == prop_name:
return str(prop.get('default-value', 'No default value'))
return 'Unknown property'
class QEMUx86CPU(QEMUObject):
def __init__(self, vm: QEMUMachine) -> None:
super().__init__(vm, 'x86_64-cpu')
self.cached: Dict[str, Dict[str, Any]] = {}
def get_prop(self, driver: str, prop_name: str) -> str:
if not driver.endswith('-x86_64-cpu'):
return 'Wrong x86_64-cpu name'
# crop last 11 chars '-x86_64-cpu'
name = driver[:-11]
if name not in self.cached:
self.cached[name] = self.vm.cmd(
'query-cpu-model-expansion', type='full',
model={'name': name})['model']['props']
return str(self.cached[name].get(prop_name, 'Unknown property'))
# Now it's stub, because all memory_backend types don't have default values
# but this behaviour can be changed
class QEMUMemoryBackend(QEMUObject):
def __init__(self, vm: QEMUMachine) -> None:
super().__init__(vm, 'memory-backend')
self.cached: Dict[str, List[Dict[str, Any]]] = {}
def get_prop(self, driver: str, prop_name: str) -> str:
if driver not in self.cached:
self.cached[driver] = self.vm.cmd('qom-list-properties',
typename=driver)
for prop in self.cached[driver]:
if prop['name'] == prop_name:
return str(prop.get('default-value', 'No default value'))
return 'Unknown property'
def new_driver(vm: QEMUMachine, name: str, is_abstr: bool) -> Driver:
if name == 'object':
return QEMUObject(vm, 'object')
elif name == 'device':
return QEMUDevice(vm)
elif name == 'x86_64-cpu':
return QEMUx86CPU(vm)
elif name == 'memory-backend':
return QEMUMemoryBackend(vm)
else:
return Driver(vm, name, is_abstr)
# End of methods definition
class VMPropertyGetter:
"""It implements the relationship between drivers and how to get their
properties"""
def __init__(self, vm: QEMUMachine) -> None:
self.drivers: Dict[str, Driver] = {}
qom_all_types = vm.cmd('qom-list-types', abstract=True)
self.drivers = {t['name']: new_driver(vm, t['name'],
t.get('abstract', False))
for t in qom_all_types}
for t in qom_all_types:
drv = self.drivers[t['name']]
if 'parent' in t:
drv.parent = self.drivers[t['parent']]
for drv in self.drivers.values():
imps = vm.cmd('qom-list-types', implements=drv.name)
# only implementations inherit property getter
drv.set_implementations([self.drivers[imp['name']]
for imp in imps])
def get_prop(self, driver: str, prop: str) -> str:
# wrong driver name or disabled in config driver
try:
drv = self.drivers[driver]
except KeyError:
return 'Unavailable driver'
assert not drv.abstract
return drv.get_prop(driver, prop)
def get_implementations(self, driver: str) -> List[str]:
return [impl.name for impl in self.drivers[driver].implementations]
class Machine:
"""A short QEMU machine type description. It contains only processed
compat_props (properties of abstract classes are applied to its
implementations)
"""
# raw_mt_dict - dict produced by `query-machines`
def __init__(self, raw_mt_dict: Dict[str, Any],
qemu_drivers: VMPropertyGetter) -> None:
self.name = raw_mt_dict['name']
self.compat_props: Dict[str, Any] = {}
# properties are applied sequentially and can rewrite values like in
# QEMU. Also it has to resolve class relationships to apply appropriate
# values from abstract class to all implementations
for prop in raw_mt_dict['compat-props']:
driver = prop['qom-type']
try:
# implementation adds only itself, abstract class adds
# lementation (abstract classes are uninterestiong)
impls = qemu_drivers.get_implementations(driver)
for impl in impls:
if impl not in self.compat_props:
self.compat_props[impl] = {}
self.compat_props[impl][prop['property']] = prop['value']
except KeyError:
# QEMU doesn't know this driver thus it has to be saved
if driver not in self.compat_props:
self.compat_props[driver] = {}
self.compat_props[driver][prop['property']] = prop['value']
class Configuration():
"""Class contains all necessary components to generate table and is used
to compare different binaries"""
def __init__(self, vm: QEMUMachine,
req_mt: List[str], all_mt: bool) -> None:
self._vm = vm
self._binary = vm.binary
self._qemu_args = args.qemu_args.split(' ')
self._qemu_drivers = VMPropertyGetter(vm)
self.req_mt = get_req_mt(self._qemu_drivers, vm, req_mt, all_mt)
def get_implementations(self, driver_name: str) -> List[str]:
return self._qemu_drivers.get_implementations(driver_name)
def get_table(self, req_props: List[Tuple[str, str]]) -> pd.DataFrame:
table: List[pd.DataFrame] = []
for mt in self.req_mt:
name = f'{self._binary}\n{mt.name}'
column = []
for driver, prop in req_props:
try:
# values from QEMU machine type definitions
column.append(mt.compat_props[driver][prop])
except KeyError:
# values from QEMU type definitions
column.append(self._qemu_drivers.get_prop(driver, prop))
table.append(pd.DataFrame({name: column}))
return pd.concat(table, axis=1)
script_desc = """Script to compare machine types (their compat_props).
Examples:
* save info about all machines: ./scripts/compare-machine-types.py --all \
--format csv --raw > table.csv
* compare machines: ./scripts/compare-machine-types.py --mt pc-q35-2.12 \
pc-q35-3.0
* compare binaries and machines: ./scripts/compare-machine-types.py \
--mt pc-q35-6.2 pc-q35-7.0 --qemu-binary build/qemu-system-x86_64 \
build/qemu-exp
╒════════════╤══════════════════════════╤════════════════════════════\
╤════════════════════════════╤══════════════════╤══════════════════╕
│ Driver │ Property │ build/qemu-system-x86_64 \
│ build/qemu-system-x86_64 │ build/qemu-exp │ build/qemu-exp │
│ │ │ pc-q35-6.2 \
│ pc-q35-7.0 │ pc-q35-6.2 │ pc-q35-7.0 │
╞════════════╪══════════════════════════╪════════════════════════════\
╪════════════════════════════╪══════════════════╪══════════════════╡
│ PIIX4_PM │ x-not-migrate-acpi-index │ True \
│ False │ False │ False │
├────────────┼──────────────────────────┼────────────────────────────\
┼────────────────────────────┼──────────────────┼──────────────────┤
│ virtio-mem │ unplugged-inaccessible │ False \
│ auto │ False │ auto │
╘════════════╧══════════════════════════╧════════════════════════════\
╧════════════════════════════╧══════════════════╧══════════════════╛
If a property from QEMU machine defintion applies to an abstract class (e.g. \
x86_64-cpu) this script will compare all implementations of this class.
"Unavailable method" - means that this script doesn't know how to get \
default values of the driver. To add method use the construction described \
at the top of the script.
"Unavailable driver" - means that this script doesn't know this driver. \
For instance, this can happen if you configure QEMU without this device or \
if machine type definition has error.
"No default value" - means that the appropriate method can't get the default \
value and most likely that this property doesn't have it.
"Unknown property" - means that the appropriate method can't find property \
with this name."""
def parse_args() -> Namespace:
parser = ArgumentParser(formatter_class=RawTextHelpFormatter,
description=script_desc)
parser.add_argument('--format', choices=['human-readable', 'json', 'csv'],
default='human-readable',
help='returns table in json format')
parser.add_argument('--raw', action='store_true',
help='prints ALL defined properties without value '
'transformation. By default, only rows '
'with different values will be printed and '
'values will be transformed(e.g. "on" -> True)')
parser.add_argument('--qemu-args', default=default_qemu_args,
help='command line to start qemu. '
f'Default: "{default_qemu_args}"')
parser.add_argument('--qemu-binary', nargs="*", type=str,
default=[default_qemu_binary],
help='list of qemu binaries that will be compared. '
f'Deafult: {default_qemu_binary}')
mt_args_group = parser.add_mutually_exclusive_group()
mt_args_group.add_argument('--all', action='store_true',
help='prints all available machine types (list '
'of machine types will be ignored)')
mt_args_group.add_argument('--mt', nargs="*", type=str,
help='list of Machine Types '
'that will be compared')
return parser.parse_args()
def mt_comp(mt: Machine) -> Tuple[str, int, int, int]:
"""Function to compare and sort machine by names.
It returns socket_name, major version, minor version, revision"""
# none, microvm, x-remote and etc.
if '-' not in mt.name or '.' not in mt.name:
return mt.name, 0, 0, 0
socket, ver = mt.name.rsplit('-', 1)
ver_list = list(map(int, ver.split('.', 2)))
ver_list += [0] * (3 - len(ver_list))
return socket, ver_list[0], ver_list[1], ver_list[2]
def get_mt_definitions(qemu_drivers: VMPropertyGetter,
vm: QEMUMachine) -> List[Machine]:
"""Constructs list of machine definitions (primarily compat_props) via
info from QEMU"""
raw_mt_defs = vm.cmd('query-machines', compat_props=True)
mt_defs = []
for raw_mt in raw_mt_defs:
mt_defs.append(Machine(raw_mt, qemu_drivers))
mt_defs.sort(key=mt_comp)
return mt_defs
def get_req_mt(qemu_drivers: VMPropertyGetter, vm: QEMUMachine,
req_mt: Optional[List[str]], all_mt: bool) -> List[Machine]:
"""Returns list of requested by user machines"""
mt_defs = get_mt_definitions(qemu_drivers, vm)
if all_mt:
return mt_defs
if req_mt is None:
print('Enter machine types for comparision')
exit(0)
matched_mt = []
for mt in mt_defs:
if mt.name in req_mt:
matched_mt.append(mt)
return matched_mt
def get_affected_props(configs: List[Configuration]) -> Generator[Tuple[str,
str],
None, None]:
"""Helps to go through all affected in machine definitions drivers
and properties"""
driver_props: Dict[str, Set[Any]] = {}
for config in configs:
for mt in config.req_mt:
compat_props = mt.compat_props
for driver, prop in compat_props.items():
if driver not in driver_props:
driver_props[driver] = set()
driver_props[driver].update(prop.keys())
for driver, props in sorted(driver_props.items()):
for prop in sorted(props):
yield driver, prop
def transform_value(value: str) -> Union[str, bool]:
true_list = ['true', 'on']
false_list = ['false', 'off']
out = value.lower()
if out in true_list:
return True
if out in false_list:
return False
return value
def simplify_table(table: pd.DataFrame) -> pd.DataFrame:
"""transforms values to make it easier to compare it and drops rows
with the same values for all columns"""
table = table.map(transform_value)
return table[~table.iloc[:, 3:].eq(table.iloc[:, 2], axis=0).all(axis=1)]
# constructs table in the format:
#
# Driver | Property | binary1 | binary1 | ...
# | | machine1 | machine2 | ...
# ------------------------------------------------------ ...
# driver1 | property1 | value1 | value2 | ...
# driver1 | property2 | value3 | value4 | ...
# driver2 | property3 | value5 | value6 | ...
# ... | ... | ... | ... | ...
#
def fill_prop_table(configs: List[Configuration],
is_raw: bool) -> pd.DataFrame:
req_props = list(get_affected_props(configs))
if not req_props:
print('No drivers to compare. Check machine names')
exit(0)
driver_col, prop_col = tuple(zip(*req_props))
table = [pd.DataFrame({'Driver': driver_col}),
pd.DataFrame({'Property': prop_col})]
table.extend([config.get_table(req_props) for config in configs])
df_table = pd.concat(table, axis=1)
if is_raw:
return df_table
return simplify_table(df_table)
def print_table(table: pd.DataFrame, table_format: str) -> None:
if table_format == 'json':
print(comp_table.to_json())
elif table_format == 'csv':
print(comp_table.to_csv())
else:
print(comp_table.to_markdown(index=False, stralign='center',
colalign=('center',), headers='keys',
tablefmt='fancy_grid',
disable_numparse=True))
if __name__ == '__main__':
args = parse_args()
with ExitStack() as stack:
vms = [stack.enter_context(QEMUMachine(binary=binary, qmp_timer=15,
args=args.qemu_args.split(' '))) for binary in args.qemu_binary]
configurations = []
for vm in vms:
vm.launch()
configurations.append(Configuration(vm, args.mt, args.all))
comp_table = fill_prop_table(configurations, args.raw)
if not comp_table.empty:
print_table(comp_table, args.format)
|