aboutsummaryrefslogtreecommitdiff
path: root/ui
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2024-10-08 16:50:12 +0400
committerMichael Tokarev <mjt@tls.msk.ru>2024-11-08 13:02:57 +0300
commit63b32ce87e6c3e71719a6a9f6f4089059c45f487 (patch)
treea5ad092dc099eaeabc475777093950b2cfaec9ce /ui
parentc385420aaffcf2ee9a2ac11dd8a4be04e5d3d24a (diff)
ui/dbus: fix leak on message filtering
A filter function that wants to drop a message should return NULL, in which case it must also unref the message itself. Fixes: fa88b85de ("ui/dbus: filter out pending messages when scanout") Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com> Message-ID: <20241008125028.1177932-4-marcandre.lureau@redhat.com> (cherry picked from commit 244d52ff736fefc3dd364ed091720aa896af306d) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'ui')
-rw-r--r--ui/dbus-listener.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
index 4a0a5d78f9..83140f602d 100644
--- a/ui/dbus-listener.c
+++ b/ui/dbus-listener.c
@@ -996,6 +996,7 @@ dbus_filter(GDBusConnection *connection,
serial = g_dbus_message_get_serial(message);
if (serial <= ddl->out_serial_to_discard) {
trace_dbus_filter(serial, ddl->out_serial_to_discard);
+ g_object_unref(message);
return NULL;
}