diff options
author | Thomas Huth <thuth@redhat.com> | 2016-04-14 17:14:53 +0200 |
---|---|---|
committer | David Gibson <david@gibson.dropbear.id.au> | 2016-04-18 15:14:38 +1000 |
commit | 537d3e8e6beea9a0fbd6469eb38450e718244dad (patch) | |
tree | 89b8bd2b951197ebc8d5500168518422f41cb6ae /translate-all.c | |
parent | afbee7128c2399b6fca7b744ee560e3a1851118e (diff) |
ppc: Fix the bad exception NIP value and the range check in LSWX
The range checks in the LSWX instruction are completely insufficient:
They do not take the wrap-around case into account, and the check
"reg < rx" should be "reg <= rx" instead. Fix it by using the new
lsw_reg_in_range() helper function that is already used for LSWI, too.
Then there is a second problem: In case the INVAL exception is generated,
the NIP value is wrong, it currently points to the instruction before
the LSWX instruction. This is because gen_lswx() already decreases the
NIP value by 4 (to be prepared for page fault exceptions), and
powerpc_excp() later decreases it again by 4 while handling the program
exception. So to get this right, we've got to undo the "- 4" from
gen_lswx() here before calling helper_raise_exception_err().
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'translate-all.c')
0 files changed, 0 insertions, 0 deletions