diff options
| author | John Snow <jsnow@redhat.com> | 2021-10-26 13:56:05 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2021-11-01 11:54:59 -0400 |
| commit | b9420e4f4b899c96221fa5a1f7f025214e756c50 (patch) | |
| tree | bf744d81f87511a55c776f29e94ac89e4525a28b /tests/qemu-iotests/218 | |
| parent | 461044ceb4fe58eb919dedfeb62f619f79d4d552 (diff) | |
python/machine: remove has_quit argument
If we spy on the QMP commands instead, we don't need callers to remember
to pass it. Seems like a fair trade-off.
The one slightly weird bit is overloading this instance variable for
wait(), where we use it to mean "don't issue the qmp 'quit'
command". This means that wait() will "fail" if the QEMU process does
not terminate of its own accord.
In most cases, we probably did already actually issue quit -- some
iotests do this -- but in some others, we may be waiting for QEMU to
terminate for some other reason, such as a test wherein we tell the
guest (directly) to shut down.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20211026175612.4127598-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/218')
| -rwxr-xr-x | tests/qemu-iotests/218 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/218 b/tests/qemu-iotests/218 index 325d8244fb..4922b4d3b6 100755 --- a/tests/qemu-iotests/218 +++ b/tests/qemu-iotests/218 @@ -187,4 +187,4 @@ with iotests.VM() as vm, \ log(vm.qmp('quit')) with iotests.Timeout(5, 'Timeout waiting for VM to quit'): - vm.shutdown(has_quit=True) + vm.shutdown() |