aboutsummaryrefslogtreecommitdiff
path: root/tests/qapi-schema/args-union.json
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2015-07-01 10:12:24 +0200
committerMarkus Armbruster <armbru@redhat.com>2015-09-04 15:47:15 +0200
commit315932b5edb86597adafbd1faa2d29c46499d8c3 (patch)
tree4d60c9b364e460937ee0e7fc953835f2d8ed07f7 /tests/qapi-schema/args-union.json
parentd9658d58e33128df32093b7a84bed76b527fb884 (diff)
qapi: Fix to reject union command and event arguments
A command's or event's 'data' must be a struct type, given either as a dictionary, or as struct type name. Commit dd883c6 tightened the checking there, but not enough: we still accept 'union'. Fix to reject it. We may want to support union types there, but we'll have to extend qapi-commands.py and qapi-events.py for it. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'tests/qapi-schema/args-union.json')
-rw-r--r--tests/qapi-schema/args-union.json2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qapi-schema/args-union.json b/tests/qapi-schema/args-union.json
index db97ef643b..7bdcbb7f08 100644
--- a/tests/qapi-schema/args-union.json
+++ b/tests/qapi-schema/args-union.json
@@ -1,4 +1,4 @@
-# FIXME we should reject union arguments
+# we do not allow union arguments
# TODO should we support this?
{ 'union': 'Uni', 'data': { 'case1': 'int', 'case2': 'str' } }
{ 'command': 'oops', 'data': 'Uni' }