diff options
author | Fam Zheng <famz@redhat.com> | 2015-06-08 13:56:10 +0800 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2015-07-02 10:06:23 +0100 |
commit | 508249952c0ea7472c62e17bf8132295dab4912d (patch) | |
tree | 0097014b93cf0e14fe7208b1c1d2123f3201f07c /target-unicore32 | |
parent | dcfb3beb5130694b76b57de109619fcbf9c7e5b5 (diff) |
block: Fix dirty bitmap in bdrv_co_discard
Unsetting dirty globally with discard is not very correct. The discard may zero
out sectors (depending on can_write_zeroes_with_unmap), we should replicate
this change to destination side to make sure that the guest sees the same data.
Calling bdrv_reset_dirty also troubles mirror job because the hbitmap iterator
doesn't expect unsetting of bits after current position.
So let's do it the opposite way which fixes both problems: set the dirty bits
if we are to discard it.
Reported-by: wangxiaolong@ucloud.cn
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'target-unicore32')
0 files changed, 0 insertions, 0 deletions