aboutsummaryrefslogtreecommitdiff
path: root/replication.c
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2020-05-14 00:57:00 +0200
committerDavid Gibson <david@gibson.dropbear.id.au>2020-05-27 15:29:36 +1000
commit7caee782e996988d5d178ed0838e73781f608ae1 (patch)
treeac349b5c93455a784ffe239ba052431d34a55ee5 /replication.c
parent1830422611806abba07694605e933a566d634eec (diff)
target/ppc: Don't initialize some local variables in ppc_radix64_xlate()
It is the job of the ppc_radix64_get_fully_qualified_addr() function which is called at the beginning of ppc_radix64_xlate() to set both lpid *and* pid. It doesn't buy us anything to initialize them first. Worse, a bug in ppc_radix64_get_fully_qualified_addr(), eg. failing to set either lpid or pid, would be undetectable by static analysis tools like coverity. Some recent versions of gcc (eg. gcc-9.3.1-2.fc30) may still think that lpid or pid is used uninitialized though, so this also adds default cases in the switch statements to make it clear this cannot happen. Signed-off-by: Greg Kurz <groug@kaod.org> Message-Id: <158941062048.240484.9693581559252337111.stgit@bahia.lan> Reviewed-by: Cédric Le Goater <clg@kaod.org> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'replication.c')
0 files changed, 0 insertions, 0 deletions