diff options
| author | Alexey Kardashevskiy <aik@ozlabs.ru> | 2014-10-09 13:50:46 +1100 |
|---|---|---|
| committer | Juan Quintela <quintela@trasno.org> | 2014-10-14 09:35:21 +0200 |
| commit | 7ea2d269cb84ca7a2f4b7c3735634176f7c1dc35 (patch) | |
| tree | 7db382cb3a25419bfafdfa8bfa8f8f248debe1bd /migration.c | |
| parent | 9935baca9b3573dfdb19aff03b3cbe1116350400 (diff) | |
block/migration: Disable cache invalidate for incoming migration
When migrated using libvirt with "--copy-storage-all", at the end of
migration there is race between NBD mirroring task trying to do flush
and migration completion, both end up invalidating cache. Since qcow2
driver does not handle this situation very well, random crashes happen.
This disables the BDRV_O_INCOMING flag for the block device being migrated
once the cache has been invalidated.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
--
fixed parens by hand
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration.c')
| -rw-r--r-- | migration.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/migration.c b/migration.c index 8d675b31a1..c49a05a165 100644 --- a/migration.c +++ b/migration.c @@ -103,7 +103,6 @@ static void process_incoming_migration_co(void *opaque) } qemu_announce_self(); - bdrv_clear_incoming_migration_all(); /* Make sure all file formats flush their mutable metadata */ bdrv_invalidate_cache_all(&local_err); if (local_err) { |