From 7ea2d269cb84ca7a2f4b7c3735634176f7c1dc35 Mon Sep 17 00:00:00 2001 From: Alexey Kardashevskiy Date: Thu, 9 Oct 2014 13:50:46 +1100 Subject: block/migration: Disable cache invalidate for incoming migration When migrated using libvirt with "--copy-storage-all", at the end of migration there is race between NBD mirroring task trying to do flush and migration completion, both end up invalidating cache. Since qcow2 driver does not handle this situation very well, random crashes happen. This disables the BDRV_O_INCOMING flag for the block device being migrated once the cache has been invalidated. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Paolo Bonzini -- fixed parens by hand Signed-off-by: Juan Quintela --- migration.c | 1 - 1 file changed, 1 deletion(-) (limited to 'migration.c') diff --git a/migration.c b/migration.c index 8d675b31a1..c49a05a165 100644 --- a/migration.c +++ b/migration.c @@ -103,7 +103,6 @@ static void process_incoming_migration_co(void *opaque) } qemu_announce_self(); - bdrv_clear_incoming_migration_all(); /* Make sure all file formats flush their mutable metadata */ bdrv_invalidate_cache_all(&local_err); if (local_err) { -- cgit v1.2.3