diff options
| author | Peter Xu <peterx@redhat.com> | 2024-06-17 15:57:20 -0300 |
|---|---|---|
| committer | Fabiano Rosas <farosas@suse.de> | 2024-06-20 10:42:24 -0300 |
| commit | 1cd93fb0bf8b1fddab4c38e17145cc8776eadaa0 (patch) | |
| tree | f09602edbb8ff11353ffb618095eec870bc6af33 /include/monitor | |
| parent | 926554c0bfdfbf7b058ed370c2b484e56b126d34 (diff) | |
monitor: Drop monitor_fdset_dup_fd_find/_remove()
Those functions are not needed, one remove function should already
work. Clean it up.
Here the code doesn't really care about whether we need to keep that dupfd
around if close() failed: when that happens something got very wrong,
keeping the dup_fd around the fdsets may not help that situation so far.
Cc: Dr. David Alan Gilbert <dave@treblig.org>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
[add missing return statement, removal during traversal is not safe]
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Diffstat (limited to 'include/monitor')
| -rw-r--r-- | include/monitor/monitor.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index 965f5d5450..fd9b3f538c 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -53,7 +53,6 @@ AddfdInfo *monitor_fdset_add_fd(int fd, bool has_fdset_id, int64_t fdset_id, const char *opaque, Error **errp); int monitor_fdset_dup_fd_add(int64_t fdset_id, int flags); void monitor_fdset_dup_fd_remove(int dup_fd); -int64_t monitor_fdset_dup_fd_find(int dup_fd); void monitor_register_hmp(const char *name, bool info, void (*cmd)(Monitor *mon, const QDict *qdict)); |