diff options
| author | Pierrick Bouvier <pierrick.bouvier@linaro.org> | 2024-09-10 15:15:54 -0700 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-09-13 20:12:16 +0200 |
| commit | 7185eb7e63b22bbf485fbcd0d1e046a633b9019b (patch) | |
| tree | f4e6cd98d5f95fcec3fd66802667bc0466fdef9a /hw/gpio/nrf51_gpio.c | |
| parent | 74ee21a84b4a39763f2f866d077c26ea3c78e117 (diff) | |
hw/gpio: remove break after g_assert_not_reached()
Use of assert(false) can trip spurious control flow warnings from
some versions of GCC (i.e. using -fsanitize=thread with gcc-12):
error: control reaches end of non-void function [-Werror=return-type]
default:
g_assert_not_reached();
break;
| ^^^^^
Solve that by removing the unreachable 'break' statement, unifying
the code base on g_assert_not_reached() instead.
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240910221606.1817478-28-pierrick.bouvier@linaro.org>
[PMD: Add description suggested by Eric Blake]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'hw/gpio/nrf51_gpio.c')
| -rw-r--r-- | hw/gpio/nrf51_gpio.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/gpio/nrf51_gpio.c b/hw/gpio/nrf51_gpio.c index 0eed3a3a06..d08c254e36 100644 --- a/hw/gpio/nrf51_gpio.c +++ b/hw/gpio/nrf51_gpio.c @@ -40,7 +40,6 @@ static bool is_connected(uint32_t config, uint32_t level) break; default: g_assert_not_reached(); - break; } return state; |