diff options
| author | Roman Penyaev <r.peniaev@gmail.com> | 2024-10-14 17:24:01 +0200 |
|---|---|---|
| committer | Marc-André Lureau <marcandre.lureau@redhat.com> | 2024-10-15 12:26:01 +0400 |
| commit | df12798f8791a929f4d7309f67a0f437c608e7fb (patch) | |
| tree | 0bcef947c2f77dd5db822a084a376ad98cbfc8f5 /chardev | |
| parent | aa54f5be44be786636a5d51cc1612ad208a24849 (diff) | |
chardev/char: fix qemu_chr_is_busy() check
`mux_cnt` struct member never goes negative or decrements,
so mux chardev can be !busy only when there are no
frontends attached. This patch fixes the always-true
check.
Fixes: a4afa548fc6d ("char: move front end handlers in CharBackend")
Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20241014152408.427700-2-r.peniaev@gmail.com>
Diffstat (limited to 'chardev')
| -rw-r--r-- | chardev/char.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chardev/char.c b/chardev/char.c index c0cc52824b..f54dc3a862 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -333,7 +333,7 @@ static bool qemu_chr_is_busy(Chardev *s) { if (CHARDEV_IS_MUX(s)) { MuxChardev *d = MUX_CHARDEV(s); - return d->mux_cnt >= 0; + return d->mux_cnt > 0; } else { return s->be != NULL; } |