diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> | 2023-05-10 18:06:21 +0300 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-05-19 19:12:12 +0200 |
| commit | 30c96b555974ed0341b3c374b20a26242f1de239 (patch) | |
| tree | fe8e212cc4bde94481bcba920109601446d3283f /blockdev.c | |
| parent | 240396965fc653756aed90edc2985f05783c5ad6 (diff) | |
blockdev: qmp_transaction: refactor loop to classic for
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230510150624.310640-4-vsementsov@yandex-team.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/blockdev.c b/blockdev.c index 75e313f403..dd0e98bbe1 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2377,7 +2377,7 @@ void qmp_transaction(TransactionActionList *actions, struct TransactionProperties *properties, Error **errp) { - TransactionActionList *act = actions; + TransactionActionList *act; bool has_properties = !!properties; JobTxn *block_job_txn = NULL; Error *local_err = NULL; @@ -2397,14 +2397,11 @@ void qmp_transaction(TransactionActionList *actions, bdrv_drain_all(); /* We don't do anything in this loop that commits us to the operations */ - while (NULL != act) { - TransactionAction *dev_info = NULL; + for (act = actions; act; act = act->next) { + TransactionAction *dev_info = act->value; const BlkActionOps *ops; BlkActionState *state; - dev_info = act->value; - act = act->next; - assert(dev_info->type < ARRAY_SIZE(actions_map)); ops = &actions_map[dev_info->type]; |