diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2023-08-30 18:48:01 -0400 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2023-09-07 20:32:11 -0500 |
| commit | acd4be64b865e81094c690503b4f39804eb67a0b (patch) | |
| tree | 4a95a21cf10a963e247cfaf5101e1de84b7e1f97 | |
| parent | 078c8adaa61df4fe081660f0c14ce35ddd938de0 (diff) | |
io: check there are no qio_channel_yield() coroutines during ->finalize()
Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.
This patch is preparation for the fd handler changes that follow.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-ID: <20230830224802.493686-4-stefanha@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
| -rw-r--r-- | io/channel.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/io/channel.c b/io/channel.c index 72f0066af5..c415f3fc88 100644 --- a/io/channel.c +++ b/io/channel.c @@ -653,6 +653,10 @@ static void qio_channel_finalize(Object *obj) { QIOChannel *ioc = QIO_CHANNEL(obj); + /* Must not have coroutines in qio_channel_yield() */ + assert(!ioc->read_coroutine); + assert(!ioc->write_coroutine); + g_free(ioc->name); #ifdef _WIN32 |