aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKamil Szczęk <kamil@szczek.dev>2024-08-20 23:11:24 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2024-11-19 17:36:28 +0100
commit4a7a119b91eedd16f52001b50df0fd5c223ada08 (patch)
tree4f8a107f6d8381c28f93f82e0228335b8e36c6c8
parente6459afb1ff4d86b361b14f4a2fc43f0d2b4d679 (diff)
hw/i386/pc: Remove vmport value assertion
There is no need for this assertion here, as we only use vmport value for equality/inequality checks. This was originally prompted by the following Coverity report: >>> CID 1559533: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "pcms->vmport >= 0" is always true regardless of the values of >>> its operands. This occurs as the logical first operand of "&&". Signed-off-by: Kamil Szczęk <kamil@szczek.dev> Reported-By: Philippe Mathieu-Daudé <philmd@linaro.org> Link: https://lore.kernel.org/r/ZwF9ZexNs1h-uC0MrbkgGtMtdyLinROjVSmMNVzNftjGVWgOiuzdD1dSXEtzNH7OHbBFY6GVDYVFIDBgc3lhGqCOb7kaNZolSBkVyl3rNr4=@szczek.dev Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--hw/i386/pc.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f9147fecbd..317aaca25a 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1228,7 +1228,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
isa_realize_and_unref(pcms->pcspk, isa_bus, &error_fatal);
}
- assert(pcms->vmport >= 0 && pcms->vmport < ON_OFF_AUTO__MAX);
if (pcms->vmport == ON_OFF_AUTO_AUTO) {
pcms->vmport = (xen_enabled() || !pcms->i8042_enabled)
? ON_OFF_AUTO_OFF : ON_OFF_AUTO_ON;