aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAkihiko Odaki <akihiko.odaki@daynix.com>2024-06-29 15:24:47 +0900
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2024-07-02 06:58:48 +0200
commit3bf445fbb199676a516202677acda38015fc51a1 (patch)
treee24ebc6c2226d313cd87ade7014d4f16f9e4642c
parente9c9d8dc3ba993384bc9553b617120ad4717345c (diff)
net/vmnet: Drop ifdef for macOS versions older than 12.0
macOS versions older than 12.0 are no longer supported. docs/about/build-platforms.rst says: > Support for the previous major version will be dropped 2 years after > the new major version is released or when the vendor itself drops > support, whichever comes first. macOS 12.0 was released 2021: https://www.apple.com/newsroom/2021/10/macos-monterey-is-now-available/ Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20240629-macos-v1-4-6e70a6b700a0@daynix.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-rw-r--r--net/vmnet-bridged.m13
-rw-r--r--net/vmnet-common.m3
-rw-r--r--net/vmnet-host.c24
-rw-r--r--net/vmnet-shared.c13
4 files changed, 2 insertions, 51 deletions
diff --git a/net/vmnet-bridged.m b/net/vmnet-bridged.m
index 76a28abe79..a04a14fa11 100644
--- a/net/vmnet-bridged.m
+++ b/net/vmnet-bridged.m
@@ -88,15 +88,6 @@ static bool validate_options(const Netdev *netdev, Error **errp)
return false;
}
-#if !defined(MAC_OS_VERSION_11_0) || \
- MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_VERSION_11_0
- if (options->has_isolated) {
- error_setg(errp,
- "vmnet-bridged.isolated feature is "
- "unavailable: outdated vmnet.framework API");
- return false;
- }
-#endif
return true;
}
@@ -115,12 +106,10 @@ static xpc_object_t build_if_desc(const Netdev *netdev)
vmnet_shared_interface_name_key,
options->ifname);
-#if defined(MAC_OS_VERSION_11_0) && \
- MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
xpc_dictionary_set_bool(if_desc,
vmnet_enable_isolation_key,
options->isolated);
-#endif
+
return if_desc;
}
diff --git a/net/vmnet-common.m b/net/vmnet-common.m
index 2958283485..30c4e53c13 100644
--- a/net/vmnet-common.m
+++ b/net/vmnet-common.m
@@ -47,11 +47,8 @@ const char *vmnet_status_map_str(vmnet_return_t status)
return "buffers exhausted in kernel";
case VMNET_TOO_MANY_PACKETS:
return "packet count exceeds limit";
-#if defined(MAC_OS_VERSION_11_0) && \
- MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
case VMNET_SHARING_SERVICE_BUSY:
return "conflict, sharing service is in use";
-#endif
default:
return "unknown vmnet error";
}
diff --git a/net/vmnet-host.c b/net/vmnet-host.c
index 1f95f7343a..49fb25c224 100644
--- a/net/vmnet-host.c
+++ b/net/vmnet-host.c
@@ -21,31 +21,13 @@
static bool validate_options(const Netdev *netdev, Error **errp)
{
const NetdevVmnetHostOptions *options = &(netdev->u.vmnet_host);
-
-#if defined(MAC_OS_VERSION_11_0) && \
- MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
-
QemuUUID net_uuid;
+
if (options->net_uuid &&
qemu_uuid_parse(options->net_uuid, &net_uuid) < 0) {
error_setg(errp, "Invalid UUID provided in 'net-uuid'");
return false;
}
-#else
- if (options->has_isolated) {
- error_setg(errp,
- "vmnet-host.isolated feature is "
- "unavailable: outdated vmnet.framework API");
- return false;
- }
-
- if (options->net_uuid) {
- error_setg(errp,
- "vmnet-host.net-uuid feature is "
- "unavailable: outdated vmnet.framework API");
- return false;
- }
-#endif
if ((options->start_address ||
options->end_address ||
@@ -71,9 +53,6 @@ static xpc_object_t build_if_desc(const Netdev *netdev)
vmnet_operation_mode_key,
VMNET_HOST_MODE);
-#if defined(MAC_OS_VERSION_11_0) && \
- MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
-
xpc_dictionary_set_bool(if_desc,
vmnet_enable_isolation_key,
options->isolated);
@@ -85,7 +64,6 @@ static xpc_object_t build_if_desc(const Netdev *netdev)
vmnet_network_identifier_key,
net_uuid.data);
}
-#endif
if (options->start_address) {
xpc_dictionary_set_string(if_desc,
diff --git a/net/vmnet-shared.c b/net/vmnet-shared.c
index 40c7306a75..4726b07253 100644
--- a/net/vmnet-shared.c
+++ b/net/vmnet-shared.c
@@ -21,16 +21,6 @@ static bool validate_options(const Netdev *netdev, Error **errp)
{
const NetdevVmnetSharedOptions *options = &(netdev->u.vmnet_shared);
-#if !defined(MAC_OS_VERSION_11_0) || \
- MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_VERSION_11_0
- if (options->has_isolated) {
- error_setg(errp,
- "vmnet-shared.isolated feature is "
- "unavailable: outdated vmnet.framework API");
- return false;
- }
-#endif
-
if ((options->start_address ||
options->end_address ||
options->subnet_mask) &&
@@ -76,14 +66,11 @@ static xpc_object_t build_if_desc(const Netdev *netdev)
options->subnet_mask);
}
-#if defined(MAC_OS_VERSION_11_0) && \
- MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
xpc_dictionary_set_bool(
if_desc,
vmnet_enable_isolation_key,
options->isolated
);
-#endif
return if_desc;
}