diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2024-07-29 15:44:11 +0100 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2024-07-30 11:44:18 +0100 |
| commit | 33ef9cdc289480bbc87fa3ee74c1398848f4e38c (patch) | |
| tree | 437a992c8d4733ca651fee2de4ade40d7f28e83c | |
| parent | 6484a3e55bdb3b44a86c4034307efd930778cd5a (diff) | |
contrib/plugins/cache.c: Remove redundant check of l2_access
In append_stats_line(), we have an expression
l2_access ? l2_miss_rate : 0.0
But this is inside an if (l2_access && l2_misses) { ... } block,
so Coverity points out that the false part of the ?: is dead code.
Remove the unnecessary test.
Resolves: Coverity CID 1522458
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240725164851.1930964-1-peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240729144414.830369-12-alex.bennee@linaro.org>
| -rw-r--r-- | contrib/plugins/cache.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/plugins/cache.c b/contrib/plugins/cache.c index c5c8ac75a9..512ef6776b 100644 --- a/contrib/plugins/cache.c +++ b/contrib/plugins/cache.c @@ -558,7 +558,7 @@ static void append_stats_line(GString *line, " %-12" PRIu64 " %-11" PRIu64 " %10.4lf%%", l2_access, l2_misses, - l2_access ? l2_miss_rate : 0.0); + l2_miss_rate); } g_string_append(line, "\n"); |