diff options
| author | Andrew Jeffery <andrew@aj.id.au> | 2021-09-20 08:50:59 +0200 |
|---|---|---|
| committer | Cédric Le Goater <clg@kaod.org> | 2021-09-20 08:50:59 +0200 |
| commit | 0c33a48df4560b2c967a19b53b8e2a1c95c8483d (patch) | |
| tree | 9c24bbfbe0bb1c8f67df9f69f00db878d20a8e38 | |
| parent | 98edb134c35cdae0e7a2de328aa92c5efff42489 (diff) | |
misc/pca9552: Fix LED status register indexing in pca955x_get_led()
There was a bit of a thinko in the state calculation where every odd pin
in was reported in e.g. "pwm0" mode rather than "off". This was the
result of an incorrect bit shift for the 2-bit field representing each
LED state.
Fixes: a90d8f84674d ("misc/pca9552: Add qom set and get")
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20210723043624.348158-1-andrew@aj.id.au>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
| -rw-r--r-- | hw/misc/pca9552.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/misc/pca9552.c b/hw/misc/pca9552.c index b7686e27d7..fff19e369a 100644 --- a/hw/misc/pca9552.c +++ b/hw/misc/pca9552.c @@ -272,7 +272,7 @@ static void pca955x_get_led(Object *obj, Visitor *v, const char *name, * reading the INPUTx reg */ reg = PCA9552_LS0 + led / 4; - state = (pca955x_read(s, reg) >> (led % 8)) & 0x3; + state = (pca955x_read(s, reg) >> ((led % 4) * 2)) & 0x3; visit_type_str(v, name, (char **)&led_state[state], errp); } |