aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2013-06-07 15:00:36 +0200
committerMichael Roth <mdroth@linux.vnet.ibm.com>2013-06-17 18:01:42 -0500
commit055a7fce6513a67ecb7db06f808013faa916327e (patch)
treed2d6c3d731bbe1fc12563f0d3b224314566d1e46
parent93bc62438402a21c6b6fedc3c11c951438d506e0 (diff)
smbios: Check R in -smbios type=0, release=R parses okay
Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Laszlo "ever the optimist" Ersek <lersek@redhat.com> Message-id: 1370610036-10577-7-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> (cherry picked from commit 6e5c4540d18d1e9a5253104df161a7e0d408ca95) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r--hw/i386/smbios.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 6431dd4d84..e708cb8919 100644
--- a/hw/i386/smbios.c
+++ b/hw/i386/smbios.c
@@ -140,7 +140,10 @@ static void smbios_build_type_0_fields(const char *t)
bios_release_date_str),
buf, strlen(buf) + 1);
if (get_param_value(buf, sizeof(buf), "release", t)) {
- sscanf(buf, "%hhu.%hhu", &major, &minor);
+ if (sscanf(buf, "%hhu.%hhu", &major, &minor) != 2) {
+ error_report("Invalid release");
+ exit(1);
+ }
smbios_add_field(0, offsetof(struct smbios_type_0,
system_bios_major_release),
&major, 1);