From 055a7fce6513a67ecb7db06f808013faa916327e Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Fri, 7 Jun 2013 15:00:36 +0200 Subject: smbios: Check R in -smbios type=0, release=R parses okay Signed-off-by: Markus Armbruster Reviewed-by: Laszlo "ever the optimist" Ersek Message-id: 1370610036-10577-7-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori (cherry picked from commit 6e5c4540d18d1e9a5253104df161a7e0d408ca95) Signed-off-by: Michael Roth --- hw/i386/smbios.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 6431dd4d84..e708cb8919 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -140,7 +140,10 @@ static void smbios_build_type_0_fields(const char *t) bios_release_date_str), buf, strlen(buf) + 1); if (get_param_value(buf, sizeof(buf), "release", t)) { - sscanf(buf, "%hhu.%hhu", &major, &minor); + if (sscanf(buf, "%hhu.%hhu", &major, &minor) != 2) { + error_report("Invalid release"); + exit(1); + } smbios_add_field(0, offsetof(struct smbios_type_0, system_bios_major_release), &major, 1); -- cgit v1.2.3