diff options
| author | Tak Wai Wong <64229756+tak-hntlabs@users.noreply.github.com> | 2022-09-19 09:39:06 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-19 18:39:06 +0200 |
| commit | 99f6b6a95234f59a16806b9dc6b16cb41f038504 (patch) | |
| tree | 7acf1cc735354b93ae62dc50f3227175efff20c3 /syncapi/storage/postgres | |
| parent | 7bfc3074d10b2cd91b37290e39d3882119853107 (diff) | |
Bug fix #2718 appservice txnid should be different for each batch of events (#2719)
See issue: [#2718](https://github.com/matrix-org/dendrite/issues/2718)
for more details.
The fix assumes that if the number of transaction items are different,
then the txnid should be different.
txnid := OriginalServerTS()_len(transactions)
The case that it doesn't address is if the txnid generated this way is
the same for 2 different batches of events which have the same
OriginalServerTS and the same array length.
Another option:
txnid := OriginalServerTS()_hash(transactions)
Would love to hear other ideas and ways to fix this.
### Pull Request Checklist
* [x ] I have added added tests for PR _or_ I have justified why this PR
doesn't need tests.
* [x ] Pull request includes a [sign
off](https://github.com/matrix-org/dendrite/blob/main/docs/CONTRIBUTING.md#sign-off)
Signed-off-by: `Tak Wai Wong <tak@hntlabs.com>`
Co-authored-by: Tak Wai Wong <tak@hntlabs.com>
Diffstat (limited to 'syncapi/storage/postgres')
0 files changed, 0 insertions, 0 deletions