diff options
| author | kegsay <kegan@matrix.org> | 2022-04-08 17:53:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-08 17:53:24 +0100 |
| commit | 6d25bd6ca57f518404000c47d69bcbfadb4fd2ef (patch) | |
| tree | 14246daf0644ccbafd255b930887695382bbe8f8 /syncapi/storage/postgres/output_room_events_topology_table.go | |
| parent | 986d27a1287e9d86fe16a6152f2457657513a6dd (diff) | |
syncapi: add more tests; fix more bugs (#2338)
* syncapi: add more tests; fix more bugs
bugfixes:
- The postgres impl of TopologyTable.SelectEventIDsInRange did not use the provided txn
- The postgres impl of EventsTable.SelectEvents did not preserve the ordering of the input event IDs in the output events slice
- The sqlite impl of EventsTable.SelectEvents did not use a bulk `IN ($1)` query.
Added tests:
- `TestGetEventsInRangeWithTopologyToken`
- `TestOutputRoomEventsTable`
- `TestTopologyTable`
* -p 1 for now
Diffstat (limited to 'syncapi/storage/postgres/output_room_events_topology_table.go')
| -rw-r--r-- | syncapi/storage/postgres/output_room_events_topology_table.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/syncapi/storage/postgres/output_room_events_topology_table.go b/syncapi/storage/postgres/output_room_events_topology_table.go index 626386ba..90b3b008 100644 --- a/syncapi/storage/postgres/output_room_events_topology_table.go +++ b/syncapi/storage/postgres/output_room_events_topology_table.go @@ -148,9 +148,9 @@ func (s *outputRoomEventsTopologyStatements) SelectEventIDsInRange( // is requested or not. var stmt *sql.Stmt if chronologicalOrder { - stmt = s.selectEventIDsInRangeASCStmt + stmt = sqlutil.TxStmt(txn, s.selectEventIDsInRangeASCStmt) } else { - stmt = s.selectEventIDsInRangeDESCStmt + stmt = sqlutil.TxStmt(txn, s.selectEventIDsInRangeDESCStmt) } // Query the event IDs. |