diff options
| author | Till <2353100+S7evinK@users.noreply.github.com> | 2024-01-20 21:20:37 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-20 21:20:37 +0100 |
| commit | d357615452893cf3440d9dbdf998a2654c439d33 (patch) | |
| tree | 3957f2a2f76155b25010245d4ebf4cc3f3f0a231 /clientapi | |
| parent | bebf701dce01d47264d694b118c81dcb84a37b04 (diff) | |
Don't send device list updates upon registration (#3307)
Fixes https://github.com/matrix-org/dendrite/issues/3273
As we otherwise send down device list updates which are merely useful
for the user and causes tests to be flakey:
```
❌ TestPushSync/Adding_a_push_rule_wakes_up_an_incremental_/sync (10ms)
push_test.go:57: no pushrules found in sync response: {"next_batch":"s0_0_0_0_0_1_1_0_1","device_lists":{"changed":["@user-1:hs1"]}}
```
What this does: If a `PerformDeviceCreation` request is coming from
registering an account, it does **not** send device list updates, as
they are merely useful (no joined rooms, no one to inform) . In all
other cases, the behavior is unchanged and device list updates are sent
as usual.
Diffstat (limited to 'clientapi')
| -rw-r--r-- | clientapi/routing/register.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/clientapi/routing/register.go b/clientapi/routing/register.go index 558418a6..5235e909 100644 --- a/clientapi/routing/register.go +++ b/clientapi/routing/register.go @@ -630,6 +630,7 @@ func handleGuestRegistration( AccessToken: token, IPAddr: req.RemoteAddr, UserAgent: req.UserAgent(), + FromRegistration: true, }, &devRes) if err != nil { return util.JSONResponse{ @@ -919,6 +920,7 @@ func completeRegistration( DeviceID: deviceID, IPAddr: ipAddr, UserAgent: userAgent, + FromRegistration: true, }, &devRes) if err != nil { return util.JSONResponse{ |