aboutsummaryrefslogtreecommitdiff
path: root/.gitignore
diff options
context:
space:
mode:
authorAlexandre Oliveira <1251067+Xinayder@users.noreply.github.com>2024-02-29 08:13:59 +0100
committerGitHub <noreply@github.com>2024-02-29 08:13:59 +0100
commit66865597e2785c5b8c8a040b8e64a2ac45df6a67 (patch)
tree873f6d28d4181d8a378dbd62e704045894a2121b /.gitignore
parent4452833099e9084af26c141d8b9dfcfd9c1fac62 (diff)
Use port number instead of name for k8s service port (#3256)
I've found an issue when deploying Dendrite's Helm chart on my local cluster. The template for generating an Ingress resource tries to find the service port using a name (`http`), but the template that generates the Service resource, instead, identifies the resource with a port number. According to the [Kubernetes ServiceSpec](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/), `ports.targetPort` can be either a number or a string; if it's the latter, it will be looked up as a named port in the pod's container ports. ### Pull Request Checklist <!-- Please read https://matrix-org.github.io/dendrite/development/contributing before submitting your pull request --> * [x] I have added Go unit tests or [Complement integration tests](https://github.com/matrix-org/complement) for this PR _or_ I have justified why this PR doesn't need tests * [x] Pull request includes a [sign off below using a legally identifiable name](https://matrix-org.github.io/dendrite/development/contributing#sign-off) _or_ I have already signed off privately [skip ci]
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions