1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
|
#!/usr/bin/env python3
# Copyright (c) 2023 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""
Test that wallet correctly tracks transactions that have been conflicted by blocks, particularly during reorgs.
"""
from decimal import Decimal
from test_framework.test_framework import BitcoinTestFramework
from test_framework.util import (
assert_equal,
)
class TxConflicts(BitcoinTestFramework):
def add_options(self, parser):
self.add_wallet_options(parser)
def set_test_params(self):
self.num_nodes = 3
def skip_test_if_missing_module(self):
self.skip_if_no_wallet()
def get_utxo_of_value(self, from_tx_id, search_value):
return next(tx_out["vout"] for tx_out in self.nodes[0].gettransaction(from_tx_id)["details"] if tx_out["amount"] == Decimal(f"{search_value}"))
def run_test(self):
self.log.info("Send tx from which to conflict outputs later")
txid_conflict_from_1 = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), Decimal("10"))
txid_conflict_from_2 = self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), Decimal("10"))
self.generate(self.nodes[0], 1)
self.sync_blocks()
self.log.info("Disconnect nodes to broadcast conflicts on their respective chains")
self.disconnect_nodes(0, 1)
self.disconnect_nodes(2, 1)
self.log.info("Create transactions that conflict with each other")
output_A = self.get_utxo_of_value(from_tx_id=txid_conflict_from_1, search_value=10)
output_B = self.get_utxo_of_value(from_tx_id=txid_conflict_from_2, search_value=10)
# First create a transaction that consumes both A and B outputs.
#
# | tx1 | -----> | | | |
# | AB_parent_tx | ----> | Child_Tx |
# | tx2 | -----> | | | |
#
inputs_tx_AB_parent = [{"txid": txid_conflict_from_1, "vout": output_A}, {"txid": txid_conflict_from_2, "vout": output_B}]
tx_AB_parent = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs_tx_AB_parent, {self.nodes[0].getnewaddress(): Decimal("19.99998")}))
# Secondly, create two transactions: One consuming output_A, and another one consuming output_B
#
# | tx1 | -----> | Tx_A_1 |
# ----------------
# | tx2 | -----> | Tx_B_1 |
#
inputs_tx_A_1 = [{"txid": txid_conflict_from_1, "vout": output_A}]
inputs_tx_B_1 = [{"txid": txid_conflict_from_2, "vout": output_B}]
tx_A_1 = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs_tx_A_1, {self.nodes[0].getnewaddress(): Decimal("9.99998")}))
tx_B_1 = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs_tx_B_1, {self.nodes[0].getnewaddress(): Decimal("9.99998")}))
self.log.info("Broadcast conflicted transaction")
txid_AB_parent = self.nodes[0].sendrawtransaction(tx_AB_parent["hex"])
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
# Now that 'AB_parent_tx' was broadcast, build 'Child_Tx'
output_c = self.get_utxo_of_value(from_tx_id=txid_AB_parent, search_value=19.99998)
inputs_tx_C_child = [({"txid": txid_AB_parent, "vout": output_c})]
tx_C_child = self.nodes[0].signrawtransactionwithwallet(self.nodes[0].createrawtransaction(inputs_tx_C_child, {self.nodes[0].getnewaddress() : Decimal("19.99996")}))
tx_C_child_txid = self.nodes[0].sendrawtransaction(tx_C_child["hex"])
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
self.log.info("Broadcast conflicting tx to node 1 and generate a longer chain")
conflicting_txid_A = self.nodes[1].sendrawtransaction(tx_A_1["hex"])
self.generate(self.nodes[1], 4, sync_fun=self.no_op)
conflicting_txid_B = self.nodes[1].sendrawtransaction(tx_B_1["hex"])
self.generate(self.nodes[1], 4, sync_fun=self.no_op)
self.log.info("Connect nodes 0 and 1, trigger reorg and ensure that the tx is effectively conflicted")
self.connect_nodes(0, 1)
self.sync_blocks([self.nodes[0], self.nodes[1]])
conflicted_AB_tx = self.nodes[0].gettransaction(txid_AB_parent)
tx_C_child = self.nodes[0].gettransaction(tx_C_child_txid)
conflicted_A_tx = self.nodes[0].gettransaction(conflicting_txid_A)
self.log.info("Verify, after the reorg, that Tx_A was accepted, and tx_AB and its Child_Tx are conflicting now")
# Tx A was accepted, Tx AB was not.
assert conflicted_AB_tx["confirmations"] < 0
assert conflicted_A_tx["confirmations"] > 0
# Conflicted tx should have confirmations set to the confirmations of the most conflicting tx
assert_equal(-conflicted_AB_tx["confirmations"], conflicted_A_tx["confirmations"])
# Child should inherit conflicted state from parent
assert_equal(-tx_C_child["confirmations"], conflicted_A_tx["confirmations"])
# Check the confirmations of the conflicting transactions
assert_equal(conflicted_A_tx["confirmations"], 8)
assert_equal(self.nodes[0].gettransaction(conflicting_txid_B)["confirmations"], 4)
self.log.info("Now generate a longer chain that does not contain any tx")
# Node2 chain without conflicts
self.generate(self.nodes[2], 15, sync_fun=self.no_op)
# Connect node0 and node2 and wait reorg
self.connect_nodes(0, 2)
self.sync_blocks()
conflicted = self.nodes[0].gettransaction(txid_AB_parent)
tx_C_child = self.nodes[0].gettransaction(tx_C_child_txid)
self.log.info("Test that formerly conflicted transaction are inactive after reorg")
# Former conflicted tx should be unconfirmed as it hasn't been yet rebroadcast
assert_equal(conflicted["confirmations"], 0)
# Former conflicted child tx should be unconfirmed as it hasn't been rebroadcast
assert_equal(tx_C_child["confirmations"], 0)
# Rebroadcast former conflicted tx and check it confirms smoothly
self.nodes[2].sendrawtransaction(conflicted["hex"])
self.generate(self.nodes[2], 1)
self.sync_blocks()
former_conflicted = self.nodes[0].gettransaction(txid_AB_parent)
assert_equal(former_conflicted["confirmations"], 1)
assert_equal(former_conflicted["blockheight"], 217)
if __name__ == '__main__':
TxConflicts().main()
|
