aboutsummaryrefslogtreecommitdiff
path: root/src/net_processing.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'src/net_processing.cpp')
-rw-r--r--src/net_processing.cpp16
1 files changed, 13 insertions, 3 deletions
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index 8137e17c98..080d6241c9 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -243,6 +243,9 @@ struct Peer {
* Most peers use headers-first syncing, which doesn't use this mechanism */
uint256 m_continuation_block GUARDED_BY(m_block_inv_mutex) {};
+ /** Set to true once initial VERSION message was sent (only relevant for outbound peers). */
+ bool m_outbound_version_message_sent GUARDED_BY(NetEventsInterface::g_msgproc_mutex){false};
+
/** This peer's reported block height when we connected */
std::atomic<int> m_starting_height{-1};
@@ -1677,9 +1680,6 @@ void PeerManagerImpl::InitializeNode(CNode& node, ServiceFlags our_services)
LOCK(m_peer_mutex);
m_peer_map.emplace_hint(m_peer_map.end(), nodeid, peer);
}
- if (!node.IsInboundConn()) {
- PushNodeVersion(node, *peer);
- }
}
void PeerManagerImpl::ReattemptInitialBroadcast(CScheduler& scheduler)
@@ -5326,6 +5326,10 @@ bool PeerManagerImpl::ProcessMessages(CNode* pfrom, std::atomic<bool>& interrupt
PeerRef peer = GetPeerRef(pfrom->GetId());
if (peer == nullptr) return false;
+ // For outbound connections, ensure that the initial VERSION message
+ // has been sent first before processing any incoming messages
+ if (!pfrom->IsInboundConn() && !peer->m_outbound_version_message_sent) return false;
+
{
LOCK(peer->m_getdata_requests_mutex);
if (!peer->m_getdata_requests.empty()) {
@@ -5817,6 +5821,12 @@ bool PeerManagerImpl::SendMessages(CNode* pto)
// disconnect misbehaving peers even before the version handshake is complete.
if (MaybeDiscourageAndDisconnect(*pto, *peer)) return true;
+ // Initiate version handshake for outbound connections
+ if (!pto->IsInboundConn() && !peer->m_outbound_version_message_sent) {
+ PushNodeVersion(*pto, *peer);
+ peer->m_outbound_version_message_sent = true;
+ }
+
// Don't send anything until the version handshake is complete
if (!pto->fSuccessfullyConnected || pto->fDisconnect)
return true;