diff options
| -rw-r--r-- | src/bench/sign_transaction.cpp | 2 | ||||
| -rw-r--r-- | src/bitcoin-tx.cpp | 10 | ||||
| -rw-r--r-- | src/qt/bitcoinunits.cpp | 2 | ||||
| -rw-r--r-- | src/test/validation_block_tests.cpp | 2 |
4 files changed, 8 insertions, 8 deletions
diff --git a/src/bench/sign_transaction.cpp b/src/bench/sign_transaction.cpp index 3f0635711d..40219458f3 100644 --- a/src/bench/sign_transaction.cpp +++ b/src/bench/sign_transaction.cpp @@ -62,7 +62,7 @@ static void SignTransactionSingleInput(benchmark::Bench& bench, InputType input_ bench.minEpochIterations(100).run([&] { CMutableTransaction tx{unsigned_tx}; std::map<COutPoint, Coin> coins; - CScript prev_spk = prev_spks[(iter++) % prev_spks.size()]; + const CScript& prev_spk = prev_spks[(iter++) % prev_spks.size()]; coins[prevout] = Coin(CTxOut(10000, prev_spk), /*nHeightIn=*/100, /*fCoinBaseIn=*/false); std::map<int, bilingual_str> input_errors; bool complete = SignTransaction(tx, &keystore, coins, SIGHASH_ALL, input_errors); diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index 1561510db8..7f96c626b1 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -304,7 +304,7 @@ static void MutateTxAddOutAddr(CMutableTransaction& tx, const std::string& strIn CAmount value = ExtractAndValidateValue(vStrInputParts[0]); // extract and validate ADDRESS - std::string strAddr = vStrInputParts[1]; + const std::string& strAddr = vStrInputParts[1]; CTxDestination destination = DecodeDestination(strAddr); if (!IsValidDestination(destination)) { throw std::runtime_error("invalid TX output address"); @@ -337,7 +337,7 @@ static void MutateTxAddOutPubKey(CMutableTransaction& tx, const std::string& str bool bSegWit = false; bool bScriptHash = false; if (vStrInputParts.size() == 3) { - std::string flags = vStrInputParts[2]; + const std::string& flags = vStrInputParts[2]; bSegWit = (flags.find('W') != std::string::npos); bScriptHash = (flags.find('S') != std::string::npos); } @@ -398,7 +398,7 @@ static void MutateTxAddOutMultiSig(CMutableTransaction& tx, const std::string& s bool bSegWit = false; bool bScriptHash = false; if (vStrInputParts.size() == numkeys + 4) { - std::string flags = vStrInputParts.back(); + const std::string& flags = vStrInputParts.back(); bSegWit = (flags.find('W') != std::string::npos); bScriptHash = (flags.find('S') != std::string::npos); } @@ -473,14 +473,14 @@ static void MutateTxAddOutScript(CMutableTransaction& tx, const std::string& str CAmount value = ExtractAndValidateValue(vStrInputParts[0]); // extract and validate script - std::string strScript = vStrInputParts[1]; + const std::string& strScript = vStrInputParts[1]; CScript scriptPubKey = ParseScript(strScript); // Extract FLAGS bool bSegWit = false; bool bScriptHash = false; if (vStrInputParts.size() == 3) { - std::string flags = vStrInputParts.back(); + const std::string& flags = vStrInputParts.back(); bSegWit = (flags.find('W') != std::string::npos); bScriptHash = (flags.find('S') != std::string::npos); } diff --git a/src/qt/bitcoinunits.cpp b/src/qt/bitcoinunits.cpp index fe3eb3240b..f73d83e4fc 100644 --- a/src/qt/bitcoinunits.cpp +++ b/src/qt/bitcoinunits.cpp @@ -166,7 +166,7 @@ bool BitcoinUnits::parse(Unit unit, const QString& value, CAmount* val_out) { return false; // More than one dot } - QString whole = parts[0]; + const QString& whole = parts[0]; QString decimals; if(parts.size() > 1) diff --git a/src/test/validation_block_tests.cpp b/src/test/validation_block_tests.cpp index f5c4204c55..f3bc8e7139 100644 --- a/src/test/validation_block_tests.cpp +++ b/src/test/validation_block_tests.cpp @@ -181,7 +181,7 @@ BOOST_AUTO_TEST_CASE(processnewblock_signals_ordering) bool ignored; FastRandomContext insecure; for (int i = 0; i < 1000; i++) { - auto block = blocks[insecure.randrange(blocks.size() - 1)]; + const auto& block = blocks[insecure.randrange(blocks.size() - 1)]; Assert(m_node.chainman)->ProcessNewBlock(block, true, true, &ignored); } |