aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>2022-12-05 15:15:36 +0100
committerMarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>2022-12-07 17:55:58 +0100
commitfa2cc5d1d66aa00e828d1bb65b9923f76fbdf4e1 (patch)
treef811622bc34ee70efcfbd707b09c6743f8bf567e /test
parent9052d869c9679d997931084384c026450c2d918b (diff)
downloadbitcoin-fa2cc5d1d66aa00e828d1bb65b9923f76fbdf4e1.tar.xz
bugfix: Strict type checking for RPC boolean parameters
Diffstat (limited to 'test')
-rwxr-xr-xtest/functional/rpc_net.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py
index 0501befe0f..06e76c4f92 100755
--- a/test/functional/rpc_net.py
+++ b/test/functional/rpc_net.py
@@ -307,6 +307,9 @@ class NetTest(BitcoinTestFramework):
assert_equal(node.addpeeraddress(address="", port=8333), {"success": False})
assert_equal(node.getnodeaddresses(count=0), [])
+ self.log.debug("Test that non-bool tried fails")
+ assert_raises_rpc_error(-3, "JSON value of type string is not of expected type bool", self.nodes[0].addpeeraddress, address="1.2.3.4", tried="True", port=1234)
+
self.log.debug("Test that adding an address with invalid port fails")
assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress, address="1.2.3.4", port=-1)
assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress,address="1.2.3.4", port=65536)