diff options
| author | merge-script <fanquake@gmail.com> | 2024-05-07 10:28:58 +0800 |
|---|---|---|
| committer | merge-script <fanquake@gmail.com> | 2024-05-07 10:28:58 +0800 |
| commit | ef09f535b7b540d997f8c2bfa67b3386711bc8b4 (patch) | |
| tree | 990c635d8d3c6bc83daa178c7bbb2c1e9e444a91 /test | |
| parent | 63d0b930f821132badd804822a46232a5f98bbef (diff) | |
| parent | a68fed111be393ddbbcd7451f78bc63601253ee0 (diff) | |
| download | bitcoin-ef09f535b7b540d997f8c2bfa67b3386711bc8b4.tar.xz | |
Merge bitcoin/bitcoin#29984: net: Replace ifname check with IFF_LOOPBACK in Discover
a68fed111be393ddbbcd7451f78bc63601253ee0 net: Fix misleading comment for Discover (laanwj)
7766dd280d9a4a7ffdfcec58224d0985cfd4169b net: Replace ifname check with IFF_LOOPBACK in Discover (laanwj)
Pull request description:
Checking the interface name is kind of brittle. In the age of network namespaces and containers, there is no reason a loopback interface can't be called differently.
Check for the `IFF_LOOPBACK` flag to detect loopback interface instead.
Also remove a misleading comment in Discover's doc comment.
ACKs for top commit:
sipa:
utACK a68fed111be393ddbbcd7451f78bc63601253ee0
willcl-ark:
utACK a68fed111be393ddbbcd7451f78bc63601253ee0
theuni:
utACK a68fed111be393ddbbcd7451f78bc63601253ee0. Satoshi-era brittleness :)
Tree-SHA512: e2d7fc541f40f6a6af08286e7bcb0873ff55debdcd8b38b03f274897b673a6fb51d84d6c7241a02a9567ddf2645f50231d91bb1f55307ba7c6e68196c29b0edf
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions