diff options
| author | fanquake <fanquake@gmail.com> | 2023-08-17 13:34:10 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-08-17 13:58:31 +0100 |
| commit | ecb20563b6a0cdd615628da9caa1e7389998119c (patch) | |
| tree | 56b2755fcf80d2c53c8dc9c0e4104e4e613fcd4f /test | |
| parent | 6d473bad2260fd23c6013581e44c9970b557f495 (diff) | |
| parent | 5e3e83b005518659a69916c373b808da27e51791 (diff) | |
Merge bitcoin/bitcoin#28123: Bugfix: RPC: Remove quotes from non-string oneline descriptions
5e3e83b005518659a69916c373b808da27e51791 RPC/Mining: Document template_request better for getblocktemplate (Luke Dashjr)
de319c61759952318364fbcb28c47f0959d89d0e RPC/rpcdoccheck: Error if a oneline_description has a quote for a non-string (Luke Dashjr)
7c61e9df90579ed42a30016e52355e437733b128 Bugfix: RPC: Remove quotes from non-string oneline descriptions (Luke Dashjr)
Pull request description:
Various JSON Object parameters had a `oneline_description` with quote characters. Fix those, and extend `rpcdoccheck` to detect them.
Also, slightly improve GBT's oneline description for template_request.
ACKs for top commit:
MarcoFalke:
review ACK 5e3e83b005518659a69916c373b808da27e51791
Tree-SHA512: 363d1669a661d0acfc19fddb57e777d781c7246f330cf62160e77dde10a6adcb0249db748127067da1afe1b7d17c71cf611d9fdc3664d6bf5b3f30105637769a
Diffstat (limited to 'test')
| -rwxr-xr-x | test/functional/mining_basic.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/functional/mining_basic.py b/test/functional/mining_basic.py index 56cd615dac..da796d3f70 100755 --- a/test/functional/mining_basic.py +++ b/test/functional/mining_basic.py @@ -172,7 +172,7 @@ class MiningTest(BitcoinTestFramework): block.vtx = [coinbase_tx] self.log.info("getblocktemplate: segwit rule must be set") - assert_raises_rpc_error(-8, "getblocktemplate must be called with the segwit rule set", node.getblocktemplate) + assert_raises_rpc_error(-8, "getblocktemplate must be called with the segwit rule set", node.getblocktemplate, {}) self.log.info("getblocktemplate: Test valid block") assert_template(node, block, None) |